Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Implement sorting for network roles column
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Implement sorting for network roles column
......................................................................
webadmin: Implement sorting for network roles column
Implemented logic to compare between network roles in the
Network/Clusters subtab.
Change-Id: Icd9fa5bfee38e9b46f94708f5b4d88240261b404
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlWithSafeHtmlTooltipColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
2 files changed, 21 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30156
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd9fa5bfee38e9b46f94708f5b4d88240261b404
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Sort checkbox columns in Network/Clusters subtab
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Sort checkbox columns in Network/Clusters subtab
......................................................................
webadmin: Sort checkbox columns in Network/Clusters subtab
Implemented sorting using the recently added default sorting behavior
in CheckboxColumn.
Change-Id: Ic1ea118ded65ce1ebe426a7bfbf2a7cc993380b0
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30155
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1ea118ded65ce1ebe426a7bfbf2a7cc993380b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Render Provider/Networks subtab columns sortable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Render Provider/Networks subtab columns sortable
......................................................................
webadmin: Render Provider/Networks subtab columns sortable
All text columns, so enough to switch on the default
TextColumnWithTooltip sorting.
Change-Id: Id7f4da05a61affa686cc6073a91ea018dfdcf9df
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7f4da05a61affa686cc6073a91ea018dfdcf9df
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Render Profile main tab and subtab columns sortable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Render Profile main tab and subtab columns sortable
......................................................................
webadmin: Render Profile main tab and subtab columns sortable
All columns are simple text columns, so it was enough to apply the
default sorting implemented in TextColumnWithTooltip.
Change-Id: I05fcdbc6cb30c048039ed52a1abf7e5b4e093792
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVnicProfileView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileTemplateView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/profile/SubTabVnicProfileVmView.java
3 files changed, 16 insertions(+), 6 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05fcdbc6cb30c048039ed52a1abf7e5b4e093792
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Render Networks subtab columns sortable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Render Networks subtab columns sortable
......................................................................
webadmin: Render Networks subtab columns sortable
Turned on default text column sorting for all relevant subtab columns
under the networks main tab.
Change-Id: I0e95f529114e62536de0a4f13e8acb20eb6e651d
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionWithInheritedPermissionListModelTable.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkExternalSubnetView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkProfileView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkTemplateView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java
8 files changed, 44 insertions(+), 5 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30152
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e95f529114e62536de0a4f13e8acb20eb6e651d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Render Providers main tab columns sortable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Render Providers main tab columns sortable
......................................................................
webadmin: Render Providers main tab columns sortable
Rendered columns sortable via server-side sorting.
Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
2 files changed, 12 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Render Networks main tab columns sortable
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Render Networks main tab columns sortable
......................................................................
webadmin: Render Networks main tab columns sortable
Rendered all columns sortable except for:
* Comment isn't helpful when it's displayed as icon.
* Role and Provider, don't currently support server-side sorting.
Change-Id: I440ad9be062547cdf4b1bad68d8f4d62072b5bef
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java
3 files changed, 22 insertions(+), 10 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30150
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I440ad9be062547cdf4b1bad68d8f4d62072b5bef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Implement permission sorting by role icon
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Implement permission sorting by role icon
......................................................................
webadmin: Implement permission sorting by role icon
Implemented sorting for permission subtabs according to the role icon
(ordinary user is lesser than administrator).
Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Implement default sort order for CheckboxColumn
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Implement default sort order for CheckboxColumn
......................................................................
webadmin: Implement default sort order for CheckboxColumn
Similarly to what was done with TextColumnWithTooltip, it makes sense
to implement some default sorting behavior for CheckboxColumn.
Change-Id: I7c70dd4c052ba21660f16ae223eb00ccf5d5edba
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java
1 file changed, 22 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/30148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c70dd4c052ba21660f16ae223eb00ccf5d5edba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: restapi: Standard exception mappers
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Standard exception mappers
......................................................................
restapi: Standard exception mappers
Currently we use Resteasy specific code in the exception mappers. This
patch removes this code, as is now unnecessary.
Change-Id: If033d3370f705149747d37ebfb76d053044823c4
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbExceptionMapper.java
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbMarshallExceptionMapper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JsonExceptionMapper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MalformedIdExceptionMapper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MappingExceptionMapper.java
6 files changed, 48 insertions(+), 84 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If033d3370f705149747d37ebfb76d053044823c4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months