Change in ovirt-engine[ovirt-engine-3.5]: webadmin: VM's template information is inconsistent after up...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: VM's template information is inconsistent after upgrading to 3.4
......................................................................
webadmin: VM's template information is inconsistent after upgrading to 3.4
Having a thin provisioned VM created in 3.3 and updated it to 3.5 the VM
General subtab showed:
"TemplateName"
But if created in 3.4 and later it showed:
"TemplateName (Thin/Dependent)"
This patch unifies it so also the older VMs show up in the new format.
Change-Id: Ie55359039cf45a758f132e8c797f033f73222457
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1084940
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmTemplateNameRenderer.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie55359039cf45a758f132e8c797f033f73222457
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: updated insert_calendar_table_values script
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: updated insert_calendar_table_values script
......................................................................
packaging: updated insert_calendar_table_values script
fixed the script so that the values generated
will not be affected due to timezones that are not
of round hours.
Change-Id: Ib525d093d6c54f3153f23f7d499362ba6d4fb25b
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_04_0100_updated_insert_calendar_table_values_script.sql
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Shirly Radco: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30786
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib525d093d6c54f3153f23f7d499362ba6d4fb25b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: ovirt-engine-dwh-3.4
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: core: Set images with Storage Pool for images already on tar...
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set images with Storage Pool for images already on target.
......................................................................
core: Set images with Storage Pool for images already on target.
Setting images with storage pool id only for images which are already on
the Storage Domain, since importing a VM from configuration through the REST
does not oblegate an initialized Storage Domain
Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40
Bug-Url: https://bugzilla.redhat.com/1124879
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/30827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Add test for import unregistered VM
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add test for import unregistered VM
......................................................................
core: Add test for import unregistered VM
Adding a test for ImportVmFromConfigurationCommand to test an import of
unregistered VM.
Change-Id: Ie6f68a66da4de6b9dbfb664d3678b25582a82496
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java
A backend/manager/modules/bll/src/test/resources/vmOvfData.xml
3 files changed, 184 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/29795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f68a66da4de6b9dbfb664d3678b25582a82496
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: frontend: Fix Coverity Scan defect in UiCommon test
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix Coverity Scan defect in UiCommon test
......................................................................
frontend: Fix Coverity Scan defect in UiCommon test
Change-Id: Ie8bf598c928ed5530a050df45727033c6ff6f464
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Betak: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8bf598c928ed5530a050df45727033c6ff6f464
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in jenkins[master]: Added ovirt-reports
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Added ovirt-reports
......................................................................
Added ovirt-reports
Change-Id: I290af7cb1424903722ffb421d0b5677f5cf3641b
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/shell-scripts/build_local_srcrpm.sh
A jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_create-rpms.yaml
A jobs/confs/yaml/scms/ovirt-reports.yaml
3 files changed, 49 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve
Eyal Edri: Looks good to me, approved
David Caro: Verified
--
To view, visit http://gerrit.ovirt.org/30531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I290af7cb1424903722ffb421d0b5677f5cf3641b
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: jsonrpc: client side heartbeat implementation
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: jsonrpc: client side heartbeat implementation
......................................................................
jsonrpc: client side heartbeat implementation
There is new vdsHeartBeat option in the database which default value is
10 seconds. This option is propagated down to json client.
Change-Id: I9e8a20592542ce1a754dee1917ff9ebba6b8daf9
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M pom.xml
8 files changed, 26 insertions(+), 16 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e8a20592542ce1a754dee1917ff9ebba6b8daf9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[master]: webadmin: GWT debug mode speedup.
by awels＠redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: GWT debug mode speedup.
......................................................................
webadmin: GWT debug mode speedup.
Debug mode would take around 4:30 to get from the login page to
the VM main tab when logging in. This is due to the proxy event
on UiCommonInitEvent in AbstractSubTabPresenter. This event would
fire and it would cause all sub classes of AbstractSubTabPresenter
to initialize and since the code was split, it would have to load
every single sub tab presenter everywhere at once. This took about
500ms-3000ms depending on the presenter. With around 200 sub tab
presenters, it would take a long long time.
This patch removes the proxy event and instead places the handler
initialization in the onBind of the presenter. This should have the
exact same effect as before (the handlers are initalized when the
presenter is activated vs when the application is initalized).
Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1110788
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterGeneralPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostHardwarePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineGeneralPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineSnapshotPresenter.java
8 files changed, 20 insertions(+), 23 deletions(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30710
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: increase guide me button size
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: increase guide me button size
......................................................................
webadmin: increase guide me button size
- Increase the size of the guide me buttons
to be the width of the popup window so it
doesn't cut of messages in other locales.
Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121108
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30861
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Threshold validation for stateless VM
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Threshold validation for stateless VM
......................................................................
core: Threshold validation for stateless VM
When a VM is run as stateless, temporary volumes are created for
each disk leaf. Threshold validation is added in this patch.
Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb
Bug-Url: https://bugzilla.redhat.com/1054175
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/30856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months