July 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: Storage validation when running stateless VM
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Storage validation when running stateless VM ...................................................................... core: Storage validation when running stateless VM When a VM is run as stateless, temporary volumes are created for each disk leaf. Up till now there were no storage validations in this case. These were added in this patch, along with some new functionality to the MultipleStorageDomainsValidator, as well as related tests. Change-Id: Id04203119cce475afeef7658db50e132b0c7036a Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java 3 files changed, 60 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id04203119cce475afeef7658db50e132b0c7036a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Added VM memory validation on snapshot
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added VM memory validation on snapshot ...................................................................... core: Added VM memory validation on snapshot Up till now there were no storage validations when creating a snapshot of a running VM with the VM's memory. These validations are now added to the relevant command and validators. Relevant tests were amended/added accordingly. Change-Id: I8fc127147bdea8737fecb034c88079521b8a8bd6 Bug-Url: https://bugzilla.redhat.com/1119022 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/NullableMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/StatelessSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java 10 files changed, 225 insertions(+), 69 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc127147bdea8737fecb034c88079521b8a8bd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fixed edit icons in Setup Host Network dialog pt 3
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 3 ...................................................................... webadmin: fixed edit icons in Setup Host Network dialog pt 3 Commit 83046362c5e727a80ede49075a630f9be9f82a31 broke the edit icon fix from commit 6c03d4171c06328c665098c18145548aa13dcad8. Edit icon was again misplaced. Fixed. Also refactored the CSS -- grouped common classes for 'setup network dialog', and removed patternfly hacks from NetworkItemPanel. Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Bug-Url: https://bugzilla.redhat.com/1114991 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 4 files changed, 8 insertions(+), 18 deletions(-) Approvals: Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Quota tab sorting
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Quota tab sorting ...................................................................... webadmin: Quota tab sorting - Implemented sorting on Quota main tab. - Only for name and description - Implemented sorting on Quota sub tabs. - Not implemented for VM/Template Change-Id: I2740a5a15523da95b599de5b7acf688472d6df49 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119873 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/QuotaConditionFieldAutoCompleter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextColumnWithEditableTooltip.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaPermissionView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaUserView.java 8 files changed, 80 insertions(+), 53 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2740a5a15523da95b599de5b7acf688472d6df49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi : the format of profile\user is not supported by RES...
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi : the format of profile\user is not supported by REST-API ...................................................................... restapi : the format of profile\user is not supported by REST-API the format of domain\user is not supported by restapi Change-Id: I9c8907d4dc612d67bb881af5a579eb8f16ce238a Bug-Url: https://bugzilla.redhat.com/1123545 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c8907d4dc612d67bb881af5a579eb8f16ce238a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fixed edit icons in Setup Host Network dialog pt 3
by lvernia＠redhat.com 30 Jul '14

30 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 3 ...................................................................... webadmin: fixed edit icons in Setup Host Network dialog pt 3 Commit 83046362c5e727a80ede49075a630f9be9f82a31 broke the edit icon fix from commit 6c03d4171c06328c665098c18145548aa13dcad8. Edit icon was again misplaced. Fixed. Also refactored the CSS -- grouped common classes for 'setup network dialog', and removed patternfly hacks from NetworkItemPanel. Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Bug-Url: https://bugzilla.redhat.com/1114991 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 4 files changed, 8 insertions(+), 18 deletions(-) Approvals: oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: increase guide me button size
by awels＠redhat.com 30 Jul '14

30 Jul '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: increase guide me button size ...................................................................... webadmin: increase guide me button size - Increase the size of the guide me buttons to be the width of the popup window so it doesn't cut of messages in other locales. Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121108 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: initialize variable in test
by amureini＠redhat.com 30 Jul '14

30 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: initialize variable in test ...................................................................... core: initialize variable in test Fix coverity issue CID 1229126. Change-Id: I25b2fbeb703a4d148557f0a8aa6adbaafa4e1923 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25b2fbeb703a4d148557f0a8aa6adbaafa4e1923 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Extract Validator creation and apply usages
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Extract Validator creation and apply usages ...................................................................... core: Extract Validator creation and apply usages There are several places creating a MultipleStorageDomainsValidator based on a VM and DisksImage List in the same manner. Some new code for bellow bzs does the same, as will other patches. This patch removed future code duplicity by extracting the duplicated code into VmCommand. Change-Id: I3a6d04fe1a670c814b44bad5304a894faa8f8510 Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a6d04fe1a670c814b44bad5304a894faa8f8510 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixed search Disks when filtered by data-center
by derez＠redhat.com 30 Jul '14

30 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fixed search Disks when filtered by data-center ...................................................................... core: fixed search Disks when filtered by data-center Similar to fix in chnage-id I04e37501b29a17a634e31e8875d63577e5f9f401 (and following change-id I862873171c6753f8c8863c10c336e981e39dc8cb), searching disks (or clusters) by a data-center looks like [1]. I.e. the left outer join is being made on storage_pool_with_storage_domains; which leads to multiple records since a data-center can contain multiple storage domains. Therefore, reverted to previous search so it uses the 'use-tag' syntax [2]. As a result, a similar issue with search Clusters when filtered by data-center has been fixed as well. [1] SELECT all_disks.* FROM all_disks LEFT OUTER JOIN storage_pool_with_storage_domain ON all_disks.storage_pool_id=storage_pool_with_storage_domain.id WHERE storage_pool_with_storage_domain.name ILIKE 'dc35' AND all_disks.disk_storage_type = '0' [2] SELECT * FROM all_disks WHERE (disk_id IN (SELECT all_disks.disk_id FROM all_disks LEFT OUTER JOIN storage_pool_with_storage_domain ON all_disks.storage_pool_id=storage_pool_with_storage_domain.id WHERE (storage_pool_with_storage_domain.name ILIKE 'dc35' AND all_disks.disk_storage_type = '0'))) Change-Id: I3a792fb63421c7589ed073fb18cfaac46a7dd3a9 Bug-Url: https://bugzilla.redhat.com/1124584 Bug-Url: https://bugzilla.redhat.com/1124593 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a792fb63421c7589ed073fb18cfaac46a7dd3a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0