Change in ovirt-engine[master]: engine: allow updating/deleting a network with unplugged vni...
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: allow updating/deleting a network with unplugged vnics only
......................................................................
engine: allow updating/deleting a network with unplugged vnics only
Allow updating/deleting a network from a host only in case when the
related vnics are unplugged. The case when plugged vnic is unlinked
doesn't allow amending the underlying network.
Change-Id: Ib57fd905811bbbb60ef06bae15d0c42518132596
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/predicates/VmNetworkCanBeUpdatedPredicate.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/predicates/VmNetworkCanBeUpdatedPredicateTest.java
4 files changed, 60 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/30020
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib57fd905811bbbb60ef06bae15d0c42518132596
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: added EngineStarting state
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: added EngineStarting state
......................................................................
added EngineStarting state
when then VM with engine is starting it takes some time and goes
thru states "waitforlaunch" and "powering up". During the start up
the engine was marked as UnexpectedlyDown because it wasn't 'up'
and the host got score 0 which might lead to killing the VM while
it's starting and trying to start it on another host where the
same situation repeats.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119705
Change-Id: Ia7e5bb28eeb839b684be74ea768265d9dab01175
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/states.py
M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py
3 files changed, 43 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/30026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7e5bb28eeb839b684be74ea768265d9dab01175
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.1
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: refactoring: use constants for engine states instead of plai...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: refactoring: use constants for engine states instead of plain strings
......................................................................
refactoring: use constants for engine states instead of plain strings
Change-Id: I27ccb6533676edfc1b5bfbf009d5820853eebab6
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py
M ovirt_hosted_engine_ha/lib/Makefile.am
A ovirt_hosted_engine_ha/lib/engine.py
3 files changed, 42 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/30065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27ccb6533676edfc1b5bfbf009d5820853eebab6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.1
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[master]: added EngineStarting state
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: added EngineStarting state
......................................................................
added EngineStarting state
when then VM with engine is starting it takes some time and goes
thru states "waitforlaunch" and "powering up". During the start up
the engine was marked as UnexpectedlyDown because it wasn't 'up'
and the host got score 0 which might lead to killing the VM while
it's starting and trying to start it on another host where the
same situation repeats.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093638
Change-Id: Ia7e5bb28eeb839b684be74ea768265d9dab01175
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/states.py
M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py
3 files changed, 43 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/30025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7e5bb28eeb839b684be74ea768265d9dab01175
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[master]: refactoring: use constants for engine states instead of plai...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: refactoring: use constants for engine states instead of plain strings
......................................................................
refactoring: use constants for engine states instead of plain strings
Change-Id: I27ccb6533676edfc1b5bfbf009d5820853eebab6
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py
M ovirt_hosted_engine_ha/lib/Makefile.am
A ovirt_hosted_engine_ha/lib/engine.py
3 files changed, 42 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/30063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27ccb6533676edfc1b5bfbf009d5820853eebab6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: added EngineStarting state
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: added EngineStarting state
......................................................................
added EngineStarting state
when then VM with engine is starting it takes some time and goes
thru states "waitforlaunch" and "powering up". During the start up
the engine was marked as UnexpectedlyDown because it wasn't 'up'
and the host got score 0 which might lead to killing the VM while
it's starting and trying to start it on another host where the
same situation repeats.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093638
Change-Id: Ia7e5bb28eeb839b684be74ea768265d9dab01175
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/states.py
M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py
3 files changed, 43 insertions(+), 5 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/30027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7e5bb28eeb839b684be74ea768265d9dab01175
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: refactoring: use constants for engine states instead of plai...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: refactoring: use constants for engine states instead of plain strings
......................................................................
refactoring: use constants for engine states instead of plain strings
Change-Id: I27ccb6533676edfc1b5bfbf009d5820853eebab6
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py
M ovirt_hosted_engine_ha/lib/Makefile.am
A ovirt_hosted_engine_ha/lib/engine.py
3 files changed, 42 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/30064
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27ccb6533676edfc1b5bfbf009d5820853eebab6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: engine: confusing error message retrieving from http session
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: engine: confusing error message retrieving from http session
......................................................................
engine: confusing error message retrieving from http session
- Fixed confusing error message when retrieving non existing value
from http session. Instead of throwing error message in log, just
return null.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1101551
Change-Id: I336430e35bbbad07ea9566c8f5293980056361de
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I336430e35bbbad07ea9566c8f5293980056361de
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: upgrade: update vds cpu name of existing hosts to new name.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: upgrade: update vds cpu name of existing hosts to new name.
......................................................................
upgrade: update vds cpu name of existing hosts to new name.
Commit 25b963 changed a certain cpu_name in the vds_option 'ServerCPUList'
to make it more consistent with other cpu names:
'Intel Haswell' -> 'Intel Haswell Family'
This commit add an update of existing clusters to the new name.
Change-Id: I89d41ac4ed0c28ec330c2db82f91bc3fcc9e2073
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114994
Signed-off-by: Mooli Tayer <mtayer(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_0010_update_haswell_vds_to_new_name.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
mooli tayer: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89d41ac4ed0c28ec330c2db82f91bc3fcc9e2073
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: restapi: Faster JAXB element creation
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Faster JAXB element creation
......................................................................
restapi: Faster JAXB element creation
Currently when we need to create a JAXB element we always iterate the
object factory looking for the appropiate method. To improve the
performance of this lookup this patch introduces an index that is
created during startup so that the iteration is done only once.
Change-Id: Ie6f2cc91701ff45a443d3b8b37e8225d7b26c4fa
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/xml/JAXBProvider.java
1 file changed, 19 insertions(+), 13 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
anmolbabu: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/30090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f2cc91701ff45a443d3b8b37e8225d7b26c4fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months