Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix parameters of add DataCenter
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix parameters of add DataCenter
......................................................................
restapi: Fix parameters of add DataCenter
The "local" property of the data center is mandatory, and the version
numbers are optional.
Change-Id: I5db741f4a6d9d479feaf5a51a745e0d0190f841b
Bug-Url: https://bugzilla.redhat.com/1104085
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 013d573fd71139418da30ea53113cdde470ee0eb)
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30092
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5db741f4a6d9d479feaf5a51a745e0d0190f841b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[master]: restapi: Fix parameters of add DataCenter
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix parameters of add DataCenter
......................................................................
restapi: Fix parameters of add DataCenter
The "local" property of the data center is mandatory, and the version
numbers are optional.
Change-Id: I5db741f4a6d9d479feaf5a51a745e0d0190f841b
Bug-Url: https://bugzilla.redhat.com/1104085
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/29938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5db741f4a6d9d479feaf5a51a745e0d0190f841b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: Fix prefix in RSDL
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Fix prefix in RSDL
......................................................................
restapi: Fix prefix in RSDL
Currently during the build process we generate a RSDL document that
contains "href" attributes including the prefix "/ovirt-engine/api". But
the application is deployed twice, once for "/api" and another for
"/ovirt-engine/api", thus the RSDL document presented by "/api" isn't
valid. To avoid this issue this patch changes the build process so that
it will generate a RSDL document that doesn't contain any prefix. The
correct prefix will be added during runtime by each deployment of the
application.
Change-Id: If5fadb92b6f3a6b06e44729c967289c5917f9a25
Bug-Url: https://bugzilla.redhat.com/1102772
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 5a047b30553124a83946ca4447fb801e1bf8ad35)
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
3 files changed, 66 insertions(+), 43 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5fadb92b6f3a6b06e44729c967289c5917f9a25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-engine[master]: restapi: Fix prefix in RSDL
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix prefix in RSDL
......................................................................
restapi: Fix prefix in RSDL
Currently during the build process we generate a RSDL document that
contains "href" attributes including the prefix "/ovirt-engine/api". But
the application is deployed twice, once for "/api" and another for
"/ovirt-engine/api", thus the RSDL document presented by "/api" isn't
valid. To avoid this issue this patch changes the build process so that
it will generate a RSDL document that doesn't contain any prefix. The
correct prefix will be added during runtime by each deployment of the
application.
Change-Id: If5fadb92b6f3a6b06e44729c967289c5917f9a25
Bug-Url: https://bugzilla.redhat.com/1102772
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
3 files changed, 66 insertions(+), 43 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5fadb92b6f3a6b06e44729c967289c5917f9a25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: fix cluster's schedulingpolicy back-compat
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: fix cluster's schedulingpolicy back-compat
......................................................................
restapi: fix cluster's schedulingpolicy back-compat
Ignores old (still supported) behavior (thresholds).
Change-Id: I4a5fa4d95bc55bed36d800532b81eb4340e4083d
Bug-Url: https://bugzilla.redhat.com/1118384
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
(cherry picked from commit fb8cef7c16f47efca18da76297a80234042f220d)
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/30085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a5fa4d95bc55bed36d800532b81eb4340e4083d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: restapi: fix cluster's schedulingpolicy back-compat
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: restapi: fix cluster's schedulingpolicy back-compat
......................................................................
restapi: fix cluster's schedulingpolicy back-compat
Ignores old (still supported) behavior (thresholds).
Change-Id: I4a5fa4d95bc55bed36d800532b81eb4340e4083d
Bug-Url: https://bugzilla.redhat.com/1118384
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/30042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a5fa4d95bc55bed36d800532b81eb4340e4083d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Add space validation when creating snapshot
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add space validation when creating snapshot
......................................................................
core: Add space validation when creating snapshot
In CreateAllSnapshotsFromVmCommand, added to CDA missing storage space validations.
For that, added allDomainsHaveSpaceForNewDisks to
MultipleStorageDomainsValidator .
Added relevant tests.
Change-Id: I0a5b5df695d30a34fbdef31da2320b322e27466b
Bug-Url: https://bugzilla.redhat.com/1053752
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java
4 files changed, 118 insertions(+), 8 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/30056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5b5df695d30a34fbdef31da2320b322e27466b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: aligned sos2 plugins to sos 3.1
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sos: aligned sos2 plugins to sos 3.1
......................................................................
sos: aligned sos2 plugins to sos 3.1
Aligned sos 2 plugins shipped within log-collector with
the plugins included in sos 3.1 released in Fedora.
The new ovirt plugin also include support for ovirt-scheduler-proxy.
Aligned log-collector for using ovirt plugin.
Require newest sos ovirt rpm in order to update sos
previously shipped within ovirt repo.
Bug-Url: https://bugzilla.redhat.com/1073944
Bug-Url: https://bugzilla.redhat.com/1037663
Change-Id: I74b1d24cff897d6cc393ee68edfe0d78030877c5
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-log-collector.spec.in
M po/POTFILES.in
M src/__main__.py
M src/sos/plugins/Makefile.am
D src/sos/plugins/engine.py
A src/sos/plugins/ovirt.py
D src/sos/plugins/ovirt_engine_dwh.py
D src/sos/plugins/ovirt_engine_reports.py
M src/sos/plugins/postgresql.py
9 files changed, 258 insertions(+), 346 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/30055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74b1d24cff897d6cc393ee68edfe0d78030877c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.4
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: try harder when connecting the storage
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: try harder when connecting the storage
......................................................................
try harder when connecting the storage
the agent has to wait between attempts to connect the storage
to give vdsm some time to initialize
Change-Id: I4c512aad490366b0fbd890d156b37243993dc498
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093621
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c512aad490366b0fbd890d156b37243993dc498
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: use max not min when computing the best score
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: use max not min when computing the best score
......................................................................
use max not min when computing the best score
The best score is the highest score, so this was
a 'thinko'. However this bug manifests itself only
if there is more than 2 hosts in the setup.
Change-Id: I0c265aa60611793b1cd4738ec057e9e7d02747a1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093366
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/state_machine.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/29920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c265aa60611793b1cd4738ec057e9e7d02747a1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months