Change in ovirt-engine[master]: utils: tar: use entry to access directory
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: utils: tar: use entry to access directory
......................................................................
utils: tar: use entry to access directory
hopefully it will make coverity happier.
Change-Id: I9290b08763ea4772ec395deb4297f96a119fd5bf
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9290b08763ea4772ec395deb4297f96a119fd5bf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Show warning when kdump integration required but not c...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Show warning when kdump integration required but not configured
......................................................................
core: Show warning when kdump integration required but not configured
Show warning when updating host configuration if PM and kdump
integration are enabled, but VDSM doesn't report kdump status as
enabled.
Change-Id: I1c9a89daa1a106206bf581bb0f996bb84c203cfa
Bug-Url: https://bugzilla.redhat.com/1126854
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java
1 file changed, 17 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c9a89daa1a106206bf581bb0f996bb84c203cfa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Don't configure kdump when PM is disabled
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Don't configure kdump when PM is disabled
......................................................................
core: Don't configure kdump when PM is disabled
Kudmp integration is enabled by default for new host. But there's no
sense to configure kdump integration without PM enabled. So this patch
disable kdump integration during host deploy if PM is disabled.
Change-Id: Ib05b2ce0ae512787f7b5d113f3a4ee1a1f05544b
Bug-Url: https://bugzilla.redhat.com/1126854
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib05b2ce0ae512787f7b5d113f3a4ee1a1f05544b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: aaa: more coverity fixes
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: more coverity fixes
......................................................................
aaa: more coverity fixes
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: Ie25bc66509d1e0986e7b92edc07537c869bd490c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java
3 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Juan Hernandez: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/31877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie25bc66509d1e0986e7b92edc07537c869bd490c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: userportal: Adjust protocol message
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: Adjust protocol message
......................................................................
userportal: Adjust protocol message
This patch corrects protocol message in Basic User Portal. Previously
the message contained confusing information.
Fixed by displaying protocol name for selected VM/Pool.
Also removed some duplicate code.
Change-Id: I12a3746c70ce9fdb84e8807fc469f8f0cdb3c812
Bug-Url: https://bugzilla.redhat.com/1078138
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
2 files changed, 17 insertions(+), 21 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Frank Kobzik: Verified
--
To view, visit http://gerrit.ovirt.org/30537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12a3746c70ce9fdb84e8807fc469f8f0cdb3c812
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Reduce number of tasks in queue log messages
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Reduce number of tasks in queue log messages
......................................................................
core: Reduce number of tasks in queue log messages
When the engine server is loaded, there is a message printed to the log.
This patch increases the threshold of the number of waiting tasks from 0
to 5.
Change-Id: Ieb061ed29750184bcdd39af7d8c3fc7d0dcacabd
Bug-Url: https://bugzilla.redhat.com/1130076
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
(cherry picked from commit 0c9c012b8704794e27d5a44842fd447cc7a2aa24)
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb061ed29750184bcdd39af7d8c3fc7d0dcacabd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: restapi: add QoS RESTful interface for storage QoS
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: add QoS RESTful interface for storage QoS
......................................................................
restapi: add QoS RESTful interface for storage QoS
- POST: /ovirt-engine/api/datacenters/{datacenter:id}/qoss; body: qos; response: qos
<qos type="storage">
<name>test_qos</name>
<description>aaaaa</description>
<max_throughput>1</max_throughput>
<max_read_throughput>1</max_read_throughput>
<max_write_throughput>1</max_write_throughput>
<max_iops>1</max_iops>
<max_read_iops>1</max_read_iops>
<max_write_iops>1</max_write_iops>
</qos>
- GET: /ovirt-engine/api/datacenters/{datacenter:id}/qoss; response: qoss
- DELETE: /ovirt-engine/api/datacenters/{datacenter:id}/qoss/{qos:id};
- GET: /ovirt-engine/api/datacenters/{datacenter:id}/qoss/{qos:id}; response: qos
<qos type="storage" href="/ovirt-engine/api/datacenters/00000002-0002-0002-0002-000000000321/qoss/a66577ff-d5f1-40f7-aebb-0b350ad8bb8c" id="a66577ff-d5f1-40f7-aebb-0b350ad8bb8c">
<name>test_qos</name>
<description>aaaaa</description>
<data_center href="/ovirt-engine/api/datacenters/00000002-0002-0002-0002-000000000321" id="00000002-0002-0002-0002-000000000321"/>
<max_throughput>1</max_throughput>
<max_read_throughput>1</max_read_throughput>
<max_write_throughput>1</max_write_throughput>
<max_iops>1</max_iops>
<max_read_iops>1</max_read_iops>
<max_write_iops>1</max_write_iops>
</qos>
- PUT: /ovirt-engine/api/datacenters/{datacenter:id}/qoss/{qos:id}; body: qos; response: qos
For more information see: http://www.ovirt.org/Features/aggregate_QoS,
http://www.ovirt.org/Features/blkio-support#RESTful_API
Change-Id: I1a9af59277b50554531522802f19046c0051d82f
Bug-Url: https://bugzilla.redhat.com/1085049
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/QosType.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DataCenterResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QoSsResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QosResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/QosValidator.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/QosMapperTest.java
17 files changed, 581 insertions(+), 31 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/31806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a9af59277b50554531522802f19046c0051d82f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Allow selection of None for Cloud-Init network boo...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Allow selection of None for Cloud-Init network boot protocol
......................................................................
webadmin: Allow selection of None for Cloud-Init network boot protocol
The REST API supported DHCP, Static IP, and None as NIC address types
for cloud-init VM startup. Make the same available in the UI as well.
Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083
Bug-Url: https://bugzilla.redhat.com/1120092
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
(cherry picked from commit d5dafab5c906c65a2878dbefd0a4b2cb8f3a1534)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java
4 files changed, 43 insertions(+), 27 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: 'Start-on-boot' of a nic should be respected
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: 'Start-on-boot' of a nic should be respected
......................................................................
core: 'Start-on-boot' of a nic should be respected
The user should be able to instruct which network interface
will be booted on startup when the interface is configured
by cloud-init.
Change-Id: I325c5edaa27be322bd5488d4397f696338e434fe
Bug-Url: https://bugzilla.redhat.com/1132439
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
(cherry picked from commit cf8f8106ca83c33721a6c61ec2ce297bd828d0b6)
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java
1 file changed, 4 insertions(+), 6 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit http://gerrit.ovirt.org/31772
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I325c5edaa27be322bd5488d4397f696338e434fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[ovirt-engine-3.5]: core: fix application messages
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix application messages
......................................................................
core: fix application messages
Some error messages are enclosed in double quotation marks that are
redundant and one message contains a typo
Change-Id: I898c232be9ad082ec262f44e2a958763e405bac0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131484
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
3 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I898c232be9ad082ec262f44e2a958763e405bac0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 4 months