Change in ovirt-engine[master]: webadmin: Make all disk size setting in DiskModel type safe
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Make all disk size setting in DiskModel type safe
......................................................................
webadmin: Make all disk size setting in DiskModel type safe
Since the size entity in DiskModel is defined as an Integer entity model,
all the places that set the new entity should be in Integer type to ensure
type safety
Change-Id: I2f22ca6865fc7927eb9777986b1844e3b8639141
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32195
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f22ca6865fc7927eb9777986b1844e3b8639141
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: webadmin: New disk dialog does not validate the size value
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: New disk dialog does not validate the size value
......................................................................
webadmin: New disk dialog does not validate the size value
The size field is defined as as an entity model of type long and so the
integer validator does not validate it at all making it possible for numbers
less than the minimum (including negative number and zero) as well as
numbers higher than the maximum to appear as validated, this was fixed
by replacing the entity model for size from type long to integer
Change-Id: Ie8f6e52bc11b248fd7829261df7ec3626603e363
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1115471
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
9 files changed, 14 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8f6e52bc11b248fd7829261df7ec3626603e363
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: SpmStopOnIrs - set result
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: SpmStopOnIrs - set result
......................................................................
core: SpmStopOnIrs - set result
When executing SpmStopOnIrs we should set the return value to be
as the return value of the command that's being executed, otherwise the
caller can't tell what actually happend.
Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a
Bug-Url: https://bugzilla.redhat.com/1119852
Bug-Url: https://bugzilla.redhat.com/1130222
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SpmStopOnIrsVDSCommand.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/32193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb2a4c788ef5cf571a8de150355c85e3a9ae77a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: add logging to SpmStopVDSCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: add logging to SpmStopVDSCommand
......................................................................
core: add logging to SpmStopVDSCommand
currently SpmStopVdsCommand performs nothing in case of tasks return by
the current spm, this patch just adds logging to that case.
Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130766
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/32189
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I271b7503270e57f9b08a3272f14905fd38b8d481
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: disable 'Remove' for OVF store not in ILLEGAL status
......................................................................
webadmin: disable 'Remove' for OVF store not in ILLEGAL status
Currently when OVF store isn't in ILLEGAL status it can't be removed,
this patch greys out the remove button in the webadmin in that case.
Change-Id: Ie2defe1bc6dfb1a770546bc664bb141d0923a1fa
Bug-Url: https://bugzilla.redhat.com/1131845
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/32188
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2defe1bc6dfb1a770546bc664bb141d0923a1fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: webadmin: isRemoveCommandAvailable() - removal of unneeded b...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded booleans
......................................................................
webadmin: isRemoveCommandAvailable() - removal of unneeded booleans
isRemoveCommandAvailable() is storing the checks results into booleans
and checks them all at each iteration.
The booleans can be replaced with comments and we can return immediately
when the result is known.
Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131845
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/32187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: tools: StorageDomainOvfStoreCount config value
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: tools: StorageDomainOvfStoreCount config value
......................................................................
tools: StorageDomainOvfStoreCount config value
adding StorageDomainOvfStoreCount to engine-config.
Change-Id: If35b26983a2d42d1b950572bdad4e0fbf657c7cd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1134242
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M packaging/etc/engine-config/engine-config.properties
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32186
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If35b26983a2d42d1b950572bdad4e0fbf657c7cd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: create OVF store as non shareable on gluster domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: create OVF store as non shareable on gluster domain
......................................................................
core: create OVF store as non shareable on gluster domain
oVirt doesn't support the creation of shareable disks on gluster
storage domains. Therefore the OVF store disks on gluster domains should
be created as non shareable.
Change-Id: I8e5d05a80061b963d61e09919824830b3624d3e6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1134366
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfVolumeForStorageDomainCommand.java
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/32185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e5d05a80061b963d61e09919824830b3624d3e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core:typo in power management health check warning
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core:typo in power management health check warning
......................................................................
core:typo in power management health check warning
Change-Id: I4f8fc5e2d0ab850208cf50cf411ed7a898ee3887
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129621
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f8fc5e2d0ab850208cf50cf411ed7a898ee3887
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Use correct validation for SD selection
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use correct validation for SD selection
......................................................................
core: Use correct validation for SD selection
When creating a snapshot, use new storage allocation validations for
the vm volumes when selecting a domain. Some code has been removed as a
result from this change.
Change-Id: Iac901a638358b9b08bcc6992d783a42cbfcd9bfa
Bug-Url: https://bugzilla.redhat.com/1119022
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/NullableMemoryImageBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/StatelessSnapshotMemoryImageBuilder.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java
7 files changed, 23 insertions(+), 72 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/32171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac901a638358b9b08bcc6992d783a42cbfcd9bfa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months