September 2014 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: bookmarks first try

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: bookmarks first try ...................................................................... webadmin: bookmarks first try - Bookmarks are not working the very first time you try, if you hadn't selected anything in the system tree yet. This was due to a system tree reset in bookmarkListModel_Navigated. This patch removes the reset and moves it into event handler that shows the system tree when moving from bookmarks or tags. Change-Id: I323869918c0affe15281526983e936db18ad6506 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1110444 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java 2 files changed, 3 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I323869918c0affe15281526983e936db18ad6506 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: build: maven: move all repos to top level pom, remove unused

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: build: maven: move all repos to top level pom, remove unused ...................................................................... build: maven: move all repos to top level pom, remove unused otherwise maven gets confused. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139016 Change-Id: I0599fc0293ab3e3f11b5fb7adb22c76b58d590bf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/restapi/pom.xml M pom.xml 2 files changed, 4 insertions(+), 30 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0599fc0293ab3e3f11b5fb7adb22c76b58d590bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.4]: notifier: send sysUpTime in snmp notifications.

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: send sysUpTime in snmp notifications. ...................................................................... notifier: send sysUpTime in snmp notifications. Sysuptime is measured since the notification service was started. Time ticks represent a100th of a second. Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142418 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f908ec8d7b9ce27bd845a568cc4ed195aafc9ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Verify that date is initialized in OVF_STORE disk

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Verify that date is initialized in OVF_STORE disk ...................................................................... core: Verify that date is initialized in OVF_STORE disk Verify that the last_update date is initizlied in the OVF_STORE disk to prevent NPE. If the last_update date is not initialized in the disk we don't count this disk to be retrieved, unregistered entities, from, since it is not initilized with entities. Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c Bug-Url: https://bugzilla.redhat.com/1130976 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e59086ce7242d7aaec10b57b6775ab968c9fe1c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Get all unregisterd entities for Storage Domain

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Get all unregisterd entities for Storage Domain ...................................................................... core: Get all unregisterd entities for Storage Domain When entity type is NULL, fetch all the unregistered entities Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990 Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java M packaging/dbscripts/unregistered_OVF_data_sp.sql 3 files changed, 19 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/32744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Register all the OVF disks to Storage

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Register all the OVF disks to Storage ...................................................................... core: Register all the OVF disks to Storage Manage all the OVF_STORE disks with one list, so all those disks will be registered as floating shareable disks in the Storage and will also be used for getting the most updateable OVF_STORE disk to be retrieved entities from. Change-Id: I9fc6666a64efa16968935cfceb10e19b8a4e2eef Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java 2 files changed, 89 insertions(+), 42 deletions(-) Approvals: Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fc6666a64efa16968935cfceb10e19b8a4e2eef Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: dal: Unregistered entities fixups in DAO and fixtures

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: dal: Unregistered entities fixups in DAO and fixtures ...................................................................... dal: Unregistered entities fixups in DAO and fixtures 1. Add unregistered Template entity to fixtures file 2. Use FixturesTool with the new entities 3. Fix UnregisteredOVFDataDAOTest accordingly 4. Fix typos found in the UnregisteredOVFDataDAOTest Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 31 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8663eec50968c0553c8fc6e841b3244ffd418b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Adding command context support for Register Disk

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding command context support for Register Disk ...................................................................... core: Adding command context support for Register Disk Adding command context constructor for Register Disk. Change-Id: Ic3303599c7e0b8d27bef6e63ca5c5615a292131f Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3303599c7e0b8d27bef6e63ca5c5615a292131f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Use the latest OVF_STORE files

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use the latest OVF_STORE files ...................................................................... core: Use the latest OVF_STORE files Rotate over the OVF_STORE disks and retrieve the entities from the best match of the OVF_STORE disk until succeeded. Also register those disks as OVF_STORE disks, so it will be updated every time there will be any change in the entities' OVF. Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 47 insertions(+), 32 deletions(-) Approvals: Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8252281f295df49a28c3c131d9a98fef9af8f35e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Validate disk registration only if a domain exists.

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate disk registration only if a domain exists. ...................................................................... core: Validate disk registration only if a domain exists. Registeration of a disk is only a DB operation and does not encounter any VDS commands, therefore there should not be any validation for Storage Domain activation. Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2014