Change in ovirt-engine[ovirt-engine-3.5]: core: ExportVmTemplateCommand storage allocations
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ExportVmTemplateCommand storage allocations
......................................................................
core: ExportVmTemplateCommand storage allocations
MoveOrCopyTemplateCommand.canDoAction() small fix:
Fixed storage domain space verification. Using StorageDomainValidator
for some other storage verification, instead of (p)re-inventing the
wheel.
ExportVmTemplate inherits and therefore is affected by this.
Change-Id: Ic5de81b318d5b8a2e0da918b4a44ae2003ca4b06
Bug-Url: https://bugzilla.redhat.com/1136717
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
1 file changed, 11 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5de81b318d5b8a2e0da918b4a44ae2003ca4b06
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: core: osinfo - redundant line for win2k2012
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: osinfo - redundant line for win2k2012
......................................................................
core: osinfo - redundant line for win2k2012
Change-Id: I0499dac2e9714cca12122396eaee0650c4524df7
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0499dac2e9714cca12122396eaee0650c4524df7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: build: maven: move all repos to top level pom, remove unused
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: build: maven: move all repos to top level pom, remove unused
......................................................................
build: maven: move all repos to top level pom, remove unused
otherwise maven gets confused.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1139016
Change-Id: I0599fc0293ab3e3f11b5fb7adb22c76b58d590bf
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/restapi/pom.xml
M pom.xml
2 files changed, 4 insertions(+), 30 deletions(-)
Approvals:
Yaniv Dary: Verified
Yair Zaslavsky: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0599fc0293ab3e3f11b5fb7adb22c76b58d590bf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: Added tables for geo replication entities
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Added tables for geo replication entities
......................................................................
engine: Added tables for geo replication entities
Added sql script to create tables for geo-rep
related entities
Adding stored procs and database methods to
access and update georeplication entities
Change-Id: I231092cfc969030e144a7ddd08187ce1c47a29db
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1125845
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/gluster_georep_sp.sql
A packaging/dbscripts/upgrade/03_06_0370_gluster_georep_tables.sql
9 files changed, 653 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Sahina Bose: Verified
Yair Zaslavsky: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/29947
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I231092cfc969030e144a7ddd08187ce1c47a29db
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Marshalling regression on fenceNode
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Marshalling regression on fenceNode
......................................................................
core: Marshalling regression on fenceNode
Change-Id: If9a1bc5a818a122a75f8f02385cfcfc26b003400
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1143854
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
(cherry picked from commit 2cdcdbc25aa75809f13ae5d1f840d8227ed4d646)
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9a1bc5a818a122a75f8f02385cfcfc26b003400
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: ui: Adding fields validation in addHost form
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: ui: Adding fields validation in addHost form
......................................................................
ui: Adding fields validation in addHost form
1. For root password during provisioning host
2. For empty compute resources and host group lists, when discovered host is
added.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1127606
Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31178
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: webadmin: NPE in Picking first provider
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: NPE in Picking first provider
......................................................................
webadmin: NPE in Picking first provider
Fix assumption that first provider exists
Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Daniel Erez: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32946
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71d1249d86a6b700708391eb19ba98302dd0be4a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: packaging: setup: keeping PostgreSQL port open if the DBMS i...
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: keeping PostgreSQL port open if the DBMS is local
......................................................................
packaging: setup: keeping PostgreSQL port open if the DBMS is local
on system with iptables engine-setup is going to completely
rewrite iptables rules. Kepping DB port open if the DBMS is local
also if we are not upgrading.
Change-Id: I92350ec322162e8c199174cf6fa7a1d517af8998
Bug-Url: https://bugzilla.redhat.com/1141286
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32871
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92350ec322162e8c199174cf6fa7a1d517af8998
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: packaging: setup: add getHostname
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: add getHostname
......................................................................
packaging: setup: add getHostname
Move the code asking for the FQDN to a common place, to allow asking for
other host names.
Copy the FQDN to ENGINE_FQDN to be used by other plugins needing the
engine fqdn.
Change-Id: I8747002a14de6d96d5a7e185258d8ee0955b8a24
Related-To: https://bugzilla.redhat.com/1118330
Related-To: https://bugzilla.redhat.com/1080992
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/ovirt_engine_setup/engine_common/constants.py
A packaging/setup/ovirt_engine_setup/hostname.py
M packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/protocols.py
6 files changed, 390 insertions(+), 281 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
oVirt Jenkins CI Server: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/32742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8747002a14de6d96d5a7e185258d8ee0955b8a24
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months
Change in ovirt-engine[master]: engine: Removed unwanted exception logging
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Removed unwanted exception logging
......................................................................
engine: Removed unwanted exception logging
Gluster task monitoring checks periodically for
gluster tasks list from the cluster, and if there
are no operational hosts in the cluster, an
exception is logged.
Removing the noise from this logging as it
confuses the user.
Change-Id: I9b24fe99a1cb66155a9ff24f149a20db32e76307
Bug-Url: https://bugzilla.redhat.com/1138128
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Shubhendu Tripathi: Looks good to me, but someone else must approve
Kanagaraj M: Looks good to me, but someone else must approve
Sahina Bose: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b24fe99a1cb66155a9ff24f149a20db32e76307
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 8 months