January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Allow import of Posix/Gluster export storage domains
by juan.hernandez＠redhat.com 28 Jan '15

28 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Allow import of Posix/Gluster export storage domains ...................................................................... restapi: Allow import of Posix/Gluster export storage domains Change-Id: I70b2d4856714b8c95157dd885e91f354071d8c4b Bug-Url: https://bugzilla.redhat.com/1160731 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70b2d4856714b8c95157dd885e91f354071d8c4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: update changelog
by dougsland＠redhat.com 28 Jan '15

28 Jan '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: update changelog ...................................................................... spec: update changelog Change-Id: Icad033661d49b213a0e466a243c31e9eb5875a0e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icad033661d49b213a0e466a243c31e9eb5875a0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: configure: increase release
by dougsland＠redhat.com 28 Jan '15

28 Jan '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: configure: increase release ...................................................................... configure: increase release Added engine_page: Add validation for engine_data Change-Id: I7ab91bc46e4eef771f712736fe14c90a448ab23e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ab91bc46e4eef771f712736fe14c90a448ab23e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: engine_page: Add validation for engine_data
by dougsland＠redhat.com 28 Jan '15

28 Jan '15

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: Add validation for engine_data ...................................................................... engine_page: Add validation for engine_data Avoid engine_data getting non valid data. Change-Id: I75b9c20ab4bed89509da569ee6e3de0bf4c8779f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75b9c20ab4bed89509da569ee6e3de0bf4c8779f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Enable running canDoAction in the same trx with execute
by masayag＠redhat.com 27 Jan '15

27 Jan '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Enable running canDoAction in the same trx with execute ...................................................................... core: Enable running canDoAction in the same trx with execute @CanDoActionSupportsTransaction annotation added in order to avoid suspending current transaction for executing canDoAction. That allows sharing a single transaction between multiple commands executions. Change-Id: I41034c27b993ee0cc179f500ed8cf32552f23c81 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanDoActionSupportsTransaction.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/37227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41034c27b993ee0cc179f500ed8cf32552f23c81 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: JSON-RPC extend storage domain failure
by tnisan＠redhat.com 27 Jan '15

27 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: JSON-RPC extend storage domain failure ...................................................................... core: JSON-RPC extend storage domain failure The method extendStorageDomain used to build a RequestBuilder for the "force" parameter using Boolean.toString instead of sending the force parameter itself. Change-Id: I25ceed4d093432af70b2f01157228c1773db561d Bug-Url: https://bugzilla.redhat.com/1186410 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> Signed-off-by: Fred Rolland <frolland(a)redhat.com> Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25ceed4d093432af70b2f01157228c1773db561d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Check attached DC only for data Storage.
by tnisan＠redhat.com 27 Jan '15

27 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Check attached DC only for data Storage. ...................................................................... webadmin: Check attached DC only for data Storage. Filter only data storage domains when executing the validation for attached Data Center when importing a file Storage Domain to prevent checking it for ISO and Export Storage Domains. Change-Id: I8fc9f48a3849f70306cc2748d1a716924a0a4f76 Bug-Url: https://bugzilla.redhat.com/1186371 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/37322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc9f48a3849f70306cc2748d1a716924a0a4f76 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Validate the return value of an internal query.
by tnisan＠redhat.com 27 Jan '15

27 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Validate the return value of an internal query. ...................................................................... core: Validate the return value of an internal query. Use the internal query return value to check if it has been succeeded or failed when calling getExistingStorageDomainList, so we can be sure that the return object value is a list and not null in case of a failure. Change-Id: I7a4ddd8f0e290981f1d583dfdb1722f7864b1f6d Bug-Url: https://bugzilla.redhat.com/1186372 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest.java 2 files changed, 49 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/37321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4ddd8f0e290981f1d583dfdb1722f7864b1f6d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: JSON-RPC extend storage domain failure
by tnisan＠redhat.com 27 Jan '15

27 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: JSON-RPC extend storage domain failure ...................................................................... core: JSON-RPC extend storage domain failure The method extendStorageDomain used to build a RequestBuilder for the "force" parameter using Boolean.toString instead of sending the force parameter itself. Change-Id: I25ceed4d093432af70b2f01157228c1773db561d Bug-Url: https://bugzilla.redhat.com/1185865 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> Signed-off-by: Fred Rolland <frolland(a)redhat.com> Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/37320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25ceed4d093432af70b2f01157228c1773db561d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Allow import of Posix/Gluster export storage domains
by tnisan＠redhat.com 27 Jan '15

27 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow import of Posix/Gluster export storage domains ...................................................................... webadmin: Allow import of Posix/Gluster export storage domains Change-Id: If81f45ba1956e838ca1fa7e89759bee3e55f3fe4 Bug-Url: https://bugzilla.redhat.com/1160731 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve Vered Volansky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If81f45ba1956e838ca1fa7e89759bee3e55f3fe4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0