January 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Allow import of Posix/Gluster export storage domains
by tnisan＠redhat.com 29 Jan '15

29 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow import of Posix/Gluster export storage domains ...................................................................... webadmin: Allow import of Posix/Gluster export storage domains Change-Id: If81f45ba1956e838ca1fa7e89759bee3e55f3fe4 Bug-Url: https://bugzilla.redhat.com/1186375 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If81f45ba1956e838ca1fa7e89759bee3e55f3fe4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: refactoring upgrade process
by emesika＠redhat.com 29 Jan '15

29 Jan '15

Eli Mesika has submitted this change and it was merged. Change subject: db: refactoring upgrade process ...................................................................... db: refactoring upgrade process Up to now, each version, I had squashed (version - 3) upgrade scripts into the base database manually. For example in 3.4 , I had squashed 3.1 upgrade scripts and in 3.5 I had squashed 3.2 upgrade scripts. The squashing was done by creating a new schema including all the squashed version changes and applying all inserts into the insert_data.sql and insert_pre_defined_roles.sql manually This was a time consuming and error-prone process that sometimes lead to regressions since it was not easy to compare databases data using pg_dump because PG does not guarantee the order in which data is dumped even if the databases compared are identical. This patch introduces a new approach when all data up to the squashed version, is auto generated per table by using pg_dump under the data directory Another complementary tool (not part of this patch) enables to dump PG databases and forcing the data being ordered by table PK, the tool also compares databases schema and data and make it very easy to check if databases are identical. Since some entities like DC & Cluster need a new generated UUID per installation, I wrote a uuidgen.sh script that does exactly that and generates new UUIDs for each installation for those entities on the data before it is inserted to the database. The process of squashing, from now on, will be : 1) creating a git branch with only the squashed version upgrade scripts 2) generating schema and insert files (automatically by pg_dump) 3) restoring all deleted upgrade files with version > squashed version that were deleted in 1) 4) creating a database based on 1) to 3) 5) creating a database on master 6) using the database comparison tool to verify both databases are identical (except some generated UUIDs) Change-Id: I89b8ecc31ca3a179886d84ae7f725282c5571c37 Signed-off-by: emesika <emesika(a)redhat.com> --- A packaging/dbscripts/data/0000_insert_schema_version.sql A packaging/dbscripts/data/0010_insert_users.sql A packaging/dbscripts/data/0020_insert_ad_groups.sql A packaging/dbscripts/data/0030_insert_storage_pool.sql A packaging/dbscripts/data/0040_insert_vds_groups.sql A packaging/dbscripts/data/0050_insert_roles.sql A packaging/dbscripts/data/0060_insert_permissions.sql A packaging/dbscripts/data/0070_insert_roles_groups.sql A packaging/dbscripts/data/0080_insert_images.sql A packaging/dbscripts/data/0090_insert_network.sql A packaging/dbscripts/data/0100_insert_network_cluster.sql A packaging/dbscripts/data/0110_insert_vm_static.sql A packaging/dbscripts/data/0120_insert_vm_device.sql A packaging/dbscripts/data/0130_insert_vm_ovf_generations.sql A packaging/dbscripts/data/0140_insert_action_version_map.sql A packaging/dbscripts/data/0150_insert_event_map.sql A packaging/dbscripts/data/0160_insert_dwh_history_timekeeping.sql M packaging/dbscripts/dbfunc-custom.sh D packaging/dbscripts/insert_data.sql D packaging/dbscripts/insert_predefined_roles.sql A packaging/dbscripts/uuidgen.sh 21 files changed, 783 insertions(+), 913 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Lior Vernia: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b8ecc31ca3a179886d84ae7f725282c5571c37 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Add CORS filter
by juan.hernandez＠redhat.com 29 Jan '15

29 Jan '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add CORS filter ...................................................................... restapi: Add CORS filter This patch adds CORS (Cross Origin Resource Sharing) support to the RESTAPI. This is based on the existing CORS filter developed by eBay and available here: https://github.com/ebay/cors-filter On top of that filter this patch adds the possibility to configure it with two configuration parameters stored in the engine database and supported by the "engine-config" tool: CORSSupport: This is a boolean parameter that indicates if the CORS support should be enabled. If its value is "false" then the support will be disabled and the RESTAPI will behave exactly as before intoducing this patch. If the value is "true" then the CORS support will be enabled, but by default no origin will be allowed, so the second parameter has also to be configured correctly. The default value is "false". CORSAllowedOrigin: This is a comma separated list of the allowed origins. If it is empty CORS support will be effectively disabled, even if the value of the "CORSSupport" parameter is "true". It can also have the special value "*", and in that case all origins will be allowed. In practice, to use the filter, both parameters need to be set. For example, in order to allow requests from scripts downloaded from the "my.app" the following configuration changes are required: # engine-config -s CORSSupport=true # engine-config -s CORSAllowedOrigins=http://my.app # systemctl ovirt-engine restart To test the filter you can use a simple JavaScript application like the following deployed in the root of the web server of "my.app": <html> <head> <script> function onGet() { var xhr = prepareRequest("GET"); xhr.send(); } function prepareRequest(method) { var url = document.getElementById("url"); var user = document.getElementById("user"); var password = document.getElementById("password"); var body = document.getElementById("body"); var xhr = new XMLHttpRequest(); xhr.open(method, url.value); xhr.setRequestHeader("Authorization", "Basic " + window.btoa(user.value + ":" + password.value)); xhr.setRequestHeader("Accept", "application/xml"); xhr.setRequestHeader("Content-Type", "application/xml"); xhr.onload = function (e) { var text = xhr.responseText; body.value = text; }; return xhr; } </script> </head> <body> <form action=""> <table> <tr> <td>URL</td> <td><input id="url" type="text" value="https://my.engine/ovirt-engine/api"/></td> </tr> <tr> <td>User</td> <td><input id="user" type="text" value="admin@internal"/></td> </tr> <tr> <td>Password</td> <td><input id="password" type="password" value=""/></td> </tr> <tr> <td colspan="2"> <div> Body </div> <div> <textarea id="body" rows="10" cols="80"> </textarea> </div> </td> </tr> <tr> <td colspan="2"> <input type="button" value="GET" onclick="onGet()"/> </tr> </table> </form> </body> </html> When running this application the browser should send an initial OPTIONS request to the server, asking for permission to send the actual request: OPTIONS /ovirt-engine/api HTTP/1.1 Host: my.engine Origin: http://my.app Access-Control-Request-Method: GET Access-Control-Request-Headers: accept,authorization,content-type ... The server should then respond with something like this: HTTP/1.1 200 OK Access-Control-Allow-Headers: accept,content-type,authorization Access-Control-Allow-Methods: GET Access-Control-Allow-Origin: http://my.app Access-Control-Max-Age: 1800 Access-Control-Allow-Credentials: true ... Then the browser will send the actual GET request, as the server approved it. For more details about the CORS protocol see here: W3C: http://www.w3.org/TR/cors Mozilla: https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS Change-Id: I40f9a13105fe99bb6b4035e61b8945efd8315f57 Bug-Url: https://bugzilla.redhat.com/1181530 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml A backend/manager/dependencies/common/src/main/modules/org/ebaysf/web/cors-filter/main/module.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml A backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/CORSSupportFilter.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/modules/org/ovirt/engine/api/interface-common-jaxrs/main/module.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 12 files changed, 289 insertions(+), 20 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Greg Sheremeta: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40f9a13105fe99bb6b4035e61b8945efd8315f57 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenny Kang <jennykang95(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5.1]: core: ovf_store isn't added
by tnisan＠redhat.com 29 Jan '15

29 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: ovf_store isn't added ...................................................................... core: ovf_store isn't added When disk is added and there is no active user- currently only for ovf_store disk, disk profile permission check causes NPE. Since user is null when command is invoked by the internally, we can skip the permission check. Bug-Url: https://bugzilla.redhat.com/1185615 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: I0ab3247d0f80e2f5123aace3fac58bee2a8a7b8d (cherry picked from commit 6015932ec838f79a2229dcf4ff4dfd5d57a1d7e3) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Gilad Chaplik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ab3247d0f80e2f5123aace3fac58bee2a8a7b8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5.1 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: Fix PEP8 violation in packages.py (line too long)
by sbonazzo＠redhat.com 29 Jan '15

29 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Fix PEP8 violation in packages.py (line too long) ...................................................................... packaging: Fix PEP8 violation in packages.py (line too long) Change-Id: I710f7a84aa459e600e37fbbff042b32470dc584c Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/37394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I710f7a84aa459e600e37fbbff042b32470dc584c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix host status changed to Connecting logging
by emesika＠redhat.com 29 Jan '15

29 Jan '15

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix host status changed to Connecting logging ...................................................................... core: Fix host status changed to Connecting logging Display log message that host has changed status Connecting only when status change really happened. Change-Id: I0dfe369ea8c0a6460db9cc548b3695614a90d1b9 Bug-Url: https://bugzilla.redhat.com/1182510 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dfe369ea8c0a6460db9cc548b3695614a90d1b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: hosts from gluster clusters shouldn't be considered
by tnisan＠redhat.com 29 Jan '15

29 Jan '15

Tal Nisan has submitted this change and it was merged. Change subject: core: hosts from gluster clusters shouldn't be considered ...................................................................... core: hosts from gluster clusters shouldn't be considered When moving a domain to maintenance or when handling problematic domain, hosts from gluster clusters were considered although we don't use any monitoring from those hosts which prevents hosts from moving to maintenance or from properly handle a problematic domain. This patch fixes it by loading only the hosts from virt service (which we collect domain monitoring information from) instead of loading all the hosts. Change-Id: I2b89785529ec00114065e350138e05d6c966df44 Bug-Url: https://bugzilla.redhat.com/1186687 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M packaging/dbscripts/vds_sp.sql 6 files changed, 30 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/37375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b89785529ec00114065e350138e05d6c966df44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: gluster: add gluster repo on Fedora
by dcaroest＠redhat.com 29 Jan '15

29 Jan '15

David Caro has submitted this change and it was merged. Change subject: gluster: add gluster repo on Fedora ...................................................................... gluster: add gluster repo on Fedora VDSM is now requiring latest Gluster also on Fedora. Adding Gluster upstream repositories to Fedora too. Change-Id: I45a8b46b62132dcc5ad302deb0d5ad27abca3518 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/vdsm/vdsm_create-rpms.yaml M jobs/confs/yaml/jobs/vdsm/vdsm_create_libgfapi-rpms.yaml M jobs/packaging/repo_closure_check.sh 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified David Caro: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45a8b46b62132dcc5ad302deb0d5ad27abca3518 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Packages management at customization
by sbonazzo＠redhat.com 29 Jan '15

29 Jan '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Packages management at customization ...................................................................... packaging: setup: Packages management at customization Move engine packages management to customization stage. Do most handling only if engine is enabled. Bug-Url: https://bugzilla.redhat.com/1150108 Change-Id: I9ea083958ca3212bc0e36c725dab5966c62e7df1 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py 1 file changed, 43 insertions(+), 35 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/37251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ea083958ca3212bc0e36c725dab5966c62e7df1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: BLL queries for volume snapshots list and count
by kmayilsa＠redhat.com 29 Jan '15

29 Jan '15

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: BLL queries for volume snapshots list and count ...................................................................... gluster: BLL queries for volume snapshots list and count Introduced BLL queries for volume snapshots list and its total count for a given volume. Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotsByVolumeIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/gluster_volume_snapshot_sp.sql A packaging/dbscripts/upgrade/03_06_0820_add_snapshot_count_to_gluster_volume.sql 12 files changed, 161 insertions(+), 8 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0