October 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: disks tab - fix quota visibility event handler
by derez＠redhat.com 13 Oct '15

13 Oct '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks tab - fix quota visibility event handler ...................................................................... webadmin: disks tab - fix quota visibility event handler The logic in 'MainTabDiskView -> handleQuotaColumnVisibility' is relevant only when Disks main-tab is selected. Currently, navigating the system-tree, while disks tab is selected, causes an erroneous search query (see BZ) since this logic is invoked. Hence, ensuring that Disks tab is selected beforehand. Change-Id: Ibb18b7655307939297d6d2201ef3a35af7ab7417 Bug-Url: https://bugzilla.redhat.com/1269531 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/47229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb18b7655307939297d6d2201ef3a35af7ab7417 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: Select the first CPU profile when multiple are available
by tnisan＠redhat.com 13 Oct '15

13 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: Select the first CPU profile when multiple are available ...................................................................... Select the first CPU profile when multiple are available This patch fixes a regression where a VM could not be added to a cluster where multiple CPU profiles were defined without having a specific CPU profile assigned by the REST call. The fix is not ideal as we should redo the whole mechanism to make sure all permissions and quotas are obeyed. Change like that would be too invasive at this stage of development and we will address it for the next version or update. Change-Id: I462579ff12c8c4f97c72c08e12637cfedd766f10 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1262293 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 86ad52390c7328edd643a1a71ce4b6e48a480e31) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I462579ff12c8c4f97c72c08e12637cfedd766f10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add EL 7.2 emulated machine level
by ofrenkel＠redhat.com 13 Oct '15

13 Oct '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Add EL 7.2 emulated machine level ...................................................................... core: Add EL 7.2 emulated machine level Changed the default config values and also added upgrade script to migrate all clusters with 7.1 machine type to 7.2 Change-Id: I02d5a50c7e3a393e8a3911b78180f7c0e8992b94 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251126 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1910_bump_cluster_machine_type_to_72.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d5a50c7e3a393e8a3911b78180f7c0e8992b94 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: [attach]Validate Cinder disks same as image disk.
by mlipchuk＠redhat.com 13 Oct '15

13 Oct '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: [attach]Validate Cinder disks same as image disk. ...................................................................... core: [attach]Validate Cinder disks same as image disk. Cinder disks should be validated with the same validations as image disks are validated when attaching a disk. Change-Id: Ic682668c5b9ab7bec1792313f4bf00eda166292d Bug-Url: https://bugzilla.redhat.com/1270777 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic682668c5b9ab7bec1792313f4bf00eda166292d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: db: add missing indexes:
by tnisan＠redhat.com 13 Oct '15

13 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: db: add missing indexes: ...................................................................... db: add missing indexes: This patch includes missing indexes suggested by pgcluu (http://pgcluu.darold.net/) PostgreSQL automatically creates indexes on primary keys and unique constraints, but not on the referencing side of foreign key relationships. Since a DELETE of a row from the referenced table or an UPDATE of a referenced column will require a scan of the referencing table for rows matching the old value, it is often a good idea to index the referencing columns. Change-Id: I09b43335e7cde29235839df00f590fef346d3547 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1270584 Signed-off-by: emesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1880_add_index_to_fk_columns.sql 1 file changed, 91 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Eli Mesika: Verified; Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/47214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09b43335e7cde29235839df00f590fef346d3547 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6.0]: packaging: setup: support dnf version locking
by tnisan＠redhat.com 13 Oct '15

13 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: support dnf version locking ...................................................................... packaging: setup: support dnf version locking OTOPI 1.4.0 support DNF package manager. Upgrade support with DNF package manager requires changes in versionlock plugin configuration since DNF and YUM are not sharing the same configuration. This patch add a new dependency on Fedora adding the DNF versionlock plugin and configure it as it does for YUM. Add also the versionlock plugin configuration to the backupped data. Change-Id: I16a53c0f39eb8e5a7698ac4fcbba971081da6d24 Bug-Url: https://bugzilla.redhat.com/1270139 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M packaging/bin/engine-backup.sh M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 4 files changed, 85 insertions(+), 60 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16a53c0f39eb8e5a7698ac4fcbba971081da6d24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: support dnf version locking
by tnisan＠redhat.com 13 Oct '15

13 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: support dnf version locking ...................................................................... packaging: setup: support dnf version locking OTOPI 1.4.0 support DNF package manager. Upgrade support with DNF package manager requires changes in versionlock plugin configuration since DNF and YUM are not sharing the same configuration. This patch add a new dependency on Fedora adding the DNF versionlock plugin and configure it as it does for YUM. Add also the versionlock plugin configuration to the backupped data. Change-Id: I16a53c0f39eb8e5a7698ac4fcbba971081da6d24 Bug-Url: https://bugzilla.redhat.com/1270139 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M packaging/bin/engine-backup.sh M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 4 files changed, 85 insertions(+), 60 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16a53c0f39eb8e5a7698ac4fcbba971081da6d24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add soundDeviceSupportMap to OsInfo
by ahadas＠redhat.com 13 Oct '15

13 Oct '15

Arik Hadas has submitted this change and it was merged. Change subject: core: Add soundDeviceSupportMap to OsInfo ...................................................................... core: Add soundDeviceSupportMap to OsInfo Change-Id: Iafc92e7eda805551646155ae77b838eb1b7e54ad Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1253261 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java 5 files changed, 35 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/47137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafc92e7eda805551646155ae77b838eb1b7e54ad Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: Restart hosted engine services after crash
by msivak＠redhat.com 12 Oct '15

12 Oct '15

Martin Sivák has submitted this change and it was merged. Change subject: Restart hosted engine services after crash ...................................................................... Restart hosted engine services after crash Change-Id: I174bd1ab900095185694bdd280991ff30354baca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1030441 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M initscripts/ovirt-ha-agent.service M initscripts/ovirt-ha-broker.service 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Artyom Lukianov: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I174bd1ab900095185694bdd280991ff30354baca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fixed Quota description size limits
by tnisan＠redhat.com 12 Oct '15

12 Oct '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fixed Quota description size limits ...................................................................... core: Fixed Quota description size limits When trying to copy a quota an error messsage was thrown saying that the size limit should be between 1 and 250. This error message was the result of not giving the right limits for the description of the quota. An empty description is 0 character long. Therefore, the limit was changed and now it is [0-250]. Change-Id: I6acad4fe290552dcdbd73bcd77e12c65f924d3c2 Bug-Url: https://bugzilla.redhat.com/1245664 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> (cherry picked from commit 1619a3525505e47c8f8ad46a8e1d0c9fc4d0be66) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/45240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6acad4fe290552dcdbd73bcd77e12c65f924d3c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0