October 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: StorageDomainToPoolRelationValidator lambda
by amureini＠redhat.com 31 Oct '15

31 Oct '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDomainToPoolRelationValidator lambda ...................................................................... core: StorageDomainToPoolRelationValidator lambda Use a lambda expression to filter the domains in StorageDomainToPoolRelationValidator instead of a cumbersome LinqUtils expression. Note that this patch also provides a slight performance improvement, as LinqUtils.filter would iterate over the entire list, while anyMatch stops as soon as it encounters such a match. Change-Id: If1305d000e2af4917f3e37b9ce404f5812c59d43 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidator.java 1 file changed, 6 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/47900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1305d000e2af4917f3e37b9ce404f5812c59d43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use matrix parameters for force remove storage domain
by juan.hernandez＠redhat.com 31 Oct '15

31 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use matrix parameters for force remove storage domain ...................................................................... restapi: Use matrix parameters for force remove storage domain The operation that removes a storage domain supports the "force", "destroy" and "host" parameters. These parameters were passed to the "DELETE" method using the representation of the storage domain as the body: DELETE /storagedomains/{storagedomain:id} <storage_domain> <force>...</force> <destroy>...</destroy> <host id="..."> <name>...</name> </host> </storage_domain> This is problematic, as the HTTP "DELETE" method shouldn't have a body, and the representation of the storage domain shouldn't include things that aren't attributes of the storage domain, rather parameters of the operation. This patch replaces the "force", "delete" and "host" attributes by equivalent matrix parameters, and the operation doesn't now accept a body. For example, after this patch, the way to delete a storage domain with the "force" parameter is the following: DELETE /storagedomain/{storagedomain:id};host=myhost;force=true To delete with the "destroy" parameter: DELETE /storagedomain/{storagedomain:id};host=myhost;destroy=true Change-Id: I87d4a9a29fcd9af794ecbedb1b255e676541ee13 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResourceTest.java M backend/manager/modules/restapi/model/src/main/java/types/StorageDomain.java 6 files changed, 171 insertions(+), 113 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87d4a9a29fcd9af794ecbedb1b255e676541ee13 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove "UpdatableRoleResource"
by juan.hernandez＠redhat.com 31 Oct '15

31 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove "UpdatableRoleResource" ...................................................................... restapi: Remove "UpdatableRoleResource" This patch merges the "UpdatableRoleResource" and "RoleResource" iterfaces, putting all the methods in "RoleResource" and removing "UpdatableRoleResource". Change-Id: I72507e4513361108547aa07ed0a94a8bde683412 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/RoleResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/RolesResource.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/UpdatableRoleResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRolesResource.java 6 files changed, 14 insertions(+), 39 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72507e4513361108547aa07ed0a94a8bde683412 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove generic quota limit interfaces
by juan.hernandez＠redhat.com 30 Oct '15

30 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove generic quota limit interfaces ...................................................................... restapi: Remove generic quota limit interfaces This kind of interfaces is an obstacle for the introduction of the new service model. Change-Id: Ie8f1cfe16033f71355ac767d103a4ee6b798d01e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaClusterLimitResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaClusterLimitsResource.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaLimitResource.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaLimitsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaStorageLimitResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QuotaStorageLimitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaClusterLimitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaLimitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQuotaStorageLimitsResource.java 10 files changed, 58 insertions(+), 54 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8f1cfe16033f71355ac767d103a4ee6b798d01e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename "QoSsResource" to "QossResource"
by juan.hernandez＠redhat.com 30 Oct '15

30 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename "QoSsResource" to "QossResource" ...................................................................... restapi: Rename "QoSsResource" to "QossResource" This is in order to stick to the capitalization rule used in the rest of the RESTAPI. Change-Id: I41c3ef58e6082c7ca5617cc2648fa07e8fbca853 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DataCenterResource.java R backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/QossResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java 5 files changed, 9 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41c3ef58e6082c7ca5617cc2648fa07e8fbca853 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use matrix parameter instead of action to force rem...
by juan.hernandez＠redhat.com 30 Oct '15

30 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use matrix parameter instead of action to force remove host ...................................................................... restapi: Use matrix parameter instead of action to force remove host The operation that removes a host supports a "force" parameter. In order to use it the "DELETE" operation used to support an optional action parameter: DELETE /hosts/{host:id} <action> <force>true</force> </action> This patch removes the optional action parameter and replaces it with an optional matrix parameter: DELETE /hosts/{host:id};force=true Change-Id: I758d7d9a45b8c3f8bfedb212da0bd90e6b1f01cf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 5 files changed, 51 insertions(+), 47 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I758d7d9a45b8c3f8bfedb212da0bd90e6b1f01cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add missing action sub-resource
by juan.hernandez＠redhat.com 30 Oct '15

30 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add missing action sub-resource ...................................................................... restapi: Add missing action sub-resource Some of the resources that have actions are missing the sub-resource that returns information about the asynchronous actions generated by the execution of the action. This patch adds those missing sub-resources. Change-Id: If598290a477a50c3e5b508549c6f5fc9daa406c6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/EventsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostNicsResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmGraphicsConsoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java 6 files changed, 20 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If598290a477a50c3e5b508549c6f5fc9daa406c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use "export" instead of "doExport"
by juan.hernandez＠redhat.com 30 Oct '15

30 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "export" instead of "doExport" ...................................................................... restapi: Use "export" instead of "doExport" The general rule for the names of the JAX-RS interface methods is that they are named like the action. For example, if the name of the action is "start" then the name of the method is also "start". The only exception is when the result is a Java reserved word, like "import", and in those cases the name is prefixed with "do", resulting in "doImport", for example. But "export" isn't a reserved word, so in order to improve consistency this patch renames the "doExport" method to just "export". Change-Id: I85ecb4c29ff373f9132ef70469170a54d0cadb5c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java 10 files changed, 18 insertions(+), 18 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/47874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ecb4c29ff373f9132ef70469170a54d0cadb5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use matrix parameter instead of action to force rem...
by juan.hernandez＠redhat.com 30 Oct '15

30 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use matrix parameter instead of action to force remove data center ...................................................................... restapi: Use matrix parameter instead of action to force remove data center The operation that removes a data center supports a "force" parameter. In order to use it the "DELETE" operation used to support an optional action parameter: DELETE /datacenters/{datacenter:id} <action> <force>true</force> </action> This patch removes the optional action parameter and replaces it with an optional matrix parameter: DELETE /datacenters/{datacenter:id};force=true Change-Id: I77873f2401f51f1c94b80ac6a05d8bb4c33e5d9e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DataCenterResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResourceTest.java 5 files changed, 60 insertions(+), 55 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/47873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77873f2401f51f1c94b80ac6a05d8bb4c33e5d9e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use JAX-RS Response instead of entity in policy units
by juan.hernandez＠redhat.com 30 Oct '15

30 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use JAX-RS Response instead of entity in policy units ...................................................................... restapi: Use JAX-RS Response instead of entity in policy units Currently the JAX-RS resource interfaces for policy units (filters, balances and weights) return the entity type as the result of the "add" methods. All the other resources of the RESTAPI return the JAX-RS "Reponse" type. This patch changes the policy units resources so that they return "Response", like the rest of the resources. Change-Id: I8048c47e75b45f0f5be9e542a4f38e19538772a0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/BalancesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/FiltersResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/WeightsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendBalancesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFiltersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendPolicyUnitsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWeightsResource.java 7 files changed, 20 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47869 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8048c47e75b45f0f5be9e542a4f38e19538772a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0