October 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Make sure VDSM had enough time to start before failing

by msivak＠redhat.com

Martin Sivák has submitted this change and it was merged. Change subject: Make sure VDSM had enough time to start before failing ...................................................................... Make sure VDSM had enough time to start before failing This improves things on two fronts: - Using After in the systemd unit instructs the init system to make sure the hosted engine service is started after the vdsm process, eliminating one race condition. - Moving the initial ServiceNotUp handling to the _run_agent method allows us to try multiple times before we fail. Change-Id: Ie23b110b3018c88656b2119dbeb24d431e922bdf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1267511 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 838fdde0a67ff88a53f12811eba3aaa52464ccc3) --- M initscripts/ovirt-ha-agent.service M ovirt_hosted_engine_ha/agent/agent.py M ovirt_hosted_engine_ha/agent/hosted_engine.py 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie23b110b3018c88656b2119dbeb24d431e922bdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: remove addVmTemplateCinderDisks from transaction

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: remove addVmTemplateCinderDisks from transaction ...................................................................... core: remove addVmTemplateCinderDisks from transaction AddVmTemplateCommand: Extracted 'addVmTemplateCinderDisks' invocation from within transaction. Change-Id: I847d80d4798aafd59b92e060039b25efd71840b9 Bug-Url: https://bugzilla.redhat.com/1264677 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 5 files changed, 17 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I847d80d4798aafd59b92e060039b25efd71840b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Indent disk notes upon disk removal

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Indent disk notes upon disk removal ...................................................................... webadmin: Indent disk notes upon disk removal Change-Id: I38f0758e313aaeb01a2381ee5a6daa1efe96103f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1139249 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractDiskRemoveConfirmationPopupView.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/46995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38f0758e313aaeb01a2381ee5a6daa1efe96103f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Allow edit of wipe after delete when the VM is not...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow edit of wipe after delete when the VM is not down ...................................................................... webadmin: Allow edit of wipe after delete when the VM is not down In fact, wipe after delete is possible in any case unless when the VM is a part of a pool Change-Id: Ic7030fd98045d624cba048ca6f0eeb1c85a58f62 Bug-Url: https://bugzilla.redhat.com/1258901 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46817 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7030fd98045d624cba048ca6f0eeb1c85a58f62 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Clarify host low free memory message

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Clarify host low free memory message ...................................................................... webadmin: Clarify host low free memory message Change-Id: Ia890a059116e9ebce6f33fe4e3ccda78211caea3 Bug-Url: https://bugzilla.redhat.com/1264109 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/47002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia890a059116e9ebce6f33fe4e3ccda78211caea3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Clarify host low free memory message

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Clarify host low free memory message ...................................................................... webadmin: Clarify host low free memory message Change-Id: Ia890a059116e9ebce6f33fe4e3ccda78211caea3 Bug-Url: https://bugzilla.redhat.com/1264109 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/47004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia890a059116e9ebce6f33fe4e3ccda78211caea3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: exttool: aaa: do not add entity name by default

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: exttool: aaa: do not add entity name by default ...................................................................... exttool: aaa: do not add entity name by default adding name by default with '*' does not enable search by id. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177762 Change-Id: Ie06467662e912c32e871db84b3bb1d607d9fcb09 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie06467662e912c32e871db84b3bb1d607d9fcb09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: exttool: aaa: do not add entity name by default

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: exttool: aaa: do not add entity name by default ...................................................................... exttool: aaa: do not add entity name by default adding name by default with '*' does not enable search by id. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177762 Change-Id: Ie06467662e912c32e871db84b3bb1d607d9fcb09 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/extensions-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Ondra Machacek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie06467662e912c32e871db84b3bb1d607d9fcb09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: packaging: use latest if supported

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: use latest if supported ...................................................................... packaging: use latest if supported gettext 0.19.6 introduces a new macro, allowing to use latest gettext provided it's newer than requires See: https://lists.gnu.org/archive/html/bug-gettext/2015-08/msg00026.html Change-Id: I62c81b45e68b1ad541aa32615f0ab8b2641ed7a9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62c81b45e68b1ad541aa32615f0ab8b2641ed7a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: set Firefox 38 as the supported browser.

by piotr.kliczewski＠gmail.com

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: set Firefox 38 as the supported browser. ...................................................................... webadmin: set Firefox 38 as the supported browser. Change-Id: Ifea9d5b055a7a012672725cd6134ece85afe4fe5 Bug-Url: https://bugzilla.redhat.com/1223194 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/46958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifea9d5b055a7a012672725cd6134ece85afe4fe5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

9 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2015