December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: HaReservationHandling streaming API usage
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: HaReservationHandling streaming API usage ...................................................................... core: HaReservationHandling streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: I8e65a58f93483c94809f00fe6e27ed54fd670fbe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e65a58f93483c94809f00fe6e27ed54fd670fbe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AffinityRulesEnforcerTest streaming API usage
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: AffinityRulesEnforcerTest streaming API usage ...................................................................... core: AffinityRulesEnforcerTest streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: If569a6275ef6ccc22e97fba4bdb847b56e6357a6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If569a6275ef6ccc22e97fba4bdb847b56e6357a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AffinityRulesEnforcer streaming API usage
by rgolan＠redhat.com 13 Dec '15

13 Dec '15

Roy Golan has submitted this change and it was merged. Change subject: core: AffinityRulesEnforcer streaming API usage ...................................................................... core: AffinityRulesEnforcer streaming API usage Replace the old-fashioned LinqUtils usage with the modern, built-in streaming API introduced in Java 8. This patch is part of the effort to remove LinqUtils completely. Change-Id: I9e0e520727e6f857d8553d4a6665198ecfcd5c6e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e0e520727e6f857d8553d4a6665198ecfcd5c6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: iso: Enable ISO on gluster
by tnisan＠redhat.com 13 Dec '15

13 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: iso: Enable ISO on gluster ...................................................................... iso: Enable ISO on gluster Enable GlusterFS storage type when domain function is ISO. Change-Id: I2d855da9e2fbfc7232ff165c2e8b20ac01b2a57f Bug-Url: https://bugzilla.redhat.com/1243860 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/50381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d855da9e2fbfc7232ff165c2e8b20ac01b2a57f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Prevent running SetupNetworks as part of ApproveHost...
by tnisan＠redhat.com 13 Dec '15

13 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Prevent running SetupNetworks as part of ApproveHost flow ...................................................................... engine: Prevent running SetupNetworks as part of ApproveHost flow configureNetworks() method should not be run as part of ChangeVDSClusterCommand when it is executed as part of host approval flow. Configuring networks on the host is done later as part of InstallHost. Change-Id: I7e9df62115654b0c36827ebf320b74e41d9cabd4 Bug-Url: https://bugzilla.redhat.com/1271273 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/50208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e9df62115654b0c36827ebf320b74e41d9cabd4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ObjectUtils.haveSameElements performance
by amureini＠redhat.com 13 Dec '15

13 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ObjectUtils.haveSameElements performance ...................................................................... core: ObjectUtils.haveSameElements performance If c1 and c2 are known to have the same size, it's redundant to check that both collections contain each other's elements - it's sufficient to check whether c1.containsAll(c2). Change-Id: I6a45e7b26d052e69cbc5f695c1c839bfaae6ad53 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a45e7b26d052e69cbc5f695c1c839bfaae6ad53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove ListUtils
by amureini＠redhat.com 13 Dec '15

13 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove ListUtils ...................................................................... engine: Remove ListUtils Following a series of patches to remove functionality from ListUtils, the only method left was listsEqual(Collection, Collection), which can easily be removed as ObjectUtils.haveSameElements(Collection, Collection) provides the same functionality. Change-Id: Id1bc71498e8efa3bb8efc4442ab90ab65ec4a23a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/CheckBoxGroup.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 6 files changed, 7 insertions(+), 59 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1bc71498e8efa3bb8efc4442ab90ab65ec4a23a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ListUtils#listsEqual(Collection, Collection)
by amureini＠redhat.com 13 Dec '15

13 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: ListUtils#listsEqual(Collection, Collection) ...................................................................... core: ListUtils#listsEqual(Collection, Collection) org.ovirt.engine.core.common.utils.ListUtils#listEqual(java.util.Collection, java.util.Collection) is basically copy-pasted from java.util.AbstractCollection.containsAll(java.util.Collcetion). This patch replaces the copy-pasted code with a call to containsAll. It not only cleans up the code, but also offers the opportunity for specific collections that override this method to provide a better implementation. Change-Id: Ifbf2686a69143086ea4ed766b3f70329e26ad34e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf2686a69143086ea4ed766b3f70329e26ad34e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Handle ClassCastException in import VM/template po...
by tnisan＠redhat.com 13 Dec '15

13 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Handle ClassCastException in import VM/template popups ...................................................................... webadmin: Handle ClassCastException in import VM/template popups When importing a VM or template, before there was the possibility to select a destination storage domain per disk we had a default storage domain selection, this is not used or visible for quite some time now and aside for throwing ClassCastException this model did nothing. Up till recently, UI exceptions did not propagate to the client and was ignored, now when UI exceptions are logged at the client it is visible to the user, this patch removes the remnant of this redundant model thus preventing the ClassCastException. Bug-Url: https://bugzilla.redhat.com/1289037 Change-Id: I9c1b69b81e01bd82265927fefb4e781969f15b14 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.ui.xml 4 files changed, 8 insertions(+), 56 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/50259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1b69b81e01bd82265927fefb4e781969f15b14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Prevent running SetupNetworks as part of ApproveHost...
by alkaplan＠redhat.com 13 Dec '15

13 Dec '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Prevent running SetupNetworks as part of ApproveHost flow ...................................................................... engine: Prevent running SetupNetworks as part of ApproveHost flow configureNetworks() method should not be run as part of ChangeVDSClusterCommand when it is executed as part of host approval flow. Configuring networks on the host is done later as part of InstallHost. Change-Id: I7e9df62115654b0c36827ebf320b74e41d9cabd4 Bug-Url: https://bugzilla.redhat.com/1271273 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/50206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e9df62115654b0c36827ebf320b74e41d9cabd4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0