Change in ovirt-engine[master]: core: PmHealthCheckManager comment cleanup
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: PmHealthCheckManager comment cleanup
......................................................................
core: PmHealthCheckManager comment cleanup
Removed useless commented out code from PmHealthCheckManager.
Change-Id: I71af54540cfaec163ce698a1c156085d026ac204
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
1 file changed, 0 insertions(+), 23 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71af54540cfaec163ce698a1c156085d026ac204
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: ObjectIdentityChecker methods naming conventions
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ObjectIdentityChecker methods naming conventions
......................................................................
core: ObjectIdentityChecker methods naming conventions
Fixed naming conventions of the ObjectIdentityChecker class' methods
as per the recommended Java naming conventions.
Change-Id: I4c8206eec6a3a3502a4c05be97db756933405cfd
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectIdentityCheckerTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
9 files changed, 69 insertions(+), 69 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49854
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c8206eec6a3a3502a4c05be97db756933405cfd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: HostUpgradeManager streaming API
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: HostUpgradeManager streaming API
......................................................................
core: HostUpgradeManager streaming API
Replace the usage of the outdated ListUtils in
HostUpgradeManager#getPackagesForCheckUpdate() with the modern streaming
API introduced in Java 8 as part of the effort to remove ListUtils from
the codebase completely.
In addition to cleaning up the code, this patch offers a slight
performance improvement by streaming both lists together and collecting
them into a single toSet() collector instead of adding all the packages
from the first list to a Set and then potentially rehahsing it when the
second (filtered) list is added.
A unit test was added to ensure that the proper functionallity is kept.
Change-Id: Ibb5b1d4197b1a353c7324fc5545e90580b5128b7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/HostUpgradeManagerTest.java
2 files changed, 34 insertions(+), 15 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/49385
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5b1d4197b1a353c7324fc5545e90580b5128b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[master]: core: ConfigUtils#getPackagesForCheckUpdate()
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ConfigUtils#getPackagesForCheckUpdate()
......................................................................
core: ConfigUtils#getPackagesForCheckUpdate()
getPackagesForCheckUpdate() is part of the HostUpgradeManager's business
logic and is only ever used there. This patch moves it to its rightful
place in order to keep the commons' Config class as minimal as possible,
like common classes should be.
Change-Id: I04250b3ddc55836fd2d323bb4cfcaeb75bbea451
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
2 files changed, 25 insertions(+), 29 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04250b3ddc55836fd2d323bb4cfcaeb75bbea451
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6]: engine: prevent NPE in PersistentHostSetupNetworksCommand
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: prevent NPE in PersistentHostSetupNetworksCommand
......................................................................
engine: prevent NPE in PersistentHostSetupNetworksCommand
Prevent NPE in PersistentHostSetupNetworksCommand.checkForChanges
method. Apparently netConfigDirty boolean field could be null.
Change-Id: I654676635fbd08364d6fb0a05b3b4d8b1742d649
Bug-Url: https://bugzilla.redhat.com/1271273
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java
1 file changed, 19 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/50038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I654676635fbd08364d6fb0a05b3b4d8b1742d649
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6.1]: core: Fix typo in audit log message
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix typo in audit log message
......................................................................
core: Fix typo in audit log message
Change-Id: I1311f46567c5170c95650b76f3af8d5e82a76648
Bug-Url: https://bugzilla.redhat.com/1273378
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Roy Golan: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50081
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1311f46567c5170c95650b76f3af8d5e82a76648
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6.1]: core: Extract interfaces by the right key
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Extract interfaces by the right key
......................................................................
core: Extract interfaces by the right key
Fixing importing the network interfaces from vdsm. It used the wrong
dictionatry key ("iface instaed of "interface")
Change-Id: I2db437395a2cc303a03a16eb4194df09cac13e20
Bug-Url: https://bugzilla.redhat.com/1273378
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Roy Golan: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50080
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2db437395a2cc303a03a16eb4194df09cac13e20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6.1]: core: Audit log importing of hosted engine domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Audit log importing of hosted engine domain
......................................................................
core: Audit log importing of hosted engine domain
Change-Id: Idf3ec89b73824c6078979d94bae46cd204c93f6d
Bug-Url: https://bugzilla.redhat.com/1269768
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roy Golan: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf3ec89b73824c6078979d94bae46cd204c93f6d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6.1]: core: Auto import HE VM if config option is set
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Auto import HE VM if config option is set
......................................................................
core: Auto import HE VM if config option is set
Consult ConfigValues.AutoImportHostedEngine before doing the import.
Version 3.5 and below is not supported and is False by default.
engine-config property is introduced as well
Change-Id: Iab2f4c8d41afdd7ae5037f99c19b25e70eb9b443
Bug-Url: https://bugzilla.redhat.com/1269768
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
4 files changed, 26 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Roy Golan: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50078
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab2f4c8d41afdd7ae5037f99c19b25e70eb9b443
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years
Change in ovirt-engine[ovirt-engine-3.6.1]: core: Auto import Hosted Engine Storage Domain
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Auto import Hosted Engine Storage Domain
......................................................................
core: Auto import Hosted Engine Storage Domain
The hosted engine storage domain is a critical part of the
managing that VM with the engine.
In order to reduce manual intervention, we can collect all
data and import that domain automatically.
The flow would be:
1. Analyze the VM (VM monitoring) and check if its MANAGED
2. if not MANAGED, try to import the SD
3. detect the SD details by crossmatching the domain info (we have the
name in config) with the output of getDeviceList, to get connection
details of ISCSI
4. import the SD
5. if SD imported, import the VM
Change-Id: Ib1a240e8e5ee2502a5ce11ec586a0eacec9f83fe
Bug-Url: https://bugzilla.redhat.com/1269768
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetExistingStorageDomainListQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/CommonTestMocks.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SchedulingManagerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
9 files changed, 516 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roy Golan: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50077
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1a240e8e5ee2502a5ce11ec586a0eacec9f83fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
9 years