December 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Handle Cinder imaged once snapshot gets commited/undo.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Handle Cinder imaged once snapshot gets commited/undo. ...................................................................... core: Handle Cinder imaged once snapshot gets commited/undo. Set the Cinder images to restore once a snapshot gets commited. Change-Id: I64170f1d82c0bd1ba973078eb11f5752ebd31036 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 30 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64170f1d82c0bd1ba973078eb11f5752ebd31036 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Get previewed snapshot's images by the snapshot's OVF.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Get previewed snapshot's images by the snapshot's OVF. ...................................................................... core: Get previewed snapshot's images by the snapshot's OVF. We should get images from previewed snapshot configuration, instead fetching them from the DB. The reason for that is to overcome a scenrio when a VM contains several disks, gets previewed from a snapshot which only have part of those disks (Several disks were created after the snapshot was created). The preview operation, for the disks created after this snapshot, is to remove their data from the base_disks table and only leave their data in the images table. The problem appears once the user undo/commit the previewed snapshot. The functionality is adding the data to the base_disks and always assume it is an image disk. The proposed solution is to use the VM configuration when fetching the disks to restore once a previewed VM gets undo/commited so the engine can determined which type of disks we are restoring after an undo operation. Change-Id: I421e95e3dd0023927f07db697dcb86b2593be848 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 21 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I421e95e3dd0023927f07db697dcb86b2593be848 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add cinder volume type for VM's disks' OVF.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Add cinder volume type for VM's disks' OVF. ...................................................................... core: Add cinder volume type for VM's disks' OVF. Add cinder volume type to update the Cinder disk with the relevant cinder volume type, once the snapshot gets commited or undo. Change-Id: I835237f987112d902b3ca30c827f5b38fa3b3be7 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I835237f987112d902b3ca30c827f5b38fa3b3be7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Get initial Cinder volume to restore from.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Get initial Cinder volume to restore from. ...................................................................... core: Get initial Cinder volume to restore from. Add a method which returns the initial Cinder volume the engine should delete. The restore process of the Cinder volume should use this volume to get all its descendants and remove them all. The initial volume is chosen by taking the previewed snapshot, fetch the parent volume, and retun the other volume. Change-Id: Iffaa62f703734f50208418786dc813bfe82106b9 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffaa62f703734f50208418786dc813bfe82106b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Refactor, Use RemoveCinderVolumeParentCommand method.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor, Use RemoveCinderVolumeParentCommand method. ...................................................................... core: Refactor, Use RemoveCinderVolumeParentCommand method. Make RemoveCinderDiskCommand to use methods from the parent command. The difference in the parent command is that we also pass the storage id of the volume. Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommandCallback.java 2 files changed, 7 insertions(+), 129 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49ebcbfff3b584e39d20dec0b686e2879e30d650 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Restore snapshot should handle Cinder snapshot.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Restore snapshot should handle Cinder snapshot. ...................................................................... core: Restore snapshot should handle Cinder snapshot. When a Cinder snapshot gets commited, the redundant volumes and snapshots should be deleted. Since the Cinder volume chain is different than the image volume chain, it is neccessery to filter out the relevant snapshots to delete separately than how it is being done today with images. Change-Id: Ibe1808974c467ab910d03e450d83490f0ee0fc56 Bug-Url: https://bugzilla.redhat.com/1256048 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 32 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe1808974c467ab910d03e450d83490f0ee0fc56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add a new Cinder volume parent command.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Add a new Cinder volume parent command. ...................................................................... core: Add a new Cinder volume parent command. Add a new parent command to be used for remove of Cinder disk/volume. This command should share the same logic of remove Cinder disk and remove of Cinder volumes once a snapshot gets commited and its redundant volumes should be deleted. Change-Id: I376de555234c3050fba480573ff984effd4b3c06 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderVolumeParentCommand.java 1 file changed, 131 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I376de555234c3050fba480573ff984effd4b3c06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Use linked list instead of list.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Use linked list instead of list. ...................................................................... core: Use linked list instead of list. Use linked list for childCommandsParameters so it will be more easy to implement LIFO method for child command parameters. Change-Id: I804a84a7535e2e5e1590455009bc54220354f846 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I804a84a7535e2e5e1590455009bc54220354f846 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add updateSnapshot to CinderDiskParameters.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Add updateSnapshot to CinderDiskParameters. ...................................................................... core: Add updateSnapshot to CinderDiskParameters. Add a new parameter called updateSnapshot. This parameter should indicate whether the snapshot should be updated or not while removing the volume. For example when we remove an image while restoring a volume the snapshot should not get updated, but when we remove a disk we definitely need to remove the volume from all the VM's snapshots. Change-Id: I8af9e844d6c0513230ad0966d4547ac2584b3711 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8af9e844d6c0513230ad0966d4547ac2584b3711 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: cleanup, use getDiskImageDao at isCinderHasNoImages.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: cleanup, use getDiskImageDao at isCinderHasNoImages. ...................................................................... core: cleanup, use getDiskImageDao at isCinderHasNoImages. Change-Id: I944a48fa1598eedc502ea30cc5de398c57b96f74 Bug-Url: https://bugzilla.redhat.com/1256048 Bug-Url: https://bugzilla.redhat.com/1256049 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/50055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I944a48fa1598eedc502ea30cc5de398c57b96f74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

9 years

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2015