Change in ovirt-engine[master]: core: allow to remove vm that is previewing a snapshot
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: allow to remove vm that is previewing a snapshot
......................................................................
core: allow to remove vm that is previewing a snapshot
Now that memory volumes are always being removed when removing a VM
(Ieed64d), we can permit the removal of VMs that preview a snapshot.
Change-Id: Ifdba55e656892284e61fb48d38a5d64316c4857d
Bug-Url: https://bugzilla.redhat.com/1197808
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdba55e656892284e61fb48d38a5d64316c4857d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Set host protocol to jsonrpc automatically
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Set host protocol to jsonrpc automatically
......................................................................
engine: Set host protocol to jsonrpc automatically
In order to simplify host upgrade and cluster upgrade process,
the host protocol will be set to jsonrpc by the following criteria:
* The host belongs to cluster which supports jsonrpc (>= 3.5)
* The existing host's protocol is xmlrpc
* The host was active in the system, so its capabilities were collected
and supports jsonrpc.
In this case, any host that was upgraded or re-installed in the system,
will be set to jsonrpc protocol as part of the upgrade/reinstall
process and will reduce the need to explicitly move each host to
jsonrpc before upgrading the cluster level to 3.6.
Change-Id: Ibf5baa9f57d3c8fad1091e2141350961a2ceb4b0
Bug-Url: https://bugzilla.redhat.com/1286452
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommand.java
6 files changed, 52 insertions(+), 23 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51095
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5baa9f57d3c8fad1091e2141350961a2ceb4b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: add missing initialization of vm-init model for pool
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: add missing initialization of vm-init model for pool
......................................................................
webadmin: add missing initialization of vm-init model for pool
Missing initialization of VM-init model in the new VM pool dialog caused
properties in the model to be uninitialized and therefore to produce
NPEs. This patch adds default initialization of the model for new pool
dialog the same way it happens for new VM dialog.
Change-Id: I16d8ef192759863cb84d0f54f0daeea165000d22
Bug-Url: https://bugzilla.redhat.com/1289961
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16d8ef192759863cb84d0f54f0daeea165000d22
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: core: ignore noVm error for internal destroy ops
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ignore noVm error for internal destroy ops
......................................................................
core: ignore noVm error for internal destroy ops
In Icd93048d78 we changed the engine to ignore errors of type noVm
when they arrive from the destination host after cancel migration.
Actually this is a particular instance of a more general problem -
if we ask to destroy the VM and it is not there anymore, does it
really mean that the opreation fails?
Sure, for user-initiated operations it makes some sense to report
these errors so users will know that the operation they asked for
failed (and this is also debateable), but for internal operations
- it is not interesting for anyone to know about this "problem".
Therefore, setting ignoreNoVm to true for all destroy operations
that are done from the monitoring.
Change-Id: Ibc43d294804b0dd4070c0a08af6bba40652e1281
Bug-Url: https://bugzilla.redhat.com/1290361
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyVmVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java
3 files changed, 34 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc43d294804b0dd4070c0a08af6bba40652e1281
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Set host protocol to jsonrpc automatically
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Set host protocol to jsonrpc automatically
......................................................................
engine: Set host protocol to jsonrpc automatically
In order to simplify host upgrade and cluster upgrade process,
the host protocol will be set to jsonrpc by the following criteria:
* The host belongs to cluster which supports jsonrpc (>= 3.5)
* The existing host's protocol is xmlrpc
* The host was active in the system, so its capabilities were collected
and supports jsonrpc.
In this case, any host that was upgraded or re-installed in the system,
will be set to jsonrpc protocol as part of the upgrade/reinstall
process and will reduce the need to explicitly move each host to
jsonrpc before upgrading the cluster level to 3.6.
Change-Id: Ibf5baa9f57d3c8fad1091e2141350961a2ceb4b0
Bug-Url: https://bugzilla.redhat.com/1286452
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommand.java
6 files changed, 52 insertions(+), 23 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51094
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5baa9f57d3c8fad1091e2141350961a2ceb4b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Add jobs for building the engine API model
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add jobs for building the engine API model
......................................................................
Add jobs for building the engine API model
This patch adds new jobs to build and run tests for the engine API
model.
Change-Id: Ic1dd2f65f1ed3f5e65e35c6a49efdc4ff0c42a7d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A jobs/confs/projects/ovirt-engine-api-model/ovirt-engine-api-model_build.yaml
A jobs/confs/projects/ovirt-engine-api-model/ovirt-engine-api-model_checks.yaml
A jobs/confs/yaml/scms/ovirt-engine-api-model.yaml
3 files changed, 36 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51009
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1dd2f65f1ed3f5e65e35c6a49efdc4ff0c42a7d
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Add jobs for building the engine API metamodel
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add jobs for building the engine API metamodel
......................................................................
Add jobs for building the engine API metamodel
This patch adds new jobs to build and run tests for the engine API
metamodel.
Change-Id: Ie829581a052ea29cde37bab2394e312eca262fc2
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A jobs/confs/projects/ovirt-engine-api-metamodel/ovirt-engine-api-metamodel_build.yaml
A jobs/confs/projects/ovirt-engine-api-metamodel/ovirt-engine-api-metamodel_checks.yaml
A jobs/confs/yaml/scms/ovirt-engine-api-metamodel.yaml
3 files changed, 36 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie829581a052ea29cde37bab2394e312eca262fc2
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: fix some warnings in vms-monitoring
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix some warnings in vms-monitoring
......................................................................
core: fix some warnings in vms-monitoring
Minor cleanup that fixes few compilation warnings in
VmsMonitoring class.
Change-Id: I060a36f0656dd83078c1853f6cb2858743879ed7
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I060a36f0656dd83078c1853f6cb2858743879ed7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Remove unused TransferTest members
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove unused TransferTest members
......................................................................
core: Remove unused TransferTest members
Change-Id: Id46741bea3230aa99758505e3fbe55e13f5873b7
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50678
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id46741bea3230aa99758505e3fbe55e13f5873b7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: StringValueConverter#typeBox
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: StringValueConverter#typeBox
......................................................................
core: StringValueConverter#typeBox
Removed the typeBox map and use org.apache.commons.lang.ClassUtils
instead.
Change-Id: Ic482912d87fd3433c1c9f981bac4d2156a476815
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/StringValueConverter.java
1 file changed, 3 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50677
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic482912d87fd3433c1c9f981bac4d2156a476815
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months