December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: userportal: present only templates in data center on new vm
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: userportal: present only templates in data center on new vm ...................................................................... userportal: present only templates in data center on new vm Filter the templates that are shown in the new VM dialog so only templates that reside in the selected data center will be displayed. Change-Id: Ibdb5e05a18c7c08be8aa68226289c3d524d82a9d Bug-Url: https://bugzilla.redhat.com/1293152 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdb5e05a18c7c08be8aa68226289c3d524d82a9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fixed Affinity Rules Enforcer task scheduling
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fixed Affinity Rules Enforcer task scheduling ...................................................................... core: Fixed Affinity Rules Enforcer task scheduling The job for the Affinity Rules Enforcement Manager would schedule the inital delay as the regular interval (From the engine config) and vice versa. This patch fixes it and now the regular interval is set as it stated in the engine config. Change-Id: I3355fd063eb099986d36c55f636284ec82189bbb Bug-Url: https://bugzilla.redhat.com/1270780 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Tomer Saban: Verified Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3355fd063eb099986d36c55f636284ec82189bbb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Disallow disk edit when it's in locked status
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Disallow disk edit when it's in locked status ...................................................................... core: Disallow disk edit when it's in locked status Change-Id: Iefa02a875abcd8e1c460b3554eece6b4d953f443 Bug-Url: https://bugzilla.redhat.com/1292509 Bug-Url: https://bugzilla.redhat.com/1289538 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java 2 files changed, 24 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/50803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa02a875abcd8e1c460b3554eece6b4d953f443 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix exception in edit storage model
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix exception in edit storage model ...................................................................... webadmin: Fix exception in edit storage model Change-Id: Ifba49c7fcc1367f78767d617a0b680fed88aab01 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294087 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifba49c7fcc1367f78767d617a0b680fed88aab01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Handle storage domain types version checks correctly
by tnisan＠redhat.com 27 Dec '15

27 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Handle storage domain types version checks correctly ...................................................................... webadmin: Handle storage domain types version checks correctly The method responsible to check whether a storage type is supported in a DC version used to return boolean, in cases that there is no info on whether the type is supported (for instance when the DC is null when selecting 'none' as the DC) the unboxing of the null Boolean resulted in an NPE. This was fixed by returning Boolean from the method and comparing the result correctly. Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1294089 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/FileStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/IStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I763aa67192f9d7bbf1e28bce273ad90c232ae125 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: add missing initialization of vm-init model for pool
by ahadas＠redhat.com 27 Dec '15

27 Dec '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: add missing initialization of vm-init model for pool ...................................................................... webadmin: add missing initialization of vm-init model for pool Missing initialization of VM-init model in the new VM pool dialog caused properties in the model to be uninitialized and therefore to produce NPEs. This patch adds default initialization of the model for new pool dialog the same way it happens for new VM dialog. Change-Id: I16d8ef192759863cb84d0f54f0daeea165000d22 Bug-Url: https://bugzilla.redhat.com/1289961 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16d8ef192759863cb84d0f54f0daeea165000d22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Align Bookmark commands with commands standards
by masayag＠redhat.com 27 Dec '15

27 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Align Bookmark commands with commands standards ...................................................................... core: Align Bookmark commands with commands standards Change-Id: I6b625211356df9a15a5c2215cdabd20aa2fca56a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddBookmarkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BookmarkCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveBookmarkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/BookmarksOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/BookmarksParametersBase.java 6 files changed, 60 insertions(+), 59 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b625211356df9a15a5c2215cdabd20aa2fca56a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Fix typo
by masayag＠redhat.com 27 Dec '15

27 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix typo ...................................................................... engine: Fix typo Change-Id: I498bf815c4a5848ef6d19ee2285906d714878a30 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I498bf815c4a5848ef6d19ee2285906d714878a30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Simplify comparison of two objects
by masayag＠redhat.com 27 Dec '15

27 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Simplify comparison of two objects ...................................................................... core: Simplify comparison of two objects Change-Id: I1ce11e62b2b2acb49fd7c9b217743932f6479e79 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ce11e62b2b2acb49fd7c9b217743932f6479e79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Set host protocol to jsonrpc automatically
by masayag＠redhat.com 27 Dec '15

27 Dec '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Set host protocol to jsonrpc automatically ...................................................................... engine: Set host protocol to jsonrpc automatically In order to simplify host upgrade and cluster upgrade process, the host protocol will be set to jsonrpc by the following criteria: * The host belongs to cluster which supports jsonrpc (>= 3.5) * The existing host's protocol is xmlrpc * The host was active in the system, so its capabilities were collected and supports jsonrpc. In this case, any host that was upgraded or re-installed in the system, will be set to jsonrpc protocol as part of the upgrade/reinstall process and will reduce the need to explicitly move each host to jsonrpc before upgrading the cluster level to 3.6. Change-Id: Ibf5baa9f57d3c8fad1091e2141350961a2ceb4b0 Bug-Url: https://bugzilla.redhat.com/1286452 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommand.java 6 files changed, 49 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf5baa9f57d3c8fad1091e2141350961a2ceb4b0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0