December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: Remove AbstractVmPopupWidget.localize() method
by vszocs＠redhat.com 07 Dec '15

07 Dec '15

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: Remove AbstractVmPopupWidget.localize() method ...................................................................... frontend: Remove AbstractVmPopupWidget.localize() method Moved manual setting of label/text properties to ui.xml file, since method contained no additional logic to setting it declaratively in the ui.xml file. Change-Id: Ib0917cbb7eabe2a3bc80a168ad06136342cf09a8 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 2 files changed, 93 insertions(+), 217 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/49112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0917cbb7eabe2a3bc80a168ad06136342cf09a8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: there are no such things as ghost in MacRangeWidget
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: there are no such things as ghost in MacRangeWidget ...................................................................... webadmin: there are no such things as ghost in MacRangeWidget 'isGhost' mechanism is faulty. Correct behavior is, acording to colleges and code notes, that there's at most one ghost and it has to be the last record. Currently implementation allows existence of multiple ghosts, which needs not to be trailing records. For simplicity, in this dialog we assume that there cannot exist ghosts, until ghost problem is solved generally Change-Id: I8091cedfd3cf51dfcb93bb7c7de45234088bfdd8 Bug-Url: https://bugzilla.redhat.com/1217940 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacRangeWidget.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8091cedfd3cf51dfcb93bb7c7de45234088bfdd8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.1]: core: fix incorrect json value in config
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix incorrect json value in config ...................................................................... core: fix incorrect json value in config AutoRecoveryAllowedTypes config key value is {\"storage domains\":\"true\",\"hosts\":\"true\"} This is not a legal JSON format and generates the following error upon application start: ERROR [org.ovirt.engine.core.dal.dbbroker.generic.DBConfigUtils] (ServerService Thread Pool -- 43) [] Error parsing option 'AutoRecoveryAllowedTypes' value: org.codehaus.jackson.JsonParse Exception: Unexpected character ('\' (code 92)): was expecting double-quote to start field name at [Source: java.io.StringReader@3198de41; line: 1, column: 3] Change-Id: Iba1ffefd646219dbeb8909ab620a44f960fb97c1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1287589 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba1ffefd646219dbeb8909ab620a44f960fb97c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.1 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unused parameter from cloneDiskImage()
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: remove unused parameter from cloneDiskImage() ...................................................................... core: remove unused parameter from cloneDiskImage() Change-Id: Iee41a5ae0afa4c4e5ef8fd22b1d488e65ea22f9d Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/49481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee41a5ae0afa4c4e5ef8fd22b1d488e65ea22f9d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: improve robustness of import-VM dialog
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: improve robustness of import-VM dialog ...................................................................... webadmin: improve robustness of import-VM dialog This patch fixes the import-VM dialog to handle errors properly when either timeouts or other errors occur. The progress is stopped and proper error message is displayed. Change-Id: I1b41f61050ef0a73b8b4493c5e3aa962daa0dd3f Bug-Url: https://bugzilla.redhat.com/1284412 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 2 files changed, 27 insertions(+), 16 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Shahar Havivi: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b41f61050ef0a73b8b4493c5e3aa962daa0dd3f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: support vmware provider without data-center
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: support vmware provider without data-center ...................................................................... webadmin: support vmware provider without data-center Fix NPE that was thrown when adding external provider of type VMware with no data center defined. This patch also fixes the import-VM dialog to support import from external provider that is not defined for a particular data center (but with 'any data center'). Change-Id: I32aef8081e4f52cf95348735a743f41c2cbfb1c6 Bug-Url: https://bugzilla.redhat.com/1284260 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32aef8081e4f52cf95348735a743f41c2cbfb1c6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: support vmware provider without proxy
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: support vmware provider without proxy ...................................................................... webadmin: support vmware provider without proxy Fix NPE that was thrown when adding external provider of type VMware with no proxy host set. Change-Id: I8357b4f23fb74cd83d1474f9e892cb5f31cb40e8 Bug-Url: https://bugzilla.redhat.com/1284260 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/49630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8357b4f23fb74cd83d1474f9e892cb5f31cb40e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add memballoon by default to blank template
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: add memballoon by default to blank template ...................................................................... core: add memballoon by default to blank template Adds the memballoon to the balnk template. The VMs already created from this template are not touched since there is no way to know if the user wanted to have it enabled or disabled. Change-Id: I529c6b915422f7e507a7d757cbb0bec9d58311cc Bug-Url: https://bugzilla.redhat.com/1280004 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1950_enable_ballon_for_blank_template.sql 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I529c6b915422f7e507a7d757cbb0bec9d58311cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history: use engine-events connection that is refreshed
by sradco＠redhat.com 07 Dec '15

07 Dec '15

Shirly Radco has submitted this change and it was merged. Change subject: history: use engine-events connection that is refreshed ...................................................................... history: use engine-events connection that is refreshed If the connection to the db is lost and renewed, the connection that is currently used for updating that etl stopped does not reconnect. I replaced the connection to one that is refreshed after a connection is lost. Change-Id: I95f6c810f54913c9430b86cee57845185a257070 Bug-Url: https://bugzilla.redhat.com/1286441 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/historyetl_3_6/HistoryETL.java M tos_project/process/HistoryETL_3.6.item M tos_project/process/HistoryETL_3.6.properties 3 files changed, 161 insertions(+), 9 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/49423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95f6c810f54913c9430b86cee57845185a257070 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix incorrect json value in config
by tnisan＠redhat.com 07 Dec '15

07 Dec '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix incorrect json value in config ...................................................................... core: fix incorrect json value in config AutoRecoveryAllowedTypes config key value is {\"storage domains\":\"true\",\"hosts\":\"true\"} This is not a legal JSON format and generates the following error upon application start: ERROR [org.ovirt.engine.core.dal.dbbroker.generic.DBConfigUtils] (ServerService Thread Pool -- 43) [] Error parsing option 'AutoRecoveryAllowedTypes' value: org.codehaus.jackson.JsonParse Exception: Unexpected character ('\' (code 92)): was expecting double-quote to start field name at [Source: java.io.StringReader@3198de41; line: 1, column: 3] Change-Id: Iba1ffefd646219dbeb8909ab620a44f960fb97c1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1287589 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba1ffefd646219dbeb8909ab620a44f960fb97c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0