December 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SyntaxCheckerFacotry MockConfigRule usage
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerFacotry MockConfigRule usage ...................................................................... core: SyntaxCheckerFacotry MockConfigRule usage Use MockConfigRule to clean up the test and make it easier to read. As an added bonus, the MockConfigRule takes care of cleaning up the mocked configuration once the test is over, a cleanup missing from the original test. Change-Id: I8634dd0a0aeea0dab9a26a5899001f534c774841 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8634dd0a0aeea0dab9a26a5899001f534c774841 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyntaxCheckerFactoryTest methods naming conventions
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerFactoryTest methods naming conventions ...................................................................... core: SyntaxCheckerFactoryTest methods naming conventions Fixed naming conventions of the SyntaxCheckerFactoryTest class' methods as per the recommended Java naming conventions. Change-Id: I4be27828fa42cdd043714a06d5156a5f1865de0b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4be27828fa42cdd043714a06d5156a5f1865de0b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateVdsGroupCommandTest methods naming conventions
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVdsGroupCommandTest methods naming conventions ...................................................................... core: UpdateVdsGroupCommandTest methods naming conventions Fixed naming conventions of the UpdateVdsGroupCommandTest class' methods as per the recommended Java naming conventions. Change-Id: I87e2eba11d3531ae4cf106ec909f75947adfc2d8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e2eba11d3531ae4cf106ec909f75947adfc2d8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Date search methods names
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Date search methods names ...................................................................... core: Date search methods names Renamed methods related to date searching to comply to Java's naming conventions. Change-Id: I5cd58e4f96c33c5e212abe657c01e664a0ddffe7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleter.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cd58e4f96c33c5e212abe657c01e664a0ddffe7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Forman classes' naming conventions
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Forman classes' naming conventions ...................................................................... core: Forman classes' naming conventions Renamed members and methods in the Foreman-related classes to comply with the Java naming conventions Change-Id: Ia7739e59c66f03639eb0d7b0608c348922cd9f6a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanError.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 4 files changed, 114 insertions(+), 114 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7739e59c66f03639eb0d7b0608c348922cd9f6a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SpmStatusVDSCommand methods naming conventions
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SpmStatusVDSCommand methods naming conventions ...................................................................... core: SpmStatusVDSCommand methods naming conventions Fixed naming conventions of the SpmStatusVDSCommand class' methods as per the recommended Java naming conventions. Change-Id: I07524c45c82892b4d241e42986608d160502ae75 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07524c45c82892b4d241e42986608d160502ae75 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SpmStatusVDSCommand#ParseSpmStatusResult params
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: SpmStatusVDSCommand#ParseSpmStatusResult params ...................................................................... core: SpmStatusVDSCommand#ParseSpmStatusResult params Removed unused parameter. Change-Id: Iec1869dc3f5abbeb15e6d3d72354ad200a7f429d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStatusVDSCommand.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec1869dc3f5abbeb15e6d3d72354ad200a7f429d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsCommand methods naming conventions
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: VdsCommand methods naming conventions ...................................................................... core: VdsCommand methods naming conventions Fixed naming conventions of the VdsCommand class' methods as per the recommended Java naming conventions. Change-Id: I1f84e87880e534f9bcfabaf3a44e1897b0a27ee6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f84e87880e534f9bcfabaf3a44e1897b0a27ee6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DetachUserFromVmFromPoolCommand methods naming convent...
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: DetachUserFromVmFromPoolCommand methods naming conventions ...................................................................... core: DetachUserFromVmFromPoolCommand methods naming conventions Fixed naming conventions of the DetachUserFromVmFromPoolCommand class' methods as per the recommended Java naming conventions. Change-Id: I692195744cbe9870020d1fa21d3bd05dbfa8daae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I692195744cbe9870020d1fa21d3bd05dbfa8daae Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HostSetupNetworksValidatorTest methods naming conventions
by amureini＠redhat.com 08 Dec '15

08 Dec '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: HostSetupNetworksValidatorTest methods naming conventions ...................................................................... core: HostSetupNetworksValidatorTest methods naming conventions Fixed naming conventions of the HostSetupNetworksValidatorTest class' methods as per the recommended Java naming conventions. Change-Id: Id17a4736d5bacf27473493d3f1db2a2505802efd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id17a4736d5bacf27473493d3f1db2a2505802efd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0