Change in ovirt-engine[master]: webadmin: Display total RX/TX in interface subtabs
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Display total RX/TX in interface subtabs
......................................................................
webadmin: Display total RX/TX in interface subtabs
Display the total RX/TX statistics in the host/interfaces,
network/hosts, VM/interfaces and network/VMs subtabs.
Change-Id: I21f4f05d79de76f7b058a091e27b3aca6badf94e
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/NullableNumberRenderer.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NullableNumberColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceInfoPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterface.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityInfoPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberLabel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/NullableNumberTextBoxLabel.java
16 files changed, 167 insertions(+), 31 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36471
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21f4f05d79de76f7b058a091e27b3aca6badf94e
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: engine: Persist total RX/TX in compatible hosts/VMs
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Persist total RX/TX in compatible hosts/VMs
......................................................................
engine: Persist total RX/TX in compatible hosts/VMs
Persist the new total RX/TX values for host/VM interfaces in
compatible clusters. Also, if the cluster is compatible, compute rate
on our own (so vdsm could drop the computation in future versions).
Change-Id: I3063bb36fb7e4d5a545d42c648091688ce1e6964
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkStatisticsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkStatisticsBuilderTest.java
6 files changed, 443 insertions(+), 25 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36470
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3063bb36fb7e4d5a545d42c648091688ce1e6964
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Added version support for total RX/TX reporting
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Added version support for total RX/TX reporting
......................................................................
core: Added version support for total RX/TX reporting
Added support for reporting of total interface network usage
statistics starting from version 3.6.
Change-Id: If0f92d87eca74b6709edf389b4476e359d1aea7d
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0f92d87eca74b6709edf389b4476e359d1aea7d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Add total RX/TX in DB and DAL
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Add total RX/TX in DB and DAL
......................................................................
core: Add total RX/TX in DB and DAL
Added the total RX/TX columns to the host and VM interface statistics
tables, and updated their DAOs.
Change-Id: Ie91655cef0165375bf5e1e4f8b4d6e08275a541e
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkStatisticsDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/03_06_0860_add_total_rx_tx_statistics.sql
9 files changed, 234 insertions(+), 60 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/36468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie91655cef0165375bf5e1e4f8b4d6e08275a541e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[ovirt-engine-3.5]: core: iscsibond, disconnect Host from all connections' inter...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: iscsibond, disconnect Host from all connections' interfaces.
......................................................................
core: iscsibond, disconnect Host from all connections' interfaces.
Once the Host is moving to maintenance it is necessery to disconnect the Host
from all the connections' interfaces the host was connected to, as part of the iSCSI
bond configuration.
Change-Id: I7fa178bd5946afeff4864b4804d6e38ada8482c1
Bug-Url: https://bugzilla.redhat.com/1191466
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/37690
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fa178bd5946afeff4864b4804d6e38ada8482c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: Add total RX/TX bytes to NetworkStatistics
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Add total RX/TX bytes to NetworkStatistics
......................................................................
core: Add total RX/TX bytes to NetworkStatistics
This will provide the basis for total network usage by host/VM
interfaces.
Change-Id: I1178faca34203b01b6fc120bf7f65ba1caf500a8
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java
1 file changed, 131 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/36467
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1178faca34203b01b6fc120bf7f65ba1caf500a8
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: webadmin: fix add brick validation issue
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: fix add brick validation issue
......................................................................
webadmin: fix add brick validation issue
Fix the add brick validation issue for replicate and
stripe volume.
Bug-Url: https://bugzilla.redhat.com/1143828
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
Change-Id: I005c32f2d030c35ec43149ee4f4aeaa7e731ee3c
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/37688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I005c32f2d030c35ec43149ee4f4aeaa7e731ee3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months
Change in ovirt-engine[master]: webadmin: add help tags for add/edit volume options.
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: add help tags for add/edit volume options.
......................................................................
webadmin: add help tags for add/edit volume options.
Adding help tags for Add and Edit Gluster Volume option
dialogs.
Bug-Url: https://bugzilla.redhat.com/1177883
Change-Id: Ic95e11ecb0d38be13d5aba3a4e64fdff586eef05
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/37483
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic95e11ecb0d38be13d5aba3a4e64fdff586eef05
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: core: iscsibond, disconnect Host from all connections' inter...
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: iscsibond, disconnect Host from all connections' interfaces.
......................................................................
core: iscsibond, disconnect Host from all connections' interfaces.
Once the Host is moving to maintenance it is necessery to disconnect the Host
from all the connections' interfaces the host was connected to, as part of the iSCSI
bond configuration.
Change-Id: I7fa178bd5946afeff4864b4804d6e38ada8482c1
Bug-Url: https://bugzilla.redhat.com/1140850
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/37678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fa178bd5946afeff4864b4804d6e38ada8482c1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 11 months
Change in ovirt-engine[master]: engine: Add error messages to user portal.
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: Add error messages to user portal.
......................................................................
engine: Add error messages to user portal.
Add error messages related to failed DiskProfile verification
while creating vm from template.
Change-Id: I4ff20a305bb76f48b8705fb89f244c1257cd4715
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37280
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ff20a305bb76f48b8705fb89f244c1257cd4715
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 11 months