February 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Improve performance of GetStorageConnectionsByStorageT...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: Improve performance of GetStorageConnectionsByStorageTypeAndStatus ...................................................................... core: Improve performance of GetStorageConnectionsByStorageTypeAndStatus This Stored Procedure is slow because of distinct and UNION operators. The refactored implementation uses sub-selects to improve performance. This reduced execution time in the performance lab from 3s to <1s Change-Id: I8048b87fa321086469c892c3650f7c5548cc13d8 Bug-Url: https://bugzilla.redhat.com/1186763 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M packaging/dbscripts/storages_san_sp.sql 1 file changed, 9 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Liran Zelkha: Verified Eldad Marciano: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8048b87fa321086469c892c3650f7c5548cc13d8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: remove ConfigurationValues.DefaultManagementNetwork

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: remove ConfigurationValues.DefaultManagementNetwork ...................................................................... webadmin: remove ConfigurationValues.DefaultManagementNetwork Remove DefaultManagementNetwork from ConfigurationValues as it is not in use anymore. Change-Id: Id05788aa2a6d883ba67b4b73ab17d4603d23a978 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/37033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id05788aa2a6d883ba67b4b73ab17d4603d23a978 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: update how mgmt network being selected for a new V...

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: update how mgmt network being selected for a new Vnic profile ...................................................................... webadmin: update how mgmt network being selected for a new Vnic profile Update the way the management network being selected in New Vnic Profile flow. Change-Id: Iac4536cd0394999e128d4448014ebbcc2930ffdf Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewProfileBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ProfileBehavior.java 3 files changed, 17 insertions(+), 6 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac4536cd0394999e128d4448014ebbcc2930ffdf Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: unused management ENGINE_NETWORK_NAME was removed

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: unused management ENGINE_NETWORK_NAME was removed ...................................................................... webadmin: unused management ENGINE_NETWORK_NAME was removed ENGINE_NETWORK_NAME was removed from VmInterfaceModel class as it wasn't in use. Change-Id: I2c1ba27025ade4849e117edeeb1294375e26e5d2 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/37031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1ba27025ade4849e117edeeb1294375e26e5d2 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: management notion is removed from Network-general ...

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: management notion is removed from Network-general sub-tab ...................................................................... webadmin: management notion is removed from Network-general sub-tab Management network notion is removed from Network-General sub-tab. Change-Id: I0b1aaf1eaea137953d8542d02d16fc4c710b4eee Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java 4 files changed, 19 insertions(+), 46 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/37030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b1aaf1eaea137953d8542d02d16fc4c710b4eee Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Remove network button is enabled in DC netwoks sub...

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove network button is enabled in DC netwoks sub-tab. ...................................................................... webadmin: Remove network button is enabled in DC netwoks sub-tab. Remove network button is enabled in DC netwoks sub-tab whenever at least one network is selected. The verification that the management network wouldn't be deleted is done in the backend only now. Change-Id: I5a6d29c7fbec822381b0ee33116b41ca574bcd47 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java 1 file changed, 1 insertion(+), 20 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/37029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a6d29c7fbec822381b0ee33116b41ca574bcd47 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Update HostSetupNetworks flow to use isManagement

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Update HostSetupNetworks flow to use isManagement ...................................................................... webadmin: Update HostSetupNetworks flow to use isManagement Update Setup Host Networks flow and Host-Networks sub-tab logic to use isManagement indicator rather than DefaultManagementNetwork config value. Change-Id: I3bb6d8149d895a5834c5fb59e357a9acab7cb00d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 3 files changed, 12 insertions(+), 29 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bb6d8149d895a5834c5fb59e357a9acab7cb00d Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: update Linq.NetworkComparator

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: update Linq.NetworkComparator ...................................................................... webadmin: update Linq.NetworkComparator Update Linq.NetworkComparator to use isManagement (if possible) instead of DefaultManagementNetwork config value. Change-Id: Ib6d3c01b552c6a8034652e533d2bae7319cbd9fb Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java 4 files changed, 15 insertions(+), 13 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6d3c01b552c6a8034652e533d2bae7319cbd9fb Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: update "Edit network" flow with new mangement netw...

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: update "Edit network" flow with new mangement network logic ...................................................................... webadmin: update "Edit network" flow with new mangement network logic Update "Edit network" flow to use new IsManagementNetwork query. Change-Id: If53f73518214f9ac48affa4fba74750b047e25f9 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java 4 files changed, 51 insertions(+), 34 deletions(-) Approvals: Lior Vernia: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/37026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If53f73518214f9ac48affa4fba74750b047e25f9 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Delete dangling stopProgress

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Delete dangling stopProgress ...................................................................... webadmin: Delete dangling stopProgress Remained after removal of related calls recently. Change-Id: Iadaf8ed5facb9e83d32b3b724cfb04a2ac2176da Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadaf8ed5facb9e83d32b3b724cfb04a2ac2176da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 11 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2015