April 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Extract data from network entry once

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: engine: Extract data from network entry once ...................................................................... engine: Extract data from network entry once The same operations used to be performed for every interface linked to a network/bridge, where the data really only had to be extracted once. Change-Id: Ie0dda9426feba172ce54a467c89628a0328edbc8 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 38 insertions(+), 28 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0dda9426feba172ce54a467c89628a0328edbc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Extract common interface logic to single method

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: engine: Extract common interface logic to single method ...................................................................... engine: Extract common interface logic to single method The same code was duplicated across interfaces, bonds and VLANs, whereas it could be re-used. Change-Id: I495f36cea0a63a161ca4ae85fc08e67e718befa2 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 56 insertions(+), 70 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Lior Vernia: Verified -- To view, visit https://gerrit.ovirt.org/37078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I495f36cea0a63a161ca4ae85fc08e67e718befa2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: CinderVolumeDriver enum

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: CinderVolumeDriver enum ...................................................................... core: CinderVolumeDriver enum Added CinderVolumeDriver enum with RBD (Ceph's RADOS Block Devices) key. Change-Id: Ic7775461446af0a725c24fc66d882342d3b38ceb Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderVolumeDriver.java 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved Objections: oVirt Jenkins CI Server: Fails -- To view, visit https://gerrit.ovirt.org/39655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7775461446af0a725c24fc66d882342d3b38ceb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: introduce CloneSingleCinderDiskCommand

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: introduce CloneSingleCinderDiskCommand ...................................................................... core: introduce CloneSingleCinderDiskCommand Adding CloneSingleCinderDiskCommand and CloneSingleCinderDiskCommandCallback. Change-Id: I608ab9de6c4a79ea8bdf44e1547f72a30ab80db7 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 181 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I608ab9de6c4a79ea8bdf44e1547f72a30ab80db7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: adding cloneDisk to CinderBroker

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: adding cloneDisk to CinderBroker ...................................................................... core: adding cloneDisk to CinderBroker Adding 'cloneDisk' method to CinderBroker. Change-Id: I0de9529146ef02b63d0b61de1135f633389e47a2 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de9529146ef02b63d0b61de1135f633389e47a2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: api to invoke initializeConnection for Cinder disk

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: api to invoke initializeConnection for Cinder disk ...................................................................... core: api to invoke initializeConnection for Cinder disk Adding relevant method to OpenStackVolumeProviderProxy and CinderBroker to support invoking initializeConnection for a Cinder disk. Change-Id: Iffd087f6ff9c5fc1bbd658574b5c7c8e14ecdfc2 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39654 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffd087f6ff9c5fc1bbd658574b5c7c8e14ecdfc2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-reports[master]: packaging: setup: debug master.properties creation

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: debug master.properties creation ...................................................................... packaging: setup: debug master.properties creation Change-Id: I1202c521b4ff9a1ec115fdb9ad11759850e2a2f7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1202c521b4ff9a1ec115fdb9ad11759850e2a2f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-reports[master]: packging: setup: fix unset variable 'errors'

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packging: setup: fix unset variable 'errors' ...................................................................... packging: setup: fix unset variable 'errors' Fixes I6e1cd0ff49c2e37649263302dce0a1a44ee4bb53 Change-Id: I956d822895a87f4aae1bfc4edfa87e8c2071288c Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/reportsutil.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I956d822895a87f4aae1bfc4edfa87e8c2071288c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: groupHostsAndVms shouldn't be part of Cluster equals()

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: engine: groupHostsAndVms shouldn't be part of Cluster equals() ...................................................................... engine: groupHostsAndVms shouldn't be part of Cluster equals() Change-Id: I7b18d928ab7069ddab309c09708a368c68d138e0 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified Eli Mesika: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b18d928ab7069ddab309c09708a368c68d138e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: RSDL - report 'delete' on collections where exists

by oliel＠redhat.com

Ori Liel has submitted this change and it was merged. Change subject: restapi: RSDL - report 'delete' on collections where exists ...................................................................... restapi: RSDL - report 'delete' on collections where exists Currently RSDL does not report existing DELETE signatures on collection level (e.g: DELETE .../api/clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks) This patch enhances RSDL to be able to deal with such signatures. Bug-Url: http://bugzilla.redhat.com/1038663 Change-Id: I23461cb72df75766d1c09d2f9d979cfb0d8df38c Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23461cb72df75766d1c09d2f9d979cfb0d8df38c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

9 years, 8 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits April 2015