Change in ovirt-engine[ovirt-engine-3.5]: webadmin: "Advanced Parameters" panel disappear when choosin...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: "Advanced Parameters" panel disappear when choosing to use hosts provider
......................................................................
webadmin: "Advanced Parameters" panel disappear when choosing to use hosts provider
In addHost form, when clicking on "Advanced Parameters"
appears. When the panel is displayed and "using hosts
provider" is clicked, the advanced parameters panel
disappears .
Change-Id: If72a280cd584d309bdd0f3a0f135b0ce008b17d6
Bug-Url: https://bugzilla.redhat.com/1179703
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39841
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If72a280cd584d309bdd0f3a0f135b0ce008b17d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[master]: engine: Using HostDeviceDao.setVmIdOnHostDevice to update th...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Using HostDeviceDao.setVmIdOnHostDevice to update the vm_id of a vf
......................................................................
engine: Using HostDeviceDao.setVmIdOnHostDevice to update the vm_id of a vf
This procedure will update just the vm_id column of the specified device.
Change-Id: I87b4bd30e43168b8dccd8e2edc157fc681366cd3
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelperImpl.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelperImplTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java
M packaging/dbscripts/host_device_sp.sql
6 files changed, 69 insertions(+), 28 deletions(-)
Approvals:
Alona Kaplan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38888
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87b4bd30e43168b8dccd8e2edc157fc681366cd3
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[master]: core: Fix used matchers in GetManagementNetworkCandidatesQue...
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix used matchers in GetManagementNetworkCandidatesQueryTest
......................................................................
core: Fix used matchers in GetManagementNetworkCandidatesQueryTest
Replaces
assertThat(actual, org.hamcrest.Matchers.hasSize(1));
with
assertEquals(1, actual.size());
to be compatible with currently used JUnit.
Change-Id: I98dda7d879d123268ad1f02bfe9dece28a64523f
Bug-Url: https://bugzilla.redhat.com/1121327
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98dda7d879d123268ad1f02bfe9dece28a64523f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : Geo-rep JsonRpc refactored
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine : Geo-rep JsonRpc refactored
......................................................................
engine : Geo-rep JsonRpc refactored
This patch refactors JsonRpcVdsServer geo-rep in
accordance with merged vdsm patch.
Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40227
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb6354afa4e543fc6e3a8fe669f37ffaee400c53
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : Fixes geo-rep issues
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine : Fixes geo-rep issues
......................................................................
engine : Fixes geo-rep issues
This patch fixes the following issues:
1. Fixes the xml parsing logic in GlusterHostsPubKeyReturnForXmlRpc
for json mode.
2. hostname and username separated
3. When masterVolumeId was not set, use volumeId passed in parameter.
Change-Id: I925815c663be810cedb2cd7df81032d24ea8286c
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostsPubKeyReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java
3 files changed, 8 insertions(+), 1 deletion(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40226
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I925815c663be810cedb2cd7df81032d24ea8286c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Showing network sub-tabs in gluster only mode
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: Showing network sub-tabs in gluster only mode
......................................................................
webadmin: Showing network sub-tabs in gluster only mode
Changed to show only relevant sub-tabs in gluster only
mode.
Enabled New/Manage Networks in the Cluster Logical Networks
subtab
Change-Id: I14bb2307ef3bd57a6605b5daae8f6cda853eca0f
Bug-Url: https://bugzilla.redhat.com/1049994
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkProfileListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkTemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java
5 files changed, 29 insertions(+), 23 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40224
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14bb2307ef3bd57a6605b5daae8f6cda853eca0f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years
Change in ovirt-engine[master]: engine, webadmin: Add an indicator if geo-replication is enabled
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine,webadmin: Add an indicator if geo-replication is enabled
......................................................................
engine,webadmin: Add an indicator if geo-replication is enabled
Added an indicator column to Volume tab, to indicate
if a volume is a geo-replication master or slave
Change-Id: I28178b8ef03ea7cc83097cb99bc2d2be90061434
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/volume_georep_master.png
A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/volume_georep_slave.png
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeInfoCell.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeInfoColumn.java
M packaging/dbscripts/create_views.sql
11 files changed, 134 insertions(+), 1 deletion(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit https://gerrit.ovirt.org/38310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28178b8ef03ea7cc83097cb99bc2d2be90061434
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-node-plugin-vdsm[master]: persist: /etc/multipath/wwwids
by fabiand＠redhat.com
Fabian Deutsch has submitted this change and it was merged.
Change subject: persist: /etc/multipath/wwwids
......................................................................
persist: /etc/multipath/wwwids
Persist configured /etc/multipah/wwwids.
This change helps vdsm to keep the configured lun's intact during
reboots or upgrades.
Change-Id: I7f6b5a6b0bed6521503b972866d93a7da5cd28fe
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1191401
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40187
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com>
---
M hooks/Makefile.am
A hooks/on-boot/03-persist-multipath-wwids
A hooks/pre-upgrade/03-persist-multipath-wwids
M ovirt-node-plugin-vdsm.spec.in
4 files changed, 28 insertions(+), 0 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, approved
Douglas Schilling Landgraf: Verified
Nir Soffer: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/40187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f6b5a6b0bed6521503b972866d93a7da5cd28fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-hosted-engine-ha[master]: packaging: spec: cleanings
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: packaging: spec: cleanings
......................................................................
packaging: spec: cleanings
Change-Id: I6634f08d0403cd4c8036ed315d5ddc101cd340bd
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-ha.spec.in
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Martin Sivák: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39970
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6634f08d0403cd4c8036ed315d5ddc101cd340bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years
Change in ovirt-engine[master]: engine: Added username to geo-rep commands
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Added username to geo-rep commands
......................................................................
engine: Added username to geo-rep commands
To support non-root geo-rep session management
Change-Id: I3fcdc7c29abb88916eacc048f2708ea68540134a
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepConfigVdsParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionStatusVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/PauseGlusterVolumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/ResumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeGeoRepConfigDefaultVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeGeoRepConfigVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeGeoRepVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
22 files changed, 370 insertions(+), 141 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39485
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fcdc7c29abb88916eacc048f2708ea68540134a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years