April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix import-vm from export domain sub-tab
by ahadas＠redhat.com 22 Apr '15

22 Apr '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: fix import-vm from export domain sub-tab ...................................................................... webadmin: fix import-vm from export domain sub-tab Due to a class-cast exception, the popup that is presented after importing VMs that is triggered from export-domain sub-tab was not shown. This patch eliminated the exception and fixes that. Change-Id: I08656cf51d8a5c20639a67e90d0d742c3dcdd8e7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/40096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08656cf51d8a5c20639a67e90d0d742c3dcdd8e7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <matobet(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Show networks tab in gluster only mode
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Show networks tab in gluster only mode ...................................................................... webadmin: Show networks tab in gluster only mode The networks tab was earlier disabled in gluster only mode. But with the gluster network role feature, this is enabled again. Change-Id: I3864f8ebd41100124cb996463178f185f866118d Bug-Url: https://bugzilla.redhat.com/1049994 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3864f8ebd41100124cb996463178f185f866118d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Default de-activate volume snapshot after creation
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Default de-activate volume snapshot after creation ...................................................................... gluster: Default de-activate volume snapshot after creation The gluster volume snapshots should be in deactivated state after creation. Modified to mark the newly created volume snapshots as deactivated. Change-Id: I5c3efe787a979839456232331c673684c0184178 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c3efe787a979839456232331c673684c0184178 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Corrected a UI validation while volume snapshot cr...
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Corrected a UI validation while volume snapshot creation ...................................................................... webadmin: Corrected a UI validation while volume snapshot creation Change-Id: I8916803b86901e2ecd5b4d8ed208b8822135bf46 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8916803b86901e2ecd5b4d8ed208b8822135bf46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Fix DaysOfMonthSelector coverity scan defects
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin : Fix DaysOfMonthSelector coverity scan defects ...................................................................... webadmin : Fix DaysOfMonthSelector coverity scan defects This patch places a null check on the cellClicked to overcome the Null pointer dereferences issue reported by coverity scan. Change-Id: I8c1ba079ee40da217ef44a770849af468c8a226b Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DaysOfMonthSelector.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c1ba079ee40da217ef44a770849af468c8a226b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: Additional validations for volume snapshot create/s...
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: Additional validations for volume snapshot create/schedule ...................................................................... gluster: Additional validations for volume snapshot create/schedule Added additional validations while creation and scheduling of the gluster volume snapshots. Change-Id: I437344f106b9e998a8f9258ca836f91d39c7ad32 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 49 insertions(+), 10 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40114 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437344f106b9e998a8f9258ca836f91d39c7ad32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: Show timezone dropdown for all cases
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Show timezone dropdown for all cases ...................................................................... webadmin: Show timezone dropdown for all cases Modified the gluster volume snapshot scheduling dialog to show timezone dropdwon in all the valid recurrence type like - Minutely - Hourly - Daily - Weekly - Monthly Change-Id: Ic83e8d3a3d1505c09ab5f0d36c21b8ab1fa1d85d Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic83e8d3a3d1505c09ab5f0d36c21b8ab1fa1d85d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: UI for gluster volume snapshot creation
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: UI for gluster volume snapshot creation ...................................................................... webadmin: UI for gluster volume snapshot creation Introduced UI dialog for gluster volume snapshot creation and scheduling snapshots. Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotScheduleByVolumeIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeSnapshotCreatePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 17 files changed, 1,276 insertions(+), 4 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : DateTimeBox Widget
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin : DateTimeBox Widget ...................................................................... webadmin : DateTimeBox Widget This patch adds DateTimeBox Widget Change-Id: Ifc3834e66280a4812733b68d207b65f041bd3431 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/DateTimeBox.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelDateTimeBox.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelDateTimeBoxEditor.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css 4 files changed, 484 insertions(+), 0 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc3834e66280a4812733b68d207b65f041bd3431 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Peer probing with alternate addresses
by sabose＠redhat.com 22 Apr '15

22 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Peer probing with alternate addresses ...................................................................... engine: Peer probing with alternate addresses When another interface is marked as gluster network, the gluster cluster has to be made aware of this address using the "gluster peer probe" Adding the functionality to handle that Change-Id: I8fa407d6a525e73b89a79d063517798283b520fd Bug-Url: https://bugzilla.redhat.com/1049994 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServer.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterServerDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java M packaging/dbscripts/gluster_server_sp.sql A packaging/dbscripts/upgrade/03_05_1420_add_alternateprobed_gluster_server.sql 11 files changed, 233 insertions(+), 12 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fa407d6a525e73b89a79d063517798283b520fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0