Change in ovirt-engine[master]: restapi: Implicity add "async" and "grace_period.expiry" to ...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Implicity add "async" and "grace_period.expiry" to actions
......................................................................
restapi: Implicity add "async" and "grace_period.expiry" to actions
Currently the "async" and "grace_period.expiry" body parameters are
explicitly documented in the RSDL metadata file. But these parameters
are available for all actions, and missing from the documentation of
some of them. As a result the Python SDK doesn't document them
correctly, and the corresponding options aren't available in the CLI.
This patch changes the RESTAPI so that it will implicitly add these two
parameters to the RSDL for all actions.
Change-Id: I1fec7e64d0d2a33708038debd90bff17cba7b449
Bug-Url: https://bugzilla.redhat.com/1211588
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
2 files changed, 189 insertions(+), 117 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39834
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fec7e64d0d2a33708038debd90bff17cba7b449
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Make Bookmark entity a JPA entity
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Make Bookmark entity a JPA entity
......................................................................
core: Make Bookmark entity a JPA entity
Move Bookmark to JPA
Change-Id: I162f1c22d32b16732ed50a7f6378f8d3e765141a
Bug-Url: https://bugzilla.redhat.com/1159621
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/resources/META-INF/persistence.xml
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BookmarkDAOTest.java
M backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml
D packaging/dbscripts/bookmarks_sp.sql
7 files changed, 77 insertions(+), 273 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit https://gerrit.ovirt.org/33836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I162f1c22d32b16732ed50a7f6378f8d3e765141a
Gerrit-PatchSet: 64
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Add JPA Java infrastructure
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Add JPA Java infrastructure
......................................................................
core: Add JPA Java infrastructure
Create classes to assist in JPA development
Change-Id: Ide82bf8cc647426e37dc42a113867c52699c3f0b
Bug-Url: https://bugzilla.redhat.com/1159621
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/AbstractJpaDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/jpa/GuidUserType.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseHibernateDaoTestCase.java
A backend/manager/modules/dal/src/test/resources/META-INF/persistence.xml
M backend/manager/modules/dal/src/test/resources/test-beans.xml
5 files changed, 343 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit https://gerrit.ovirt.org/33835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ide82bf8cc647426e37dc42a113867c52699c3f0b
Gerrit-PatchSet: 71
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine-cli[master]: cli: Always generate the tarball when building RPMs
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Always generate the tarball when building RPMs
......................................................................
cli: Always generate the tarball when building RPMs
Currently when building a RPM the tarball is generated using the "git
archive" command and the HEAD tree. This means that changes that haven't
been locally commited aren't included in the result. In addition the
tarball is only generated if there were changes in the Makefile or the
.spec template, which has the same effect. To avoid these two issues
this patch changes the command used to build the tarball and also
changes the Makefile so that the tarball is always regenerated.
Change-Id: Iac7989eb69f7a3ec3447cc1cb729b76528b0d012
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M ovirt-engine-cli.spec.in
2 files changed, 34 insertions(+), 30 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39857
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac7989eb69f7a3ec3447cc1cb729b76528b0d012
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine-sdk-java[master]: sdk: Always generate the tarball when building RPMs
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Always generate the tarball when building RPMs
......................................................................
sdk: Always generate the tarball when building RPMs
Currently the tarball is only generated if there were changes in the Makefile
or the .spec template. This means that changes to the SDK itself will not be
included in the resulting RPMs unless they are locally commited, which makes
things very confusing for developers. This patc changes the Makefile so that
the tarball is always regenerated.
Change-Id: I20cfe74995e9aac87a342ddc39577d85873313ba
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M sdk/Makefile
2 files changed, 18 insertions(+), 17 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39856
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20cfe74995e9aac87a342ddc39577d85873313ba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: el7 allows 4TiB max memory, enable for 3.6+ clusters
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: el7 allows 4TiB max memory, enable for 3.6+ clusters
......................................................................
core: el7 allows 4TiB max memory, enable for 3.6+ clusters
With this patch we will allow the usage of up to 4 TiB per VM
Change-Id: Idb09797879553b38fd11517294d33dfa4d0246b3
Bug-Url: https://bugzilla.redhat.com/1201327
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Vinzenz Feenstra: Verified
Omer Frenkel: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/38670
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb09797879553b38fd11517294d33dfa4d0246b3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine-sdk[master]: sdk: Always generate the tarball when building RPMs
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Always generate the tarball when building RPMs
......................................................................
sdk: Always generate the tarball when building RPMs
Currently when building a RPM the tarball is generated using the "git
archive" command and the HEAD tree. This means that changes that haven't
been locally commited aren't included in the result. In addition the
tarball is only generated if there were changes in the Makefile or the
.spec template, which has the same effect. To avoid these two issues
this patch changes the command used to build the tarball and also
changes the Makefile so that the tarball is always regenerated.
Change-Id: Ib16253e18f39ff4bafef1fcdebe21e8f456b4b23
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M ovirt-engine-sdk-python.spec.in
2 files changed, 34 insertions(+), 29 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39854
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib16253e18f39ff4bafef1fcdebe21e8f456b4b23
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine-sdk[master]: codegen: Document installation of "generateDS.py"
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Document installation of "generateDS.py"
......................................................................
codegen: Document installation of "generateDS.py"
The code generator needs the "generateDS.py" tool to work correctly, but
this isn't documented, which causes problems for people that doesn't use
the generator frequently. This patch documents this requirement in the
README.md file.
Change-Id: I8dbb48962c476658c9141f5fee3fe7c9fd6e3c82
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M README.md
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dbb48962c476658c9141f5fee3fe7c9fd6e3c82
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: Use ToStringBuilder in gluster classes
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Use ToStringBuilder in gluster classes
......................................................................
core: Use ToStringBuilder in gluster classes
Refactor existing toString() methods to use ToStringBuilder in gluster
classes.
Change-Id: I16e44629e49616da481a387cd89dad3549d2c22e
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTask.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSnapshotConfig.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateBrickVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeSnapshotVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActivateSnapshotVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeSnapshotActionVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeSnapshotSetConfigVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeVDSParameters.java
8 files changed, 48 insertions(+), 35 deletions(-)
Approvals:
Martin Peřina: Verified
Shubhendu Tripathi: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16e44629e49616da481a387cd89dad3549d2c22e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: webadmin: prevent class cast exception on import vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: prevent class cast exception on import vm
......................................................................
webadmin: prevent class cast exception on import vm
This patch is a workaround for a problem with StorageDisksListModel that
cause class-cast exception: in ImportVmFromExportDomainModel we set the
items in StorageDisksListModel to StorageDomains. However, in
StorageDisksListModel#updateActionAvailability we expect the
getSelectedItems method to return DiskImages.
Probably something went wrong in b13dc92e where StorageDisksListModel
was introduced in ImportVmFromExportDomainModel. This patch is only a
workaround that eliminates the error by clearing the storage-domain
before loading new ones so the previous selected item will be null and
we won't get that exception. Proper solution should be introduced
separately.
Change-Id: I28f9eee614ba5e6eeef9f8aa88337aab9a90a2f9
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/40056
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28f9eee614ba5e6eeef9f8aa88337aab9a90a2f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months