Change in ovirt-engine[master]: core: Remove overridden getUsername() in Start/Stop/RestartV...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove overridden getUsername() in Start/Stop/RestartVdsCommand
......................................................................
core: Remove overridden getUsername() in Start/Stop/RestartVdsCommand
Removes overridden getUsername() method, which handles empty username
when commands were executed from Quartz job. This customization is no
longer necessary as it was fixed globally for all Quartz executed
commands in patch Ibc7bae0be74d3a5f7c5b7cfc4f3827a1dcfda8b7.
Change-Id: Id828addd0eb388a2ce37d3d9ead8c89e5b5506a9
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java
2 files changed, 0 insertions(+), 18 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39840
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id828addd0eb388a2ce37d3d9ead8c89e5b5506a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Move all PM related commands into bll.pm
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Move all PM related commands into bll.pm
......................................................................
core: Move all PM related commands into bll.pm
1. Moves following commands into bll.pm subpackage:
FenceVdsBaseCommand
RestartVdsCommand
SshSoftFencingCommand
StartVdsCommand
StopVdsCommand
VdsKdumpDetectionCommand
VdsNotRespondingTreatmentCommand
2. Adds bll.pm subpackage to packages which contain commands
3. Fixes StartVdsCommandTest
Change-Id: I6651532ae9e753f1d4b1425b99a39f0562a61937
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/StartVdsCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/StopVdsCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsKdumpDetectionCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java
R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java
11 files changed, 39 insertions(+), 17 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6651532ae9e753f1d4b1425b99a39f0562a61937
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Remove RESTART action from FenceActionType
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove RESTART action from FenceActionType
......................................................................
core: Remove RESTART action from FenceActionType
Removes unused RESTART action from FenceActionType, because restart
action is executed as complex action:
1. Execute STOP if host is not powered off
2. Wait for host to become powered off using STATUS
3. Execute START
4. Wait for host to become powered on using STATUS
Change-Id: Id12f162682c172a2fddf617e95dc8f1754ab73db
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceActionType.java
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39838
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id12f162682c172a2fddf617e95dc8f1754ab73db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Remove unneeded FenceVdsVDSCommandParameters instance ...
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove unneeded FenceVdsVDSCommandParameters instance initialization
......................................................................
core: Remove unneeded FenceVdsVDSCommandParameters instance initialization
Removes unneeded initialization of FenceVdsVDSCommandParameters
instance. This private constructor is not called and exists only due to
checkstyle.
Change-Id: Ia812f5cba873826baea3276e185af385f267cf40
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FenceVdsVDSCommandParameters.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39837
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia812f5cba873826baea3276e185af385f267cf40
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: core: Remove action attribute from FenceVdsActionParameters
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove action attribute from FenceVdsActionParameters
......................................................................
core: Remove action attribute from FenceVdsActionParameters
Removes FenceActionType action attribute from FenceVdsActionParameters,
because it doesn't have any meaning in commands which are using
FenceVdsActionParameters.
Change-Id: I50f9a7064b9977c127b5c443af87a8f20a802070
Bug-Url: https://bugzilla.redhat.com/1182510
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsPowerDownCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
10 files changed, 31 insertions(+), 57 deletions(-)
Approvals:
Ori Liel: Looks good to me, but someone else must approve
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39836
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50f9a7064b9977c127b5c443af87a8f20a802070
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-host-deploy[master]: build: minor cleanup
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: build: minor cleanup
......................................................................
build: minor cleanup
Change-Id: Ibb961bb9e763c029c39f969ba63b4fe2a4913758
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/interface-3/Makefile.am
M src/java/Makefile.am
M src/ovirt_host_deploy/Makefile.am
M src/plugins/ovirt-host-deploy/Makefile.am
4 files changed, 16 insertions(+), 13 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39953
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb961bb9e763c029c39f969ba63b4fe2a4913758
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-host-deploy[master]: core: use more generic executor
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: use more generic executor
......................................................................
core: use more generic executor
will be handy when more than one operation is supported.
Change-Id: I04637f1b9a0699df7713e5bdfcf24fa58e453293
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M configure.ac
R src/bin/executor.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39952
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04637f1b9a0699df7713e5bdfcf24fa58e453293
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: Fix db upgrage scripts numbering check
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix db upgrage scripts numbering check
......................................................................
core: Fix db upgrage scripts numbering check
Fixes issue in db upgrade scripts numbering check to prevent duplicate
scripts with same number.
Previous version of the script allows duplicates.
Change-Id: I4e48052b4e65e9e1cccd8be82acf0b4bcd59f7c4
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M build/dbscripts-duplicate_upgrade_scripts.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Jakub Niedermertl: Verified
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, approved
Vinzenz Feenstra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e48052b4e65e9e1cccd8be82acf0b4bcd59f7c4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-log-collector[master]: packaging: spec: align to latest Fedora Guidelines
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: align to latest Fedora Guidelines
......................................................................
packaging: spec: align to latest Fedora Guidelines
Aligned with https://fedoraproject.org/wiki/Packaging:Python
Latest revision as of 15:58, 22 October 2014
Change-Id: Ic48b01d9739b4951390cfa98cd175184c9f3f2b2
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-log-collector.spec.in
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic48b01d9739b4951390cfa98cd175184c9f3f2b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: Fix db upgrage scripts numbering check
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Fix db upgrage scripts numbering check
......................................................................
core: Fix db upgrage scripts numbering check
Fixes issue in db upgrade scripts numbering check to prevent duplicate
scripts with same number.
Change-Id: Ibec57eac9cc30a0aa776f064b50d5eccf1626e07
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M build/dbscripts-duplicate_upgrade_scripts.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39942
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec57eac9cc30a0aa776f064b50d5eccf1626e07
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months