April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix problematic db script name
by masayag＠redhat.com 16 Apr '15

16 Apr '15

Moti Asayag has submitted this change and it was merged. Change subject: core: fix problematic db script name ...................................................................... core: fix problematic db script name Change-Id: Ica9389d8ed55d4f8109ed7c8b0cd3ac50a2e89e7 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- R packaging/dbscripts/upgrade/03_06_1240_revert_03061210_add_vm_host_device_commands.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica9389d8ed55d4f8109ed7c8b0cd3ac50a2e89e7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: revert add wrong values in action_version_map table
by ofrenkel＠redhat.com 16 Apr '15

16 Apr '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: revert add wrong values in action_version_map table ...................................................................... core: revert add wrong values in action_version_map table revert part of the following commit as it adds not-yet-existing values to the db, making the engine throw exception on startup commit b08518abe4221adb73b0bde70c5a570c1d8290f8 dal: Add HostDev passthrough support #2 Change-Id: I72f62b0a6492dfd28bfebe479888fa405ac5d501 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1240_revert_03_06_1210_add_vm_host_device_commands.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72f62b0a6492dfd28bfebe479888fa405ac5d501 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Remove redudant parameter types from RSDL metadata
by juan.hernandez＠redhat.com 16 Apr '15

16 Apr '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove redudant parameter types from RSDL metadata ...................................................................... restapi: Remove redudant parameter types from RSDL metadata The "resetemulatedmachine" operation explicitly documents the "Content-Type" and "Correlation-Id" headers, but these are already implicitly added to all operations. The net result is that they appear twice in the generated RSDL document, and this induces a duplicated parameter in the code generated for the SDKs. This patch removes the headers from the RSDL metadata file. Change-Id: I6c382b88300622213b20e72912614da65fdb7747 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Eldan Shachar: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c382b88300622213b20e72912614da65fdb7747 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: change how warning on imported vm is stored
by ahadas＠redhat.com 16 Apr '15

16 Apr '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: change how warning on imported vm is stored ...................................................................... webadmin: change how warning on imported vm is stored Until now, each VM that we wanted to present a warning for in the import dialog was stored in a list of VMs (called disksToConvert..) and then a warning was presented for a VM if it was in that list. This patch changes this approach: instead of having list of VMs, we store the warning in the VM's import model which makes more sense from the design point-of-view, especially as we also need to show other warnings/errors (will be implemented in a different patch) Change-Id: I3b636821f264b63d6ad0b8c9fd7592cb6e10d41c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmData.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/IsProblematicImportVmColumn.java 5 files changed, 25 insertions(+), 48 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/39878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b636821f264b63d6ad0b8c9fd7592cb6e10d41c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: QuotaStorageDependent removal in ExtendImageSizeCommand.
by amureini＠redhat.com 16 Apr '15

16 Apr '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: QuotaStorageDependent removal in ExtendImageSizeCommand. ...................................................................... core: QuotaStorageDependent removal in ExtendImageSizeCommand. ExtendImageSizeCommand currently implements QuotaStorageDependent which deals with quota consumptions. The command is being called in UpdateVmDiskCommand in case the disk size is extended, but never reaches the actual consume part in the code as it is constructed as an unquota-dependent command. Moreover, UpdateDiskCommand deals with any case of quota consumption (introduced in https://gerrit.ovirt.org/#/c/39330/, BZ: https://bugzilla.redhat.com/1203262 ) So dealing with that is not needed in that command. Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExtendImageSizeCommand.java 1 file changed, 1 insertion(+), 23 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I940ab5817cb09e4f6275cbda713ecc37a4bd74fc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: add the proper message for not auth terminate session
by oourfali＠redhat.com 16 Apr '15

16 Apr '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: add the proper message for not auth terminate session ...................................................................... engine: add the proper message for not auth terminate session Add proper message when a non-authorized user tries to terminate a user session. Change-Id: I4f4cdf735b3ce19c1ff8a2d13f083639a8f0445a Bug-Url: https://bugzilla.redhat.com/1025796 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f4cdf735b3ce19c1ff8a2d13f083639a8f0445a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix import/general sub-tab
by ahadas＠redhat.com 16 Apr '15

16 Apr '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: fix import/general sub-tab ...................................................................... webadmin: fix import/general sub-tab The general sub-tab in the import dialog was broken by recent changes in the frontend - it didn't present the VM information. This patch fixes the sub-tab that shows general information on VM in the import dialog. I changed the sub-tab to be separate component that doesn't inherit the VM general sub-tab in the virtual machines tab because they differ in: 1. Layout - in the sub-tab which is presented in the import dialog, we don't need to have the alerts tab since warnings/errors will be shown differently 2. Items - the presented fields are different and over-time they are expected to be changed in a way that they will be even more different 3. Configurability - in the import sub-tab some fields are editable. currently only the name and the operating system but there should be more, while in the general sub-tab nothing is editable Change-Id: Ied6e9619ba6f539e42600d3650adff2b9272ac9e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmGeneralSubTabView.ui.xml 7 files changed, 776 insertions(+), 31 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/39586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied6e9619ba6f539e42600d3650adff2b9272ac9e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add a getActiveSnapshot method to VmHandler
by ahadas＠redhat.com 16 Apr '15

16 Apr '15

Arik Hadas has submitted this change and it was merged. Change subject: core: add a getActiveSnapshot method to VmHandler ...................................................................... core: add a getActiveSnapshot method to VmHandler The method getActiveSnapshot can be useful in other places other than ImportVmCommand. This patch adds it to VmHandler so others can also use it. Change-Id: Id4aa4df1117d0993845e18a95a4e6c0f75738990 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 2 files changed, 22 insertions(+), 5 deletions(-) Approvals: Idan Shaby: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4aa4df1117d0993845e18a95a4e6c0f75738990 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: move set of OVIRT_LOGGING_PROPERTIES to designated sc...
by sbonazzo＠redhat.com 16 Apr '15

16 Apr '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools: move set of OVIRT_LOGGING_PROPERTIES to designated scripts ...................................................................... tools: move set of OVIRT_LOGGING_PROPERTIES to designated scripts this will enable different logging properties to use per different tools and sub packages. Change-Id: Id83f9c4e2ee76a84e1e02e5b338a8e451caf38d5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/bin/engine-config.sh M packaging/bin/engine-manage-domains.sh M packaging/bin/engine-prolog.sh.in 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/39886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id83f9c4e2ee76a84e1e02e5b338a8e451caf38d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: [RFE]Backup Awareness - Handler
by emesika＠redhat.com 16 Apr '15

16 Apr '15

Eli Mesika has submitted this change and it was merged. Change subject: core: [RFE]Backup Awareness - Handler ...................................................................... core: [RFE]Backup Awareness - Handler This patch adds the EngineBackupAwarenessManager handler and the quartz job for checking each X hours for a freah backup and raise alert if not found. Change-Id: I8567ae314a3d612d8e3d4dd948394b65789ac670 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1188127 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EngineBackupAwarenessManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java 2 files changed, 96 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8567ae314a3d612d8e3d4dd948394b65789ac670 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0