Change in ovirt-engine[master]: restapi: Remove empty URL parameter list specifications
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove empty URL parameter list specifications
......................................................................
restapi: Remove empty URL parameter list specifications
This patch removes from the RSDL metadata file the specicifications of
URL parameters that are empty, as that is the default.
Change-Id: I58ce08fd12a82fe673fda5cf2bdcbef0f94ef8ee
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 0 insertions(+), 336 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39466
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58ce08fd12a82fe673fda5cf2bdcbef0f94ef8ee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: restapi: Implicitly add Expect header to RSDL
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Implicitly add Expect header to RSDL
......................................................................
restapi: Implicitly add Expect header to RSDL
Currently the Expect header is documented in the RSDL manually, but it
fact it is used by all the operations that can potentially add a new
entity, so it is better to implicity add it to all these operations and
remove it from the metadata file.
Change-Id: I1820196257329bcefa1b279f53e3a4fd9aea615a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
2 files changed, 27 insertions(+), 168 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39462
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1820196257329bcefa1b279f53e3a4fd9aea615a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-host-deploy[master]: tune: Set tuned profile based on environment variable.
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: tune: Set tuned profile based on environment variable.
......................................................................
tune: Set tuned profile based on environment variable.
This patch adds a new environment variable, which will be
used to set the tuned profile. This is done to have the
flexibility of specifing the tuned profile that has to be
set on the node.
Change-Id: Ib2a6d69f52c4cbbc03cb14c7cb719f43846ef526
Bug-Url: https://bugzilla.redhat.com/1209418
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
---
M ChangeLog
M src/ovirt_host_deploy/constants.py
M src/plugins/ovirt-host-deploy/tune/tuned.py
3 files changed, 19 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, approved
Darshan N: Verified
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39599
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2a6d69f52c4cbbc03cb14c7cb719f43846ef526
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: restapi: Implicitly add Content-Type to RSDL
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Implicitly add Content-Type to RSDL
......................................................................
restapi: Implicitly add Content-Type to RSDL
Currently the Content-Type header is documented in the RSDL manually,
but it fact it is used by all the operations that can potentially send a
request body, so it is better to implicity add it to all these
operations and remove it from the metadata file.
Change-Id: I5ebe12467922fb5c6ee407865fcae72e55646b6d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlBuilder.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
2 files changed, 25 insertions(+), 327 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39461
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ebe12467922fb5c6ee407865fcae72e55646b6d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[master]: engine: fix mocking in QueriesCommandBaseTest
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: fix mocking in QueriesCommandBaseTest
......................................................................
engine: fix mocking in QueriesCommandBaseTest
Add proper mocking for QueriesCommandBase usage of SessionDataContainer.
That fixes NPEs in the test.
Change-Id: I1378780f6ef666000e837a135fbafecc82f661cd
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java
2 files changed, 27 insertions(+), 13 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
Objections:
oVirt Jenkins CI Server: Fails
--
To view, visit https://gerrit.ovirt.org/39603
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1378780f6ef666000e837a135fbafecc82f661cd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : Geo-rep config Vds Commands
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine : Geo-rep config Vds Commands
......................................................................
engine : Geo-rep config Vds Commands
Geo-rep config Vds Commands.
Change-Id: I558ed18b94faae9d4b824c9de1fedda25ffc3f09
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeGeoRepConfigVdsParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepConfigListVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeConfigListXmlRpc.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeGeoRepConfigDefaultVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeGeoRepConfigVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
14 files changed, 237 insertions(+), 0 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39659
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I558ed18b94faae9d4b824c9de1fedda25ffc3f09
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine : Refactoring in accordance with vdsm patches
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine : Refactoring in accordance with vdsm patches
......................................................................
engine : Refactoring in accordance with vdsm patches
This patch does the following :
1. The geo-rep engine patches were merged before the corresponding
patches and hence at merge time, contained the exception codes and
api names as the vdsm exposed at that time.
Now, that the vdsm patches have been merged, this patch
refactors the engine side accordingly.
2. StartGlusterVolumeGeoRepCommand was modifying the status of geo-rep
session in db on success. But, it is observed that the session on gluster
side takes a while to change state to ACTIVE untill then it stays as
INITIALISING and hence this patch removes the state change code and allows
the geo-rep sync job to detect state change.
Change-Id: I702d6c62f576cf2a49437fcf37155290d8580588
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GeoRepSessionStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/PauseGlusterVolumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/ResumeGeoRepSessionVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StartGlusterVolumeGeoRepVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
17 files changed, 58 insertions(+), 47 deletions(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39639
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I702d6c62f576cf2a49437fcf37155290d8580588
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Fix backport of Correct VDS geo-rep status
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Fix backport of Correct VDS geo-rep status
......................................................................
engine: Fix backport of Correct VDS geo-rep status
the branch uses the old logger and needed to fix
the log command
Missed adding change to commit
Change-Id: I69cbc9a0ec02cc49b214dd07c29f8cf02d155834
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sahina Bose: Verified; Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/39638
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69cbc9a0ec02cc49b214dd07c29f8cf02d155834
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: webadmin: addHost form leaves json checkbox locked when swit...
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: addHost form leaves json checkbox locked when switching between clusters
......................................................................
webadmin: addHost form leaves json checkbox locked when switching between clusters
When switching between clusters that don't support json
protocol to ones that support the protocol the JSON
checkbox is left disabled.
Change-Id: I29f5de9f20ccf12382da99117c1f4fd922650b1b
Bug-Url: https://bugzilla.redhat.com/1179689
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Ravi Nori: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39615
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29f5de9f20ccf12382da99117c1f4fd922650b1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: fix add brick validation issue
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: webadmin: fix add brick validation issue
......................................................................
webadmin: fix add brick validation issue
Fix the add brick validation issue for replicate and
stripe volume.
Bug-Url: https://bugzilla.redhat.com/1143828
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
Change-Id: I005c32f2d030c35ec43149ee4f4aeaa7e731ee3c
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sahina Bose: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/39635
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I005c32f2d030c35ec43149ee4f4aeaa7e731ee3c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months