April 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: add help tags for add/edit volume options.
by sabose＠redhat.com 08 Apr '15

08 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin: add help tags for add/edit volume options. ...................................................................... webadmin: add help tags for add/edit volume options. Adding help tags for Add and Edit Gluster Volume option dialogs. Bug-Url: https://bugzilla.redhat.com/1177883 Change-Id: Ic95e11ecb0d38be13d5aba3a4e64fdff586eef05 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/39634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic95e11ecb0d38be13d5aba3a4e64fdff586eef05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Correct VDS geo-rep status
by sabose＠redhat.com 08 Apr '15

08 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Correct VDS geo-rep status ...................................................................... engine: Correct VDS geo-rep status As vdsm patch went through refactoring, fixing the engine code to reflect this - http://gerrit.ovirt.org/18414 Change-Id: I7449d6a786f3bae55752eb25f36f6210448cdd83 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionListVDSCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepSessionStatusVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeGeoRepStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetailForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 16 files changed, 142 insertions(+), 133 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7449d6a786f3bae55752eb25f36f6210448cdd83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : Geo-Replication action confirmation popup
by sabose＠redhat.com 08 Apr '15

08 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin : Geo-Replication action confirmation popup ...................................................................... webadmin : Geo-Replication action confirmation popup Geo-Replication action confirmation popup Change-Id: Ib9bf8f15ca617de36b149b17b6ded7a81e52ab4b Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepActionConfirmationModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/GlusterVolumeGeoRepActionConfirmPopUpViewPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GeoRepActionConfirmPopUpView.ui.xml 6 files changed, 305 insertions(+), 0 deletions(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9bf8f15ca617de36b149b17b6ded7a81e52ab4b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin : fix for geo-rep sub tab
by sabose＠redhat.com 08 Apr '15

08 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: webadmin : fix for geo-rep sub tab ...................................................................... webadmin : fix for geo-rep sub tab Geo-rep sub tab missed an entry in volume module. So, entries for sub-tab weren't appearing. This patch fixes it. Change-Id: I44092d5e94fef9745af7af1758bfccbba6d82587 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: anmolbabu: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44092d5e94fef9745af7af1758bfccbba6d82587 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Fixed refresh command for geo-rep sessions
by sabose＠redhat.com 07 Apr '15

07 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Fixed refresh command for geo-rep sessions ...................................................................... engine: Fixed refresh command for geo-rep sessions Fixed refresh command to extend from GlusterVolumeCommandBase so that the cluster id is properly set. Change-Id: I4ec7f2aa03164371b777fbd8631e77be77dd5d72 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGeoRepSessionsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ec7f2aa03164371b777fbd8631e77be77dd5d72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: BLL queries for volume snapshots list and count
by sabose＠redhat.com 07 Apr '15

07 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: BLL queries for volume snapshots list and count ...................................................................... gluster: BLL queries for volume snapshots list and count Introduced BLL queries for volume snapshots list and its total count for a given volume. Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotsByVolumeIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/gluster_volume_snapshot_sp.sql A packaging/dbscripts/upgrade/03_05_1290_add_snapshot_count_to_gluster_volume.sql 12 files changed, 161 insertions(+), 8 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cd2a52c9bd10946b8702d833d6f8f0ebb3f848 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: core: Fixed error with scheduler test
by sabose＠redhat.com 07 Apr '15

07 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: core: Fixed error with scheduler test ...................................................................... core: Fixed error with scheduler test Externalized the db properties that are used for the scheduler tests Change-Id: Ic35c178c041aed37235510c6452dae21f2cd1585 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/scheduler/pom.xml A backend/manager/modules/scheduler/src/test/filters/pgsql.properties M backend/manager/modules/scheduler/src/test/resources/ovirt-db-scheduler-test.properties 3 files changed, 27 insertions(+), 9 deletions(-) Approvals: Shubhendu Tripathi: Verified Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic35c178c041aed37235510c6452dae21f2cd1585 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: DB persistent quartz scheduler
by sabose＠redhat.com 07 Apr '15

07 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: DB persistent quartz scheduler ...................................................................... engine: DB persistent quartz scheduler Adding support for persisting quartz scheduler jobs in the database. Added a PersistentJobWrapper to handle jobs persisted in the db. The jobdata map has the instance class name instead of the instance itself to deal with serialization issues. Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/scheduler/pom.xml A backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/FixedDelayJobListener.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java A backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/PersistentJobWrapper.java A backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java A backend/manager/modules/scheduler/src/main/resources/ovirt-db-scheduler.properties A backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImplTest.java A backend/manager/modules/scheduler/src/test/resources/ovirt-db-scheduler-test.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EngineEJBUtilsStrategy.java A packaging/dbscripts/upgrade/03_05_1280_insert_quartz_tables.sql M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.xml.in 15 files changed, 1,014 insertions(+), 356 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: engine: Modified fk_validator to handle composite foreign keys
by sabose＠redhat.com 07 Apr '15

07 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Modified fk_validator to handle composite foreign keys ...................................................................... engine: Modified fk_validator to handle composite foreign keys In case of composite foreign keys, the table_col and fk_col in the select references cursor was empty, which causes the validation to error out. for instance, if fk is on a composite primary key like this "(sched_name, trigger_name, trigger_group)" the regular expression should consider "," and space. Also,in the query to fetch violations, the inner select clause for composite keys should return multiple columns as opposed to single column - hence trimming "()" Change-Id: Ie4210537c6ef7ce7f89bd73be9e44178b6b8d43a Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/setup/dbutils/fkvalidator_sp.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4210537c6ef7ce7f89bd73be9e44178b6b8d43a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5-gluster]: gluster: DAO for volume snapshot config maintenance
by sabose＠redhat.com 07 Apr '15

07 Apr '15

Sahina Bose has submitted this change and it was merged. Change subject: gluster: DAO for volume snapshot config maintenance ...................................................................... gluster: DAO for volume snapshot config maintenance Added DAO for gluster volume snapshot configuration maintenance Change-Id: Ic0854984eed0f72226aa732a651be50bf8dda9fb Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotConfigDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotConfigDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotConfigDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/gluster_volume_snapshot_sp.sql M packaging/dbscripts/upgrade/03_05_1260_add_gluster_volume_snapshot_tables.sql 8 files changed, 403 insertions(+), 1 deletion(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0854984eed0f72226aa732a651be50bf8dda9fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0