Change in ovirt-engine[master]: database: Define admin roles to import/export domains
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: database: Define admin roles to import/export domains
......................................................................
database: Define admin roles to import/export domains
Created two new roles: VmImporterExporter and TemplateImporterExporter and
assigned ActionGroup.IMPORT_EXPORT_VM to these roles.
Change-Id: I61837fdc2fe2eae50b486dad5fbfeeac42c472f0
Bug-Url: https://bugzilla.redhat.com/1108153
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_06_1620_add_domain_import_export_permissions_for_admins.sql
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved; Passed CI tests
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/41055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61837fdc2fe2eae50b486dad5fbfeeac42c472f0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: Remove duplicate validations on disk hot plug
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Remove duplicate validations on disk hot plug
......................................................................
webadmin: Remove duplicate validations on disk hot plug
This patch removes duplicate validations in VmDiskListModel and fixes
the use of them.
Change-Id: Ibb10010317808cfa75b9988cb437b6112dc48933
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
2 files changed, 5 insertions(+), 13 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/42609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb10010317808cfa75b9988cb437b6112dc48933
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: CinderDisk - disable snapshots for shareable
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: CinderDisk - disable snapshots for shareable
......................................................................
core: CinderDisk - disable snapshots for shareable
For consistency with images, 'isAllowSnapshot' should
return false for shareable disks.
Change-Id: Ib619a8878f9ae53167aaaf0e2233bbec88ef7be7
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/CinderDisk.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Daniel Erez: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42615
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib619a8878f9ae53167aaaf0e2233bbec88ef7be7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: fix issues found by Coverity
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: fix issues found by Coverity
......................................................................
fix issues found by Coverity
Fixes the following issue (and in addition similiar one that from some
reason is not reported by is exactly the same)
*** CID 1306702: Null pointer dereferences (NULL_RETURNS)
> /frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainAdditionalStatusColumn.java:
> 43 in
> org.ovirt.engine.ui.webadmin.widget.table.column.StorageDomainAdditionalStatusColumn.getSafeHtmlStringMap(org.ovirt.engine.core.common.businessentities.StorageDomain)()
> 37
> 38 private Map<SafeHtml, String>
> getSafeHtmlStringMap(StorageDomain
> object) {
> 39 StorageDomain storageDomain = getEntityObject(object);
> 40 Map<SafeHtml, String> imagesToText = new
> LinkedHashMap<>();
> 41
> 42 if (storageDomain.getExternalStatus() !=
> ExternalStatus.Ok) {
> >>> CID 1306702: Null pointer dereferences (NULL_RETURNS)
> >>> Assigning: "statusImage" = null return value from
> >>> "getStatusImage".
> 43 ImageResource statusImage =
> getStatusImage(storageDomain.getExternalStatus());
> 44 imagesToText.put(getImageSafeHtml(statusImage),
> 45 constants.ExternalStatus() +
> storageDomain.getExternalStatus().name());
> 46 }
> 47 return imagesToText;
> 48 }
Change-Id: I500e4680dbae310cc3027cedff1fc54df353ece2
Signed-off-by: emesika <emesika(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/StorageDomainAdditionalStatusColumn.java
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/42595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I500e4680dbae310cc3027cedff1fc54df353ece2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: fix detach of floating Cinder disk
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: fix detach of floating Cinder disk
......................................................................
core: fix detach of floating Cinder disk
DetachDiskFromVmCommand:
check 'isSupportsSnapshots' in executeVmCommand.
Change-Id: I700a667017a340389f37c70a4e60e4a2bc0453e3
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I700a667017a340389f37c70a4e60e4a2bc0453e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: fix attach of floating Cinder disk
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: fix attach of floating Cinder disk
......................................................................
core: fix attach of floating Cinder disk
AttachDiskToVmCommand:
check 'isSupportsSnapshots' in updateDiskVmSnapshotId method.
Change-Id: I067d3ef13d8c9ecbf30063495f142473e094b21b
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I067d3ef13d8c9ecbf30063495f142473e094b21b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: engine: Adding unique(vds_id, name) constraint to vds_interface
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine: Adding unique(vds_id, name) constraint to vds_interface
......................................................................
engine: Adding unique(vds_id, name) constraint to vds_interface
and removing duplicate entiries in case there were any.
Due to a bug that was already fixed, more than one GetCaps could be
executed simultaneously. In some scenarios of the race the same nic
could be created more than once.
This patch cleans the duplicate entities from vds_interface table
(leaves just the last updated entry).
The building proccess of the network_attachments assumes there are no such
duplicates in vds_interface,
so the duplicates should be cleaned up from vds_interface prior building
the network_attachments table.
In case the user already run the add_network_attachment upgrade script-
1. If succeeded- it means his vdS_interface table doesn't have duplicates,
so the is no need for clean up.
2. If failed- it means the add_network_attachment upgrade script is not
marked as a script the already have run. So now, when running the setup,
the duplicates clean will occur before building the network_attachments
and everything should work fine.
Change-Id: I2ae0c11afb751ec28b8f71e70959546ba306444f
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M packaging/dbscripts/upgrade/03_06_1460_add_network_attachment.sql
A packaging/dbscripts/upgrade/03_06_1610_unique_vds_id_name_vds_interface.sql
2 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved; Passed CI tests
Alona Kaplan: Verified
--
To view, visit https://gerrit.ovirt.org/42429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ae0c11afb751ec28b8f71e70959546ba306444f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: prevent a race on getAllStats with events
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: prevent a race on getAllStats with events
......................................................................
core: prevent a race on getAllStats with events
046b36e7 introduced a timestamp for vm-dynamic updates. This patch fixes
the timestamp that is saved on getAllVmStats with events similarly.
Change-Id: I90ee66124564756f82b93f762c631c518444f678
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/42470
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90ee66124564756f82b93f762c631c518444f678
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: core: move cached info about last event to vm-manager
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: move cached info about last event to vm-manager
......................................................................
core: move cached info about last event to vm-manager
The caching of the timestamp of the last event we got per-VM is moved to
VmManager instead of being in VdsManager:
1. It is a value per-VM, thus VmManager is more appropriate for that
than having it in VdsManager
2. When saving the host we got the last event from with the timestamp we
don't need to reset the timestamp when the VM is moving between hosts
(in the previous state it looks like we missed the case of rerun for
RunVm for example)
Change-Id: I9ee4470d43e3d4690343a0fdc23df2e1fdddbf8e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
4 files changed, 33 insertions(+), 34 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/42469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ee4470d43e3d4690343a0fdc23df2e1fdddbf8e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months
Change in ovirt-engine[master]: webadmin: fix initial cluster on import from vmware
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: fix initial cluster on import from vmware
......................................................................
webadmin: fix initial cluster on import from vmware
The initial selection of cluster on the dialog for import VM from VMware
is now set correctly.
Change-Id: I4e37be962779fc7a962a72339d225b45ee2880b5
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/42550
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e37be962779fc7a962a72339d225b45ee2880b5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 4 months