June 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Make constants static
by oourfali＠redhat.com 18 Jun '15

18 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Make constants static ...................................................................... core: Make constants static Changed the final Sring constants in bstractVdsNetworkInterfacePredicateTest to be static as per the Java convention for constants. Change-Id: Id6dd76721da1c6585ce0fba965fcd254a2f68a09 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/network/predicate/AbstractVdsNetworkInterfacePredicateTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6dd76721da1c6585ce0fba965fcd254a2f68a09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix base type of GraphicsConsoles
by juan.hernandez＠redhat.com 18 Jun '15

18 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix base type of GraphicsConsoles ...................................................................... restapi: Fix base type of GraphicsConsoles The base type of the complex type "GraphicsConsoles" is "BaseResource", but it should be "BaseResources" as it is a collection. This doesn't cause any real issue in the engine, but it induces a type error in the Java SDK. Change-Id: Icf01d5d2b25736a5fd7e0c03e79b21047471113b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf01d5d2b25736a5fd7e0c03e79b21047471113b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Accept 0 and 1 for boolean values
by juan.hernandez＠redhat.com 18 Jun '15

18 Jun '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Accept 0 and 1 for boolean values ...................................................................... restapi: Accept 0 and 1 for boolean values According to section section 3.2.2.1 of the XML specification the values 0 and 1 should be accepted for boolean values in addition to "false" and "true": 3.2.2 boolean, 3.2.2.1 Lexical representation http://www.w3.org/TR/xmlschema-2/#boolean In a previous change intended to validate the values of booleans the RESTAPI was changed to accept only "false" and "true": restapi: Validate boolean values https://gerrit.ovirt.org/27925 This causes a regression for users that are sending 0 and 1. This patch fixes that so that 0 and 1 will also be accepted. Change-Id: I4a5005fdafa1e45e5ad17178a5ac897e6234f45b Bug-Url: https://bugzilla.redhat.com/1230842 Related: https://bugzilla.redhat.com/1063876 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/BooleanParser.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a5005fdafa1e45e5ad17178a5ac897e6234f45b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: YAMLised the publish_ovirt_rpms_nightly_master job
by dcaroest＠redhat.com 18 Jun '15

18 Jun '15

David Caro has submitted this change and it was merged. Change subject: YAMLised the publish_ovirt_rpms_nightly_master job ...................................................................... YAMLised the publish_ovirt_rpms_nightly_master job The job produced by the YAML is called: ovirt_master_publish-rpms_nightly Change-Id: I861f278f95c99358a3d0f044efb4e138c141c0f7 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- A jobs/confs/yaml/builders/copy-create-job-artifact.yaml A jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 187 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me Barak Korren: Verified Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/42487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I861f278f95c99358a3d0f044efb4e138c141c0f7 Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in jenkins[master]: Convert the number of days to integer before parsing. Do not...
by eedri＠redhat.com 18 Jun '15

18 Jun '15

Eyal Edri has submitted this change and it was merged. Change subject: Convert the number of days to integer before parsing. Do not open connection to mailserver in dry-run mode. Input the list of projects as comma separated values. ...................................................................... Convert the number of days to integer before parsing. Do not open connection to mailserver in dry-run mode. Input the list of projects as comma separated values. Change-Id: Ia78a78de0cebb60be53b6c97ae272fef8c24c46c Signed-off-by: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com> --- M scripts/alert_old_patches.py 1 file changed, 13 insertions(+), 8 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/42445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia78a78de0cebb60be53b6c97ae272fef8c24c46c Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add support of refresh LUN size in UI
by tnisan＠redhat.com 18 Jun '15

18 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add support of refresh LUN size in UI ...................................................................... webadmin: Add support of refresh LUN size in UI Add a new column in "Edit Domain" of iSCSI Domain. The column is available on ly in "LUNs->Targets" view. Add a new cell renderer of type toggle button. Feature page: http://www.ovirt.org/Features/LUN_Resize Change-Id: I84c83f07f53d286f62fb6104f62fbfb37feb2b42 Relates-To: https://bugzilla.redhat.com/609689 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractToggleButtonCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLunAvailableSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LunModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 211 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Looks good to me, but someone else must approve; Passed CI tests Daniel Erez: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/41398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c83f07f53d286f62fb6104f62fbfb37feb2b42 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add support for Refresh LUNs size
by tnisan＠redhat.com 18 Jun '15

18 Jun '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Add support for Refresh LUNs size ...................................................................... engine: Add support for Refresh LUNs size Add command RefreshLunsSizeCommand to support resize of LUNs. input : a list of LUN GUIDs output : status of operation action : - Send to all hosts in Data Center a "GetDevice" command with the specific devices. - If all hosts return the same size, send to SPM a "resize PV" command. - Retrieve SD info and update DB with new sizes. Add support to refresh LUNs via REST API of update Storage Domain. Change-Id: I6c5c6d59087736466ee5e7eb0c77ee9282199c62 Relates-To: https://bugzilla.redhat.com/609689 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LUNs.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDeviceListVDSCommandParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResizeStorageDomainPVVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResourceTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResizeStorageDomainPVVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ResizeStorageDomainPVMapReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 36 files changed, 777 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/39318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c5c6d59087736466ee5e7eb0c77ee9282199c62 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: uutils: modify argument type naming in ArgumentParser
by oourfali＠redhat.com 18 Jun '15

18 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: uutils: modify argument type naming in ArgumentParser ...................................................................... uutils: modify argument type naming in ArgumentParser to be as close to getopt_long we are renaming has_argument to required_argument Change-Id: I9aa42d4d9932576abf2c93490e556132e3f1e2a4 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/arguments.properties M backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/logger/arguments.properties M backend/manager/modules/builtin-extensions/src/main/resources/org/ovirt/engine/extensions/aaa/builtin/tools/arguments.properties M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/Argument.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java 5 files changed, 32 insertions(+), 32 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ondra Machacek: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42528 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9aa42d4d9932576abf2c93490e556132e3f1e2a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Ignore DC-ID for Blank Template
by oourfali＠redhat.com 18 Jun '15

18 Jun '15

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Ignore DC-ID for Blank Template ...................................................................... engine: Ignore DC-ID for Blank Template Blank Templates may be associated with a Data-Center, or not. This patch fixes a bug, where if a blank template is not associated with a data-center, getting it by name fails. Change-Id: I40604d098f88e9b470fec2ca668cd19904cf6ea7 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M packaging/dbscripts/vm_templates_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, but someone else must approve; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42527 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40604d098f88e9b470fec2ca668cd19904cf6ea7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Make regular user owner of VMs he created
by ofrenkel＠redhat.com 18 Jun '15

18 Jun '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Make regular user owner of VMs he created ...................................................................... core: Make regular user owner of VMs he created If regular user has permission to create a VM and does this through webadmin UI (having also ReadOnlyAdmin role) or REST API with Filter: false, he doesn't get ownership for this VM by default. This is OK for admin users, but non-admin users will effectively loose access to their VMs. To fix this, additional check is made for webadmin UI users and REST API with Filter: false users, checking if they have permission to manage the VM being created. If not, this permission is added for them. Change-Id: I7e814ab024ceed63e3ec7fce82ca574fa5be1c8b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121144 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved; Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e814ab024ceed63e3ec7fce82ca574fa5be1c8b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0