Change in ovirt-engine[master]: webadmin: Move up the Gluster alert
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Move up the Gluster alert
......................................................................
webadmin: Move up the Gluster alert
Leave a small gap after the alert for a cleaner look.
Change-Id: Ia9205cdd6b97ec3af02fc723325121adcf67d426
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml
1 file changed, 11 insertions(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/42732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9205cdd6b97ec3af02fc723325121adcf67d426
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in ovirt-engine[master]: webadmin: Changed/added path examples for storage
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Changed/added path examples for storage
......................................................................
webadmin: Changed/added path examples for storage
Changed the exapmle for NFS, added one for POSIX and Gluster.
Removed explanations to all the above as this should be clear what
"Path" means.
Also aligned them with the Path editor above.
Change-Id: I29c69ed540c3c606be4a80edd72a783ccd1dae34
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml
7 files changed, 26 insertions(+), 26 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/42523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29c69ed540c3c606be4a80edd72a783ccd1dae34
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in ovirt-engine[master]: webadmin: Storage popup view Changes
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Storage popup view Changes
......................................................................
webadmin: Storage popup view Changes
Changes to how the New/Edit/Import Storage dialog looks.
* Removed green area.
* Created grey area.
* Format moved to advanced parameters.
* Domain Function and Storage Type were separated.
Change-Id: Id8ed6d6818976ef76267b5fd8a3ca19c83fcda06
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml
6 files changed, 170 insertions(+), 122 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/42432
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8ed6d6818976ef76267b5fd8a3ca19c83fcda06
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Fix error message, adding vm with disk profile, wrong ...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix error message, adding vm with disk profile, wrong storage.
......................................................................
core: Fix error message, adding vm with disk profile, wrong storage.
1. Get the name of the storage domain provided in the request.
2. Add the id of the disk profile to the error message.
Disk profile may have same name but in different storages.
Change-Id: Id7e39081f2c409513d865473a19e9e8fea71aa4c
Bug-Url: https://bugzilla.redhat.com/1220127
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 15 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7e39081f2c409513d865473a19e9e8fea71aa4c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in ovirt-engine-sdk[sdk_3.5]: automation: add automation scripts
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: automation: add automation scripts
......................................................................
automation: add automation scripts
Added automation scripts as per
http://www.ovirt.org/CI/Build_and_test_standards
Change-Id: Ice348d6a168428c8ec605e11ddb8af7012e12991
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A automation/README.md
A automation/build-artifacts.req
A automation/build-artifacts.sh
A automation/check-merged.req
A automation/check-merged.sh
A automation/check-patch.req
A automation/check-patch.sh
7 files changed, 37 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me
Juan Hernandez: Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43199
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice348d6a168428c8ec605e11ddb8af7012e12991
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.5
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in ovirt-engine[master]: core: add debug logs for vm status events
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add debug logs for vm status events
......................................................................
core: add debug logs for vm status events
while debugging issues around vm-status events, some logs were added for
easier debugging:
* full event data, including the host that handles the event.
* subscriber id of host on subscription.
Change-Id: I4d792709766794dcb395ac25b8ba5faa8a7e7ab4
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d792709766794dcb395ac25b8ba5faa8a7e7ab4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in jenkins[master]: Added new needed option
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Added new needed option
......................................................................
Added new needed option
Change-Id: Ifcecf5921b761588e26f468d13f094ff8a3caca4
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_stable_to_3.4/setup.file.otopi
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge
David Caro: Verified; Ready for merge
--
To view, visit https://gerrit.ovirt.org/43185
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcecf5921b761588e26f468d13f094ff8a3caca4
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
8 years, 10 months
Change in ovirt-engine[master]: aaa: cleanup SessionDataContainer
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa: cleanup SessionDataContainer
......................................................................
aaa: cleanup SessionDataContainer
remove public from non public methods.
remove unused methods.
remove unused SetDataOnSession command.
modify GetValueBySession query which is actually a non generic hack to
GetDbUserBySession as this is actually what it does.
Change-Id: Ia102443336f73959a9e1f2942cf1dc4225683ada
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserBySessionQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SetDataOnSessionCommand.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetDataOnSessionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetValueBySessionQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/invocation/CurrentFilter.java
9 files changed, 13 insertions(+), 109 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Ori Liel: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia102443336f73959a9e1f2942cf1dc4225683ada
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in ovirt-engine[master]: webadmin: add CEPH version to hosts general sub-tab
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: add CEPH version to hosts general sub-tab
......................................................................
webadmin: add CEPH version to hosts general sub-tab
Adding 'CEPH version' text-box to 'Hosts -> General -> Software'.
Change-Id: Ibb0e136b67b560f1fe4bcfe71ffebad384e00585
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java
3 files changed, 20 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb0e136b67b560f1fe4bcfe71ffebad384e00585
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months
Change in ovirt-engine[master]: core: disable RemoveStorageDomain for Cinder
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: disable RemoveStorageDomain for Cinder
......................................................................
core: disable RemoveStorageDomain for Cinder
Similarly to Glance domains, RemoveStorageDomainCommand should
be blocked for Cinder domains (since it's handled by RemoveProviderCommand).
Change-Id: I4470c80cc50a350bfaf5026fecd9f302de052930
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43125
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4470c80cc50a350bfaf5026fecd9f302de052930
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
8 years, 10 months