Change in ovirt-engine[master]: core: Remove redundant animal-sniffer ignores
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove redundant animal-sniffer ignores
......................................................................
core: Remove redundant animal-sniffer ignores
The usages of sun.security.krb5.Config and sun.misc.Signal were removed
by commits 28856e3bf57cd49aa604dd7990f2c84581d3aa1e and
ebb486cf8a7db2cd0e724a6b1322aa916f3babe4 respectively. Since they are no
longer present in the codebase, the configuration to ignore them from
the animal sniffer maven plugin can safely be removed.
Change-Id: Ie2aa528ff3687ce80d716c4f33b7ba01609ce43c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M pom.xml
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/45152
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2aa528ff3687ce80d716c4f33b7ba01609ce43c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Fixed Quota description size limits
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Fixed Quota description size limits
......................................................................
core: Fixed Quota description size limits
When trying to copy a quota an error messsage was thrown saying that
the size limit should be between 1 and 250. This error message was the
result of not giving the right limits for the description of the quota.
An empty description is 0 character long. Therefore, the limit was
changed and now it is [0-250].
Change-Id: I6acad4fe290552dcdbd73bcd77e12c65f924d3c2
Bug-Url: https://bugzilla.redhat.com/1245664
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dudi Maroshi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45101
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6acad4fe290552dcdbd73bcd77e12c65f924d3c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: send guest cpus in numa node, not host cpus
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: send guest cpus in numa node, not host cpus
......................................................................
core: send guest cpus in numa node, not host cpus
currently the default vm numa node list the host numa cpu ids.
this is wrong and it should specify the guest cpu ids.
Change-Id: I48e08f45d2fe6fc417d2deb813ae67bbc11ea484
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254560
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit https://gerrit.ovirt.org/45113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48e08f45d2fe6fc417d2deb813ae67bbc11ea484
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Upgrade animal-sniffer to 1.14
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Upgrade animal-sniffer to 1.14
......................................................................
core: Upgrade animal-sniffer to 1.14
Upgraded animal-sniffer-maven-plugin to version 1.14 in order to support
being run with Java8.
Change-Id: Idb43d84a70f6b136791da4e0dcbbc97cbbd6e392
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/45149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb43d84a70f6b136791da4e0dcbbc97cbbd6e392
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: removed "New" from Guide-Me dialogs title
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: removed "New" from Guide-Me dialogs title
......................................................................
webadmin: removed "New" from Guide-Me dialogs title
"Guide Me" dialogs are currently titled "New XXX - Guide Me" (e.g. "New
Data-Center - Guide Me".
The "New" is unnecessary, and may even be incorrect in case the "Guide
Me" dialog is opened manually by the user for an already existing item,
rather than automatically by the system for a (truly) new item.
Other than that, removing the "New" from the dialog title will also keep
the title more compact, which would eliminate the title truncation in
non-English locales.
This patch removes the "New" from the Guide-Me dialogs.
Change-Id: I5df4581716986f0fd88862f838cc28d4dfdc12d2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1255824
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Einav Cohen: Verified
--
To view, visit https://gerrit.ovirt.org/45199
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5df4581716986f0fd88862f838cc28d4dfdc12d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Fix, retrieve dedicatedHostList on new VmNumaNode resu...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Fix, retrieve dedicatedHostList on new VmNumaNode result NPE
......................................................................
core: Fix, retrieve dedicatedHostList on new VmNumaNode result NPE
The dedicatedHostList is passed to VmNumaNodeCommand in parameters.
Retrieving the VM from parent command result in NPE.
getVm() returns null, because it query on vms view.
The VM is not registered in vms view until it saves its vm_statistics
record and vm_dynamic record as well.
The best practice is to pass and read parameters.
This bug broke the REST api as well.
Change-Id: I4b63a76d9b7e40077dd39605d3aabb0a54b82dcf
Bug-Url: http://bugzilla.redhat.com/1254665
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
Tomer Saban: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b63a76d9b7e40077dd39605d3aabb0a54b82dcf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: restapi: missing validation for cloneVmFromSnapshot
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: missing validation for cloneVmFromSnapshot
......................................................................
restapi: missing validation for cloneVmFromSnapshot
snapshot.id was not validated to be present.
Change-Id: I6276794a0566e376c14f5d21c9634dfb37f95bf6
Bug-Url: https://bugzilla.redhat.com/1238273
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/45218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6276794a0566e376c14f5d21c9634dfb37f95bf6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: CDA msg when removing a template's disk without specif...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: CDA msg when removing a template's disk without specifing domain.
......................................................................
core: CDA msg when removing a template's disk without specifing domain.
Deleting a template's disk must be performed with the disk's storage
domain, as deleting a template's disk is enabled only if this disk has
copies on other domains.
Hence, a storage domain must be provided when calling RemoveDiskCommand
with a template's disk.
This patch adds that condition into RemoveDiskCommand's CDA with a
proper message.
Bug-Url: https://bugzilla.redhat.com/1229212
Change-Id: Id5f0c1bda25b5fbadbf153bfcb84c78950216e66
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 25 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/45220
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5f0c1bda25b5fbadbf153bfcb84c78950216e66
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: Test added for Template's disk removal in RemoveDiskCo...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Test added for Template's disk removal in RemoveDiskCommandTest.
......................................................................
core: Test added for Template's disk removal in RemoveDiskCommandTest.
A missing test added to verify correctness in removing a template's
disk.
Bug-Url: https://bugzilla.redhat.com/1229212
Change-Id: Ib6fe61061f7e1e0dc0c46ad889743dd3a1fdd43d
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
2 files changed, 34 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/45219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6fe61061f7e1e0dc0c46ad889743dd3a1fdd43d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: Avoid too many IDE or sPAPR VSCSI devices
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Avoid too many IDE or sPAPR VSCSI devices
......................................................................
core: Avoid too many IDE or sPAPR VSCSI devices
If there are any payload devices or cloud-init is enabled, it is
possible to exceed the number of allowed sPAPR VSCSI (in ppc64) or IDE
(in x86-64) devices by having the virtual CD, the payload device and
a large number of disks in these interfaces.
This patch warns the user if that is the case and prevents the VM from
running.
Change-Id: Ief86ea10237c931490b96affaa2f97e32d617c3b
Bug-Url: https://bugzilla.redhat.com/1076488
Signed-off-by: Shahar Havivi<shavivi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/architecture/HasMaximumNumberOfDisks.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 81 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45222
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief86ea10237c931490b96affaa2f97e32d617c3b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month