Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Host Hardware hba device layout
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Host Hardware hba device layout
......................................................................
webadmin: Host Hardware hba device layout
- Due to the FormPanel layout changes the HBA panels were
not getting enough space. This patch fixes that.
Change-Id: I67a76196640b22c81002eaf8f446d270ef67aa7c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252018
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralHardwareView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralHardwareView.ui.xml
2 files changed, 22 insertions(+), 17 deletions(-)
Approvals:
Alexander Wels: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67a76196640b22c81002eaf8f446d270ef67aa7c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: frontend: Fix NPE in TemplateListModel
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix NPE in TemplateListModel
......................................................................
frontend: Fix NPE in TemplateListModel
The initForemanProviders() method was not being called from
TemplateListModel#createVmFromTemplate(). Moved the call to common
setupNewVmModel() method that is being called from both create new VM flows.
Change-Id: If508220ddfba6e3045ca50a9d0a171e9426efb30
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1256005
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/45255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If508220ddfba6e3045ca50a9d0a171e9426efb30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: HAClient: allow overriding broker connection parameters
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: HAClient: allow overriding broker connection parameters
......................................................................
HAClient: allow overriding broker connection parameters
Change-Id: I24278a918b887e95ace1d494879c2c0144466675
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252796
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/client/client.py
M ovirt_hosted_engine_ha/lib/brokerlink.py
2 files changed, 9 insertions(+), 7 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45267
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24278a918b887e95ace1d494879c2c0144466675
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: database: getNonCountableQutoaVmStatuses union all
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: database: getNonCountableQutoaVmStatuses union all
......................................................................
database: getNonCountableQutoaVmStatuses union all
getNonCountableQutoaVmStatuses() returns a hard coded set of integers.
Since there are no possible duplicates in this data, there's no reason
to use union where using union all may offer a (very slight) performance
benefit.
Change-Id: Iea5b79343de03574fdfccb41f6888e0c347cd251
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/dbscripts/create_functions.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea5b79343de03574fdfccb41f6888e0c347cd251
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Support update of OVF_DATA for all DC versions.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support update of OVF_DATA for all DC versions.
......................................................................
core: Support update of OVF_DATA for all DC versions.
Support update of VMs' and Tempaltes' OVF_DATA that contain disks
which reside on Storage Domains maintained in a 3.4 DC and below.
Change-Id: Ia603224b03126eed722280cb7225ce14aef1bf91
Bug-Url: https://bugzilla.redhat.com/1172609
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStoragePoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStoragePoolCommandTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProcessOvfUpdateForStoragePoolParameters.java
5 files changed, 47 insertions(+), 15 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/45158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia603224b03126eed722280cb7225ce14aef1bf91
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in jenkins[master]: Adding vdsm check-patch standard build job
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Adding vdsm check-patch standard build job
......................................................................
Adding vdsm check-patch standard build job
Change-Id: I737249044cce6935c53b5064c41eb23ddc067420
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
A jobs/confs/projects/vdsm/vdsm_standard.yaml
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
David Caro: Verified; Looks good to me; Ready for merge
Francesco Romani: Looks good to me
--
To view, visit https://gerrit.ovirt.org/42477
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I737249044cce6935c53b5064c41eb23ddc067420
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
9 years, 1 month
Change in ovirt-engine[master]: restapi: allow new VM with no dedicated host in migration po...
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: restapi: allow new VM with no dedicated host in migration policy
......................................................................
restapi: allow new VM with no dedicated host in migration policy
Fix regression error.
When new VM is created with migration policy.
Allow empty host element.
Validate host element only if there is host element with id or
with name.
Change-Id: I5fbc644cfeade93846c4c0ef6190f65f77ab8951
Bug-Url: http://bugzilla.redhat.com/1249521
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45128
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fbc644cfeade93846c4c0ef6190f65f77ab8951
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: frontend: Fix NPE in TemplateListModel
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Fix NPE in TemplateListModel
......................................................................
frontend: Fix NPE in TemplateListModel
The initForemanProviders() method was not being called from
TemplateListModel#createVmFromTemplate(). Moved the call to common
setupNewVmModel() method that is being called from both create new VM flows.
Change-Id: If508220ddfba6e3045ca50a9d0a171e9426efb30
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1256005
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/45253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If508220ddfba6e3045ca50a9d0a171e9426efb30
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: aaa: Add options dialog to configure connect automatically
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: aaa: Add options dialog to configure connect automatically
......................................................................
aaa: Add options dialog to configure connect automatically
Add options dialog to configure connect automatically
in User portal
Change-Id: I29efdfda74da3ee509097be3178e9740b0dd6e64
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UserProfileParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserProfile.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EditOptionsModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/OptionsModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UiCommonModule.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/ConnectAutomaticallyProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginFormPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginFormView.ui.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/OptionsPopupPresenterWidget.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.ui.xml
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/OptionsPopupView.java
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/OptionsPopupView.ui.xml
A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/OptionsProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java
A packaging/dbscripts/upgrade/03_06_1790_add_vm_auto_login_column_to_user_profiles_table.sql
M packaging/dbscripts/user_profiles_sp.sql
27 files changed, 412 insertions(+), 123 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Ravi Nori: Verified
Alexander Wels: Looks good to me, approved
Moti Asayag: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44362
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29efdfda74da3ee509097be3178e9740b0dd6e64
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: restapi: rest part for HostNetworkQos
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: restapi: rest part for HostNetworkQos
......................................................................
restapi: rest part for HostNetworkQos
added outbound_average_linkshare, outbound_average_upperlimit and
outbound_average_realtime qos options to QoS element in api.xsd and
returned where appropriate
Bug-Url: https://bugzilla.redhat.com/1249654
Change-Id: I8a799768d0c621937079e48fccf751f5e6c7de10
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosTypeMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapperTest.java
9 files changed, 105 insertions(+), 39 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/43986
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a799768d0c621937079e48fccf751f5e6c7de10
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month