Change in ovirt-engine[ovirt-engine-3.6]: restapi: freeze_filesystems and thaw_filesystems actions
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: freeze_filesystems and thaw_filesystems actions
......................................................................
restapi: freeze_filesystems and thaw_filesystems actions
Exposing new actions at VM resource:
freezefilesystems and thawfilesystems
Freezing and thawing are used internally in the backend as part of the
live snapshot flow (for Cinder disks). These actions should be exposed to
the user for manual invocation if needed (see more details at [1-3]).
[1] http://wiki.libvirt.org/page/Qemu_guest_agent
[2] http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSFreeze
[3] http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainFSThaw
Change-Id: I80299644f4d19c5e771dd0f15c1284779b2fa498
Bug-Url: https://bugzilla.redhat.com/1240636
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
4 files changed, 68 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Ori Liel: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/44480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80299644f4d19c5e771dd0f15c1284779b2fa498
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: restapi: set storageDomainId only when available on VmDisksR...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: set storageDomainId only when available on VmDisksResource
......................................................................
restapi: set storageDomainId only when available on VmDisksResource
BackendVmDisksResource -> getAddParameters:
set storageDomainId only when available to allow auto-select
of a storage domain on 'AddDiskCommand -> getStorageDomainId() ->
getDisksStorageDomainId()'. The behaviour is needed for backwards
compatibility of MSD (multiple storage domains) feature.
Change-Id: I2857350bafad327a1e76b848165969368f4213df
Bug-Url: https://bugzilla.redhat.com/1220824
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Ori Liel: Looks good to me, approved
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/44479
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2857350bafad327a1e76b848165969368f4213df
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: edit disk dialog - disable storage type buttons
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: edit disk dialog - disable storage type buttons
......................................................................
webadmin: edit disk dialog - disable storage type buttons
Disable disk storage type radio buttons on edit disk dialog.
Change-Id: Ie361fc9563756d2f6a3b7b6e10d8a8087844278b
Bug-Url: https://bugzilla.redhat.com/1225914
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/44478
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie361fc9563756d2f6a3b7b6e10d8a8087844278b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: remove Storage Type from edit disk dialog
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: remove Storage Type from edit disk dialog
......................................................................
webadmin: remove Storage Type from edit disk dialog
LUN storage type (FCP/ISCSI) is not persisted in DB,
hence, we can't display it correctly in edit disk dialog.
Therefore, removing the select-box for now to avoid confusion.
Change-Id: I2f1af80977dd1be9ec380a30842f44cf6c5a223d
Bug-Url: https://bugzilla.redhat.com/1243463
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/44477
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f1af80977dd1be9ec380a30842f44cf6c5a223d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-hosted-engine-setup[master]: Directly use vdscli to connectStorageServer
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Directly use vdscli to connectStorageServer
......................................................................
Directly use vdscli to connectStorageServer
- vdsClient is no loger well supported
- we have no reverse dep. between ha-agent and setup
see also: https://gerrit.ovirt.org/#/c/44306/
Change-Id: Ib11f6afad0ab8541d39b101306475afd78094ca1
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/bin/hosted-engine.in
M src/ovirt_hosted_engine_setup/Makefile.am
A src/ovirt_hosted_engine_setup/connect_storage_server.py
3 files changed, 35 insertions(+), 35 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44348
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib11f6afad0ab8541d39b101306475afd78094ca1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[master]: webadmin: rename ova representation
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: rename ova representation
......................................................................
webadmin: rename ova representation
OVA as a source for import VM was shown as "Appliance (OVA)".
This patch changes it to "Virtual Appliance (OVA)".
Change-Id: Ib84d2562920a92334c5e9198754b634ce414c13a
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44608
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib84d2562920a92334c5e9198754b634ce414c13a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-hosted-engine-ha[master]: Directly use vdscli to connectStorageServer
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Directly use vdscli to connectStorageServer
......................................................................
Directly use vdscli to connectStorageServer
- vdsClient is no loger well supported
- we have no reverse dep. between ha-agent and setup
Change-Id: I9eeb4af82d77ebeb6808606b0cded08be0d7ee0c
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1190071
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/client/client.py
M ovirt_hosted_engine_ha/env/config.py
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/lib/Makefile.am
A ovirt_hosted_engine_ha/lib/image.py
A ovirt_hosted_engine_ha/lib/storage_server.py
7 files changed, 332 insertions(+), 32 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44306
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9eeb4af82d77ebeb6808606b0cded08be0d7ee0c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: db: remove unused field from images_storage_domain_view
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: db: remove unused field from images_storage_domain_view
......................................................................
db: remove unused field from images_storage_domain_view
The field contains_unregistered_entities in images_storage_domain_view
is never used, so it (and its related JOIN) can be removed from the
view.
Change-Id: Icaeab8a653c8da74534f987cc68fbe3c214f943a
Related-To: https://bugzilla.redhat.com/1247144
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/44584
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaeab8a653c8da74534f987cc68fbe3c214f943a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: db: remove storage_domain_static_view
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: db: remove storage_domain_static_view
......................................................................
db: remove storage_domain_static_view
storage_domain_static_view is a complex view that is barely utilized.
Removing the view should cause queries that use it to perform better.
Change-Id: Ibc14c3648f7b9ca3d2d45dded9fafce5aa852172
Related-To: https://bugzilla.redhat.com/1247144
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/storages_san_sp.sql
M packaging/dbscripts/storages_sp.sql
3 files changed, 20 insertions(+), 44 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/44583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc14c3648f7b9ca3d2d45dded9fafce5aa852172
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: errata backend enhancements
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: errata backend enhancements
......................................................................
engine: errata backend enhancements
* add VM errata counts query (GetErrataCountsForVmQuery)
* renamed some enum values to be clearer
* tweaked some English error messages
Change-Id: I03e92d4936d57227c56ae782598fce22ab3a40e0
Bug-Url: https://bugzilla.redhat.com/1202083
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataCountsForVmQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetErrataForSystemQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/SystemProviderFinder.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetErrataCountsForHostQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 114 insertions(+), 11 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/44580
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03e92d4936d57227c56ae782598fce22ab3a40e0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 5 months