August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: foreman/katello dropdown
by oourfali＠redhat.com 10 Aug '15

10 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: foreman/katello dropdown ...................................................................... webadmin: foreman/katello dropdown - Added the ability to change the foreman dropdown for hosts and VMs. - Fixed VM new/edit dialog height, so everything in the general tab fits on the screen. Change-Id: I7a8def823b49d4a45add3c2e12f2614392e06801 Bug-Url: https://bugzilla.redhat.com/1202083 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 8 files changed, 29 insertions(+), 10 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8def823b49d4a45add3c2e12f2614392e06801 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: db: create domains_with_unregistered_entities_view
by tnisan＠redhat.com 10 Aug '15

10 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: db: create domains_with_unregistered_entities_view ...................................................................... db: create domains_with_unregistered_entities_view A few view creation scripts use the same sub queries. Thus moving the common code to create a view makes more sense. Change-Id: I0adc14a3ac084b1ec1705327c0a78c4e2c14ef79 Related-To: https://bugzilla.redhat.com/1247144 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 22 insertions(+), 24 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/44582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0adc14a3ac084b1ec1705327c0a78c4e2c14ef79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: fix cloud-init password hover text
by shavivi＠redhat.com 10 Aug '15

10 Aug '15

Shahar Havivi has submitted this change and it was merged. Change subject: ui: fix cloud-init password hover text ...................................................................... ui: fix cloud-init password hover text Removing the 'root' from the test since a regular user can be created via cloud init. Change-Id: Ic922d4f39784c348f53a923ad77fd831fba5acbf Bug-Url: https://bugzilla.redhat.com/1248838 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic922d4f39784c348f53a923ad77fd831fba5acbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: prevent an exception when loading vm from vmware
by ahadas＠redhat.com 10 Aug '15

10 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: prevent an exception when loading vm from vmware ...................................................................... webadmin: prevent an exception when loading vm from vmware This patch fixed NPE that was thrown when VMs from VMware were loaded. Note that in that case there are no snapshot so the copy-collapse configuration is not needed and thus this code can be removed. Change-Id: I150a0b34fc2333bda58612bdcf4b212158f79485 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/44607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I150a0b34fc2333bda58612bdcf4b212158f79485 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: set origin type for imported vm from vmware
by ahadas＠redhat.com 10 Aug '15

10 Aug '15

Arik Hadas has submitted this change and it was merged. Change subject: core: set origin type for imported vm from vmware ...................................................................... core: set origin type for imported vm from vmware The only external provider for VMs is currently VMware, thus it is safe to set the origin type in the query for now. Change-Id: I629df153e228ce3b64263a15219591b3103f85be Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmsFromExternalProviderVDSCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/44605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I629df153e228ce3b64263a15219591b3103f85be Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Make GlusterSyncJob lazy initialized
by alkaplan＠redhat.com 10 Aug '15

10 Aug '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Make GlusterSyncJob lazy initialized ...................................................................... engine: Make GlusterSyncJob lazy initialized Make GlusterSyncJob lazy initialized and by that fix the related tests. Change-Id: Ifbdb581b9a1662bd513363cd960a20fe1be9d525 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java 3 files changed, 29 insertions(+), 20 deletions(-) Approvals: Alona Kaplan: Passed CI tests Sahina Bose: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/44604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbdb581b9a1662bd513363cd960a20fe1be9d525 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: display Disk Snapshots sub-tab for Cinder domains
by tnisan＠redhat.com 10 Aug '15

10 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: display Disk Snapshots sub-tab for Cinder domains ...................................................................... webadmin: display Disk Snapshots sub-tab for Cinder domains Display 'Disk Snapshots' sub-tab (under Storage main-tab) for Cinder domains. Change-Id: I44753507fa0464c867f63fb97fcf0cff96f246c2 Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/44476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44753507fa0464c867f63fb97fcf0cff96f246c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: RemoveDiskSnapshots - support Cinder disks
by tnisan＠redhat.com 10 Aug '15

10 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshots - support Cinder disks ...................................................................... core: RemoveDiskSnapshots - support Cinder disks Support removal of Cinder disk snapshots using RemoveDiskSnapshotsCommand. Change-Id: Ia5f3d97ef91791a454191ddcc134ec78a3471981 Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllCinderSnapshotDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmCinderDisksParameters.java 3 files changed, 89 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5f3d97ef91791a454191ddcc134ec78a3471981 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: invoke endAction on RemoveCinderSnapshotCommandCallback
by tnisan＠redhat.com 10 Aug '15

10 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: invoke endAction on RemoveCinderSnapshotCommandCallback ...................................................................... core: invoke endAction on RemoveCinderSnapshotCommandCallback Call endAction() on 'onFailed' and 'onSucceeded' methods (in RemoveCinderSnapshotCommandCallback) - to ensure invocation of the command endSuccessfully/endWithFailure. Change-Id: I3343bd49574d736c88d6baf5bc091d41f04632c3 Bug-Url: https://bugzilla.redhat.com/1240636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderSnapshotCommandCallback.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3343bd49574d736c88d6baf5bc091d41f04632c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: new VM provider
by oourfali＠redhat.com 10 Aug '15

10 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: new VM provider ...................................................................... webadmin: new VM provider - Fixed issue where the foreman/katello providers where not being populated during the new VM dialog causing it to fail to create a new VM. Change-Id: I200f8865991b6a6078e7a5048c77e6efe2bccebf Bug-Url: https://bugzilla.redhat.com/1202083 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I200f8865991b6a6078e7a5048c77e6efe2bccebf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0