January 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-hosted-engine-ha[master]: upgrade: adding a docstring for _is_conf_volume_there

by msivak＠redhat.com

Martin Sivák has submitted this change and it was merged. Change subject: upgrade: adding a docstring for _is_conf_volume_there ...................................................................... upgrade: adding a docstring for _is_conf_volume_there The code to detect the configuration image is not trivial so it's better to describe it. Since nothing calls prepareImage on the configuration image before we discover it, the volume shouldn't be available but it is so it's better to keep track of this behavior. Change-Id: I09cac64724fe77e51687ecaf558dc1eec47a5daa Bug-Url: https://bugzilla.redhat.com/1297457 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09cac64724fe77e51687ecaf558dc1eec47a5daa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in jenkins[master]: spagobi: added build job

by dcaro＠redhat.com

David Caro has submitted this change and it was merged. Change subject: spagobi: added build job ...................................................................... spagobi: added build job Added build job for translation team testing purpose Change-Id: I5a55be0620bae7b255caeb9ec7475b3f4b3433d9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/projects/spagobi/spagobi_create-rpms.yaml A jobs/confs/yaml/scms/spagobi.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml M jobs/confs/yaml/triggers/gerrit.yaml 4 files changed, 58 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/52542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a55be0620bae7b255caeb9ec7475b3f4b3433d9 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in jenkins[master]: vdsm-jsonrpc-java_create-rpms: updates

by dcaro＠redhat.com

David Caro has submitted this change and it was merged. Change subject: vdsm-jsonrpc-java_create-rpms: updates ...................................................................... vdsm-jsonrpc-java_create-rpms: updates - dropped jobs migrated to standard CI. - added check-patch job to run on unmerged patches Change-Id: I5b05b6a1617acc2afa164e6e5f74b6d6be64d7de Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_create-rpms.yaml M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_standard.yaml 2 files changed, 1 insertion(+), 45 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/52529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b05b6a1617acc2afa164e6e5f74b6d6be64d7de Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in jenkins[master]: Added fix_rpmdb_problems as a build step in upgrade jobs

by dcaro＠redhat.com

David Caro has submitted this change and it was merged. Change subject: Added fix_rpmdb_problems as a build step in upgrade jobs ...................................................................... Added fix_rpmdb_problems as a build step in upgrade jobs Change-Id: Ic802b9397d9f8af366230ab12b38aa342ec77010 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/confs/yaml/templates/engine-upgrade.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/52460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic802b9397d9f8af366230ab12b38aa342ec77010 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in jenkins[master]: Added fix_rpmdb_problems.sh as a builder in yaml

by dcaro＠redhat.com

David Caro has submitted this change and it was merged. Change subject: Added fix_rpmdb_problems.sh as a builder in yaml ...................................................................... Added fix_rpmdb_problems.sh as a builder in yaml The code was taken from ds jenkins yaml conf. Change-Id: Ifa1601ed330a7e9c596154538db392808e3de25c Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/shell-scripts/fix_rpmdb_problems.sh M jobs/confs/yaml/builders/cleanup.yaml 2 files changed, 62 insertions(+), 0 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/52456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa1601ed330a7e9c596154538db392808e3de25c Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Use JAX-RS 2.0 API artifacts

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use JAX-RS 2.0 API artifacts ...................................................................... restapi: Use JAX-RS 2.0 API artifacts The engine has been recently updated to work with WildFly 10. This version of WildFly implements JAX-RS 2.0, but we are still using 1.x artifacts for the build. This doesn't generate a real problem, but it may in the future. This patch changes the POM files so that they use versions of the artifact matching those provided by the application server. In addition, we are currently explicitly using the JAX-RS API artifacts provided by Resteasy, which introduces a bit of locking. To avoid that this patch changes the POM files so that they use more implementation independent artifacts where possible. The Resteasy artifacts still be needed by the tests, as they need an actual implementation of the JAX-RS API. Change-Id: I97ae0d6c9762d7e2130f4a1780a85bf8c1de38ec Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/pom.xml 5 files changed, 69 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97ae0d6c9762d7e2130f4a1780a85bf8c1de38ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: ClusterDaoTest members

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: ClusterDaoTest members ...................................................................... core: ClusterDaoTest members Converted members to local variables where possible in order to improve readability and reduce memory footprint. Change-Id: I27312b45a2cf9a3d9bd6c7b84fa78631236efe53 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27312b45a2cf9a3d9bd6c7b84fa78631236efe53 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: AddVmCommand validation early return

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommand validation early return ...................................................................... core: AddVmCommand validation early return Used the early return idiom to improve the validation methods' readability. Change-Id: I0ba706ba0cd60885197006722590b636b0e9fe43 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 29 insertions(+), 39 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ba706ba0cd60885197006722590b636b0e9fe43 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: ExistingVmModelBehavior local variables

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ExistingVmModelBehavior local variables ...................................................................... webadmin: ExistingVmModelBehavior local variables Removed redundant local variables. Change-Id: I2f9c43b3af1bea8abd790e58825a52893b326934 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f9c43b3af1bea8abd790e58825a52893b326934 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

Change in ovirt-engine[master]: core: EventsManager empty strings

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: EventsManager empty strings ...................................................................... core: EventsManager empty strings Remove useless empty strings being concatinated to SQL statements. Change-Id: Ifd413c8df48df51f761c5b00c6dc26a639d0c216 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd413c8df48df51f761c5b00c6dc26a639d0c216 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits January 2016