Change in ovirt-engine[master]: core: Disallow scan alignment on running VM disks
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Disallow scan alignment on running VM disks
......................................................................
core: Disallow scan alignment on running VM disks
Bug-Url: https://bugzilla.redhat.com/1297452
Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51173
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9ace1a9596f13225e493eda090d69a82d7c2bc1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: webadmin: 'passthrough' checkbox must be disabled for clust...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: 'passthrough' checkbox must be disabled for clusters less than 3.6
......................................................................
webadmin: 'passthrough' checkbox must be disabled for clusters less than 3.6
In UI, for clusters less than 3.6 - sriov checkboxes(passthrough) should be disabled
in the vNIC profile dialog and shouldn't appear in the vNICs type list(pci-passthrough)
Change-Id: Ia8ba807900f15410f3ab43831b5cf965621dd0ef
Bug-Url: https://bugzilla.redhat.com/1282441
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
2 files changed, 15 insertions(+), 1 deletion(-)
Approvals:
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51395
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8ba807900f15410f3ab43831b5cf965621dd0ef
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Default MTU equals to MTU 0
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Default MTU equals to MTU 0
......................................................................
engine: Default MTU equals to MTU 0
Change-Id: Icc623c22826fbc28ce43ee3a75cd2d5e00082491
Bug-Url: https://bugzilla.redhat.com/1295435
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidatorTest.java
2 files changed, 28 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51591
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc623c22826fbc28ce43ee3a75cd2d5e00082491
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: spice and vnc not available for blank template
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: spice and vnc not available for blank template
......................................................................
webadmin: spice and vnc not available for blank template
The check if the spice+vnc is available was checked against cluster version
which is not correct since the blank template has always the latest version.
Change-Id: I2b72175a9a76b43265faaeecd7a5b46789c30320
Bug-Url: https://bugzilla.redhat.com/1279524
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Jakub Niedermertl: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51366
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b72175a9a76b43265faaeecd7a5b46789c30320
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: added CA to .vv file's ovirt section
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: added CA to .vv file's ovirt section
......................................................................
webadmin: added CA to .vv file's ovirt section
Change-Id: I7aa47e8bac77f4d11f83b3460ad9da923d4a249f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1295455
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/AbstractConsoleWithForeignMenu.java
3 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51503
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7aa47e8bac77f4d11f83b3460ad9da923d4a249f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Default MTU equals to MTU 0
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Default MTU equals to MTU 0
......................................................................
engine: Default MTU equals to MTU 0
Change-Id: Icc623c22826fbc28ce43ee3a75cd2d5e00082491
Bug-Url: https://bugzilla.redhat.com/1295435
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidatorTest.java
2 files changed, 28 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51590
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc623c22826fbc28ce43ee3a75cd2d5e00082491
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6.2]: core: Add force compensation when creating a VM from Template
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add force compensation when creating a VM from Template
......................................................................
core: Add force compensation when creating a VM from Template
Adding a VM from Template and restart the engine might cause the VM to
be locked forever in the DB once the engine is started again.
The reason for that is because the compensation is not enforced in the
AddVmCommand,
Adding forceCompensation=True to the command's annotation should solve
this and remove the VM form the DB once the engine gets restarted.
Change-Id: Ibc465fe9dbd36e7582583865d185e35844cf3b76
Bug-Url: https://bugzilla.redhat.com/1297190
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51652
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc465fe9dbd36e7582583865d185e35844cf3b76
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6.2]: core: Quota storage calculating fix for floating disks.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Quota storage calculating fix for floating disks.
......................................................................
core: Quota storage calculating fix for floating disks.
While calculating the quota usage in CalculateStorageUsage psql function,
the calculated "actual size"- which is supposed to include disks
that are not active- DID calculate floating disks in that state.
This patch drops any consideration regarding whether a disk is connected
to a VM or not while calculating the quota usage of inactive disks.
Change-Id: Ib417215b2db6e0ee5ae3acad17b7dcf77b175cf6
Bug-Url: https://bugzilla.redhat.com/1225484
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M packaging/dbscripts/create_functions.sql
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/51647
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib417215b2db6e0ee5ae3acad17b7dcf77b175cf6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Quota storage calculating fix for floating disks.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Quota storage calculating fix for floating disks.
......................................................................
core: Quota storage calculating fix for floating disks.
While calculating the quota usage in CalculateStorageUsage psql function,
the calculated "actual size"- which is supposed to include disks
that are not active- DID calculate floating disks in that state.
This patch drops any consideration regarding whether a disk is connected
to a VM or not while calculating the quota usage of inactive disks.
Change-Id: Ib417215b2db6e0ee5ae3acad17b7dcf77b175cf6
Bug-Url: https://bugzilla.redhat.com/1225484
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M packaging/dbscripts/create_functions.sql
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/51646
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib417215b2db6e0ee5ae3acad17b7dcf77b175cf6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: gluster: java8 - use Callable functional interface
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: gluster: java8 - use Callable functional interface
......................................................................
gluster: java8 - use Callable functional interface
Change-Id: I300ae61c36dbe3c6ce3ae64db5c277fda6aa20b4
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetUpPasswordLessSSHInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
12 files changed, 143 insertions(+), 192 deletions(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50860
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I300ae61c36dbe3c6ce3ae64db5c277fda6aa20b4
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months