Change in ovirt-engine[master]: core: java8 - use Callable functional interface
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: java8 - use Callable functional interface
......................................................................
core: java8 - use Callable functional interface
Change-Id: I3d9d07b023c70f377135876022b045b5db400768
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/ConcurrentAgentsFenceActionExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
8 files changed, 70 insertions(+), 138 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50858
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d9d07b023c70f377135876022b045b5db400768
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: reports:fix bugs in br2a br2b and br2c
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: reports:fix bugs in br2a br2b and br2c
......................................................................
reports:fix bugs in br2a br2b and br2c
Fixed bug in br2a - number of active vms
br2b br2c - network interface usage
Change-Id: Id2ed10d5415e150992f3ae1b466d8c5cd2468990
Bug-Url: https://bugzilla.redhat.com/1289811
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data
3 files changed, 74 insertions(+), 51 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51240
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2ed10d5415e150992f3ae1b466d8c5cd2468990
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-release[master]: [Node] ovirt-release-master.spec: use relative links
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: [Node] ovirt-release-master.spec: use relative links
......................................................................
[Node] ovirt-release-master.spec: use relative links
This patch replaces the ln call for relative to make
sure the path of file is always readable.
Change-Id: I72a9bcf32e29d46ee7b96916302358b0c2d6a165
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M ovirt-release-master/ovirt-release-master.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51540
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72a9bcf32e29d46ee7b96916302358b0c2d6a165
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: db: Fix duplicate upgrade scripts names
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: db: Fix duplicate upgrade scripts names
......................................................................
db: Fix duplicate upgrade scripts names
Fixes duplicate upgrade script names which was introduced by improper
merging of patch Ief14e9e209b0ce3c7dd836e9dae5eecf8ae6ef47.
Change-Id: I5512eff9d5dcbb7305ec25f542817cb816f9bd19
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
R packaging/dbscripts/upgrade/04_00_0180_attach_cpu_profile_permissions.sql
R packaging/dbscripts/upgrade/04_00_0190_create_index_cpu_profiles.sql
2 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified; Passed CI tests
Eli Mesika: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/51622
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5512eff9d5dcbb7305ec25f542817cb816f9bd19
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: Video RAM size settings reworked
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Video RAM size settings reworked
......................................................................
core: Video RAM size settings reworked
Video RAM sizes are currently set in a wrong way. Especially one of the
most important parameters, `vgamem', is not set at all. That may
prevent setups with high resolution monitors from working.
This patch tries to set more reasonable video RAM sizes. It replaces
the old video RAM size computation (including removal of some unused
related code) with a new one, based on guest OS. The guest OS specifics
are set in osinfo.
We try to keep the computation as simple as possible, for the following
reasons:
1. Nobody can say what the perfect values are.
2. Things are likely to change in QEMU in future.
3. We try to be reasonably conservative not to break current setups.
Note that recent VDSM version is needed to set `vgamem' value (it's
ignored in older versions).
As we can't be sure about all older versions of VDSM, libvirt and QEMU,
we send the same values as before to clusters of older versions. These
may be not the best values but it's the safest approach. We may provide
means to override the memory values via osinfo in a followup patch.
Change-Id: I96ab9d40621ad12ec2505a2de75e3ff5af2f59d0
Bug-Url: https://bugzilla.redhat.com/1275539
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M packaging/conf/osinfo-defaults.properties
9 files changed, 155 insertions(+), 48 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/50092
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96ab9d40621ad12ec2505a2de75e3ff5af2f59d0
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6.2]: Update version of jsonrpc to 1.1.6
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Update version of jsonrpc to 1.1.6
......................................................................
Update version of jsonrpc to 1.1.6
Change-Id: Ibbb5df73051ad9d47c1ed47800f8ff309dd8fa34
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1259000
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Looks good to me, but someone else must approve
Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51554
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbb5df73051ad9d47c1ed47800f8ff309dd8fa34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: Update version of jsonrpc to 1.1.6
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: Update version of jsonrpc to 1.1.6
......................................................................
Update version of jsonrpc to 1.1.6
Change-Id: Ibbb5df73051ad9d47c1ed47800f8ff309dd8fa34
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1259000
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Moti Asayag: Looks good to me, but someone else must approve
Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbb5df73051ad9d47c1ed47800f8ff309dd8fa34
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: optionally restore permissions
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: engine-backup: optionally restore permissions
......................................................................
packaging: engine-backup: optionally restore permissions
If backing up with the custom dump format (which is the default), do
backup with owner and privileges, thus partially reverting I78fa18fe0d.
During restore, the user must pass one of '--restore-permissions' and
'--no-restore-permissions'.
With plain dump format, permissions are not backed up nor restored.
Also make engine-setup backup extra permissions on db objects and
restore them during rollback.
Bug-Url: https://bugzilla.redhat.com/1220791
Change-Id: Ib594d68c2f3539abf30ebb3f8f525cc366bfec26
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit d990a6055aedbea0cd2e3517e427d12c034ad5a9)
---
M packaging/bin/engine-backup.sh
M packaging/setup/ovirt_engine_setup/engine_common/database.py
2 files changed, 53 insertions(+), 15 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/51620
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib594d68c2f3539abf30ebb3f8f525cc366bfec26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: Update version of jsonrpc to 1.1.6
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: Update version of jsonrpc to 1.1.6
......................................................................
Update version of jsonrpc to 1.1.6
Change-Id: Ibbb5df73051ad9d47c1ed47800f8ff309dd8fa34
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1259000
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Moti Asayag: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51552
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbb5df73051ad9d47c1ed47800f8ff309dd8fa34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: Add force compensation when creating a VM from Template
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add force compensation when creating a VM from Template
......................................................................
core: Add force compensation when creating a VM from Template
Adding a VM from Template and restart the engine might cause the VM to
be locked forever in the DB once the engine is started again.
The reason for that is because the compensation is not enforced in the
AddVmCommand,
Adding forceCompensation=True to the command's annotation should solve
this and remove the VM form the DB once the engine gets restarted.
Change-Id: Ibc465fe9dbd36e7582583865d185e35844cf3b76
Bug-Url: https://bugzilla.redhat.com/1297190
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51592
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc465fe9dbd36e7582583865d185e35844cf3b76
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months