Change in ovirt-engine[ovirt-engine-3.6]: core: show data once on ISO shared from multi DCs
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: show data once on ISO shared from multi DCs
......................................................................
core: show data once on ISO shared from multi DCs
When the same ISO is shared to multiple DCs, this SP will return
duplicate rows (as the number of DCs having this ISO)
This is fixed by adding a DISTINCT ON (id) * to the select statement in
this SP, this will eliminate the results to the 1st matching record.
Change-Id: I7c9a1381aae2eb623d1743314a1fb6ef7795dcb6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1295742
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/storages_sp.sql
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Oved Ourfali: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51599
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c9a1381aae2eb623d1743314a1fb6ef7795dcb6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.2]: engine: dhcp network should has ip info
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: dhcp network should has ip info
......................................................................
engine: dhcp network should has ip info
Change-Id: I7b5a825de3e58fa1b56af979578fdcaa14360085
Bug-Url: https://bugzilla.redhat.com/1296614
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NicLabelsCompleter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
3 files changed, 31 insertions(+), 7 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51602
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b5a825de3e58fa1b56af979578fdcaa14360085
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: dhcp network should has ip info
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: dhcp network should has ip info
......................................................................
engine: dhcp network should has ip info
Change-Id: I7b5a825de3e58fa1b56af979578fdcaa14360085
Bug-Url: https://bugzilla.redhat.com/1296614
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NicLabelsCompleter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
3 files changed, 31 insertions(+), 7 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51601
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b5a825de3e58fa1b56af979578fdcaa14360085
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: engine: dhcp network should has ip info
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: dhcp network should has ip info
......................................................................
engine: dhcp network should has ip info
Change-Id: I7b5a825de3e58fa1b56af979578fdcaa14360085
Bug-Url: https://bugzilla.redhat.com/1296614
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NicLabelsCompleter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
3 files changed, 31 insertions(+), 7 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51577
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b5a825de3e58fa1b56af979578fdcaa14360085
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Added Roles and groups for cpu profiling
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Added Roles and groups for cpu profiling
......................................................................
core: Added Roles and groups for cpu profiling
The following CPU Profiles were added in order to prevent unauthorized
access to cpu profiles:
CpuProfileOperator - Will have the ability to Assign CPU Profile to VMs.
CpuProfileCreator - Will have the ability to Create/Update/Delete and
Assign CPU Profile to VMs.
Action groups that were added to engine and REST API:
Create CPU Profile, Update CPU Profile, Remove CPU Profile,
Assign CPU Profile.
Roles that were granted Create/Update/Delete and Assign permissions for
cpu profiles (Same as CpuProfileCreator + CpuProfileOperator):
SuperUser, PowerUser, ClusterAdmin, DataCenterAdmin.
Other roles that were granted permission same as the ones for
CpuProfileOperator:
CpuProfileCreator, UserVmManager, VmPoolAdmin, VmCreator,
UserTemplateBasedVm and UserVmRuntimeManager.
Before this patch, any user that had permissions for the cluster
associated with the CPU Profile, could Create/Update/Delete and Assign
it.
The Data Access Objects tests(DAO tests) were changed inorder to comply
with the new behaviour.
Change-Id: Ief14e9e209b0ce3c7dd836e9dae5eecf8ae6ef47
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java
M packaging/dbscripts/cpu_profiles_sp.sql
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_00_0140_attach_cpu_profile_permissions.sql
A packaging/dbscripts/upgrade/04_00_0150_create_index_cpu_profiles.sql
10 files changed, 238 insertions(+), 22 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49532
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief14e9e209b0ce3c7dd836e9dae5eecf8ae6ef47
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: validate profile is not attached before removing it
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: validate profile is not attached before removing it
......................................................................
core: validate profile is not attached before removing it
When deleting a profile, we will check that there are no
vms/templates attached to the profile.
For disk profile we'll check also for unattached disks (left disks).
Change-Id: Ic927e020118354751943b9890daef52373e3896f
Bug-Url: https://bugzilla.redhat.com/1142935
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/RemoveProfileCommandBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDaoImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M packaging/dbscripts/disk_images_sp.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
21 files changed, 305 insertions(+), 5 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/33903
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic927e020118354751943b9890daef52373e3896f
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6.2]: engine: Import clone VM without copy-collapse
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Import clone VM without copy-collapse
......................................................................
engine: Import clone VM without copy-collapse
The user should be able to import and clone a VM without snapshots
without setting copy-collapse to true via REST.
Also, when importing a VM without snapshots that is based on a template
the copy-collapse parameter should not be ignored.
The flow in this case in CopyImageGroupCommand should be the same as
when copy-collapse is set to true.
Change-Id: I8b3f2096341bef7a795813c304aebff3a0ee279e
Bug-Url: https://bugzilla.redhat.com/1147011
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/51597
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b3f2096341bef7a795813c304aebff3a0ee279e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: show data once on ISO shared from multi DCs
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: show data once on ISO shared from multi DCs
......................................................................
core: show data once on ISO shared from multi DCs
When the same ISO is shared to multiple DCs, this SP will return
duplicate rows (as the number of DCs having this ISO)
This is fixed by adding a DISTINCT ON (id) * to the select statement in
this SP, this will eliminate the results to the 1st matching record.
Change-Id: I7c9a1381aae2eb623d1743314a1fb6ef7795dcb6
Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1295742
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/storages_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c9a1381aae2eb623d1743314a1fb6ef7795dcb6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Import clone VM without copy-collapse
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Import clone VM without copy-collapse
......................................................................
engine: Import clone VM without copy-collapse
The user should be able to import and clone a VM without snapshots
without setting copy-collapse to true via REST.
Also, when importing a VM without snapshots that is based on a template
the copy-collapse parameter should not be ignored.
The flow in this case in CopyImageGroupCommand should be the same as
when copy-collapse is set to true.
Change-Id: I8b3f2096341bef7a795813c304aebff3a0ee279e
Bug-Url: https://bugzilla.redhat.com/1147011
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/51580
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b3f2096341bef7a795813c304aebff3a0ee279e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: CompatibilityVersionUtils.getEffective() with Supplier...
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: CompatibilityVersionUtils.getEffective() with Supplier<Version>
......................................................................
core: CompatibilityVersionUtils.getEffective() with Supplier<Version>
Added CompatibilityVersionUtils.getEffective() method variant that uses
Version supplier instead of VDSGroup supplier. It allows to use methods
that return cluster compatibility version directly, such as
ClusterUtils.getCompatibilityVersion().
Change-Id: Iaf4b4f8980429c697b36cd75e26c31dba41696e0
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CompatibilityVersionUtils.java
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51244
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf4b4f8980429c697b36cd75e26c31dba41696e0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months