Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Add storage attributes on import SD.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Add storage attributes on import SD.
......................................................................
webadmin: Add storage attributes on import SD.
Add storage attributes on import SD
Change-Id: I5cd6e0ea1209af0cdd3d5ea12d6108022115df30
Bug-Url: https://bugzilla.redhat.com/1295852
Bug-Url: https://bugzilla.redhat.com/1222571
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/51479
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cd6e0ea1209af0cdd3d5ea12d6108022115df30
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6.2]: build: ovirt-engine-3.6.2.2
by piotr.kliczewski＠gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: build: ovirt-engine-3.6.2.2
......................................................................
build: ovirt-engine-3.6.2.2
Change-Id: Ia4e27bcf806ffe839843ed5b08e92dec24c85815
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M automation/build-artifacts.sh
M backend/manager/dependencies/common/pom.xml
M backend/manager/dependencies/pom.xml
M backend/manager/dependencies/tools/pom.xml
M backend/manager/extensions-tool/pom.xml
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/auth-plugin/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/branding/pom.xml
M backend/manager/modules/builtin-extensions/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/docs/pom.xml
M backend/manager/modules/extensions-manager/pom.xml
M backend/manager/modules/logger/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/services/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/uutils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/modules/welcome/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/jboss-modules-maven-plugin/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M build/validations/pom.xml
M ear/pom.xml
M frontend/pom.xml
M frontend/webadmin/modules/frontend-symbols/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M mavenmake/pom.xml
M pom.xml
55 files changed, 54 insertions(+), 57 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51490
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4e27bcf806ffe839843ed5b08e92dec24c85815
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.2
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 4 months
Change in ovirt-engine[master]: core: CoCo - avoid using removeFromHirerchy on callback
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: CoCo - avoid using removeFromHirerchy on callback
......................................................................
core: CoCo - avoid using removeFromHirerchy on callback
Do not remove the command from hirerchy when it is ended so the
aggragator command can determine if the command succeeded or not.
Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736
Bug-Url: https://bugzilla.redhat.com/1288852
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllCinderSnapshotDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllVmCinderDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java
6 files changed, 13 insertions(+), 8 deletions(-)
Approvals:
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id60b300cda80fe2555f58f300ab83fad727be736
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: Change min allocated memory of blank template
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Change min allocated memory of blank template
......................................................................
core: Change min allocated memory of blank template
The min allocated memory of blank template was by default 0 which is not
correct and if such a template is edited, the validations fail.
Fixed by changing the min allocated memory to memory size for the blank
template if the min allocated memory was still 0 (do not touch if the user has
already changed it).
Change-Id: I860bf6567462b89260481d4435530295639a7c11
Bug-Url: https://bugzilla.redhat.com/1294488
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0170_chance_min_allocated_mem_of_blank.sql
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I860bf6567462b89260481d4435530295639a7c11
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine-cli[master]: cli: Improve the "no console found" messages
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Improve the "no console found" messages
......................................................................
cli: Improve the "no console found" messages
Currently the messages used to indicate that no console viewer was found
are the same for VNC and SPICE, and they are't very friendly as they
don't provide a hint about the binary that needs to be installed. This
patch improves the messages so that they include a hint about the binary
that needs to be installed.
When the graphics protocol is SPICE the error message will be the
following:
a SPICE viewer was not found, please install a SPICE viewer (e.g.
remote-viewer) first.
When the graphics protocol is VNC the error message will be the
following:
a VNC viewer was not found, please install a VNC viewer (e.g.
remote-viewer, or vncviewer) first.
Change-Id: I9952a2576a8544be712123e8ce0b6b92babacda0
Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=807696#c13
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/cli/messages.py
M src/ovirtcli/platform/posix/spice.py
M src/ovirtcli/platform/posix/vnc.py
3 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51405
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9952a2576a8544be712123e8ce0b6b92babacda0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine-cli[master]: cli: Generate remote viewer config using UTF-8
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Generate remote viewer config using UTF-8
......................................................................
cli: Generate remote viewer config using UTF-8
Currently the CLI generates the remote-viewer configuration files using
the default encoding used by Python, which happens to be "ascii". One of
the pieces of information that is written to these files is the subject
of the certificate of the host. This is retrieved from the engine, and
it may contain characters that aren't part of the ASCII character set.
When this happens Python tries to encode text using the "ascii" codec,
and that generates an exception. To avoid that this patch changes the
CLI so that these configuration files are generated using an Unicode
template and encoding the result explicitly using the "utf-8" codec
instead of the default.
Change-Id: Ib85d5134da87f7d901f4a7ff3bedfb7d7a3af628
Bug-Url: https://bugzilla.redhat.com/807696
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M src/ovirtcli/platform/posix/spice.py
M src/ovirtcli/platform/posix/vnc.py
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib85d5134da87f7d901f4a7ff3bedfb7d7a3af628
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: restapi: Remove underscore prefix from Java names before par...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove underscore prefix from Java names before parsing
......................................................................
restapi: Remove underscore prefix from Java names before parsing
Some of the names used in the model conflict with Java reserved words.
For example the "nic.interface" property conflicts with the Java
"interface" reserved word. To avoid this conflict the model uses the
uderscore character as a prefix:
interface Nic {
String _interface();
}
But this underscore isn't currently removed from the name before adding
it to the model. As a result the generated XML schema contains also
the prefix:
<xs:complexType name="Nic">
<xs:complexContent>
<xs:extension base="BaseDevice">
<xs:sequence>
<xs:element name="_interface" .../>
...
</xs:sequence>
</xs:extension>
</xs:complexContent>
</xs:complexType>
One of the effects of this is that when the server receives a request
that doesn't contain the undercore it rejects it, because it is
syntactically incorrect according to the XML schema.
This patch changes the model analyzer so that it will remove underscores
used as prefixes of suffixes. The XML schema will then be generated
correctly.
Change-Id: If5d0ab57e3cb81f79e1c6b4a45e94dd89e8fe48e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/metamodel/analyzer/src/main/java/org/ovirt/api/metamodel/analyzer/ModelAnalyzer.java
1 file changed, 27 insertions(+), 11 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5d0ab57e3cb81f79e1c6b4a45e94dd89e8fe48e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: packaging: setup: Upgrade aaa-jdbc extension during engine-s...
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: packaging: setup: Upgrade aaa-jdbc extension during engine-setup
......................................................................
packaging: setup: Upgrade aaa-jdbc extension during engine-setup
1. Upgrades aaa-jdbc extension during engine-setup
2. Adds aaa-jdbc package to version lock
Bug-Url: https://bugzilla.redhat.com/1293338
Change-Id: Id3532bc657b279e413b93ac734f4aaa5a8cb5711
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaajdbc.py
2 files changed, 51 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51291
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3532bc657b279e413b93ac734f4aaa5a8cb5711
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: webadmin: Set properties only for File SD.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Set properties only for File SD.
......................................................................
webadmin: Set properties only for File SD.
The use of storageModel for block SD is null.
the GUI should set of Storage Type only for File Storage Domain
since the block Storage Domain is handled differently.
Changing the code to be used only when adding file SD.
Change-Id: I5cd6e0ea1209af0cdd3d5ea12d6108022115df30
Bug-Url: https://bugzilla.redhat.com/1295852
Bug-Url: https://bugzilla.redhat.com/1222571
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/51474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cd6e0ea1209af0cdd3d5ea12d6108022115df30
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months
Change in ovirt-engine[master]: core: fixed duplicates forming substandard coding style.
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: fixed duplicates forming substandard coding style.
......................................................................
core: fixed duplicates forming substandard coding style.
Change-Id: I371bf5f02492bfcc98a9aec74f6ae61188352b05
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java
1 file changed, 47 insertions(+), 104 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/48111
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I371bf5f02492bfcc98a9aec74f6ae61188352b05
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 4 months