January 2016 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: Filter out child Cinder commands on end action.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Filter out child Cinder commands on end action. ...................................................................... core: Filter out child Cinder commands on end action. EndAction was being called only for image commands. Cinder commands should get filtered out on endAction since the logic is already being done as part of the Cinder command endAction. In the future this filtering should be removed and the child endAction should be called abstractically for Cinder and Image volumes. Change-Id: Ia8e5119ec55f498b4a688334cd6302abe7287388 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 16 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8e5119ec55f498b4a688334cd6302abe7287388 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Lock VM should not be done on revert tasks

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Lock VM should not be done on revert tasks ...................................................................... core: Lock VM should not be done on revert tasks Lock of VM should not be done when reverting tasks to avoid deadlock. Change-Id: I75e9dea5fa9edcab0961b5180190308ae475daf1 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75e9dea5fa9edcab0961b5180190308ae475daf1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CoCo, prevent using removeFromHirerchy on callback.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: CoCo, prevent using removeFromHirerchy on callback. ...................................................................... core: CoCo, prevent using removeFromHirerchy on callback. Do not remove the command from hirerchy when it is ended so the aggragator command can determine if the command succeeded or not. Change-Id: I36d8582d22c63760dd55cd8c5ac5855ccd32b577 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d8582d22c63760dd55cd8c5ac5855ccd32b577 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Call concurrent execution callback on add vm command.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Call concurrent execution callback on add vm command. ...................................................................... core: Call concurrent execution callback on add vm command. Add a call for ConcurrentChildCommandsExecutionCallback to be called for addVmCommand and set the parameter isUseCinderCommandCallback with the appropriate value. Change-Id: I59f0875526fd28bad4ba37746658a591bb9bb123 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59f0875526fd28bad4ba37746658a591bb9bb123 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add callback for create VM from Template with Cinder.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Add callback for create VM from Template with Cinder. ...................................................................... core: Add callback for create VM from Template with Cinder. Failure flow add callback for addVMFromTemplateCommand. Change-Id: I2d7f8e1f5974aa9a3777a9c02e518047b7e1bf5b Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d7f8e1f5974aa9a3777a9c02e518047b7e1bf5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CoCo revert tasks of clone Cinder disks.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: CoCo revert tasks of clone Cinder disks. ...................................................................... core: CoCo revert tasks of clone Cinder disks. Failure flow, once a template is failed to be created the Template disks which were created should be removed. Change-Id: Ia6229fe8d9ac1b8d6499f306b3d034f6308a6bf5 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java 1 file changed, 45 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6229fe8d9ac1b8d6499f306b3d034f6308a6bf5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Refactor call back of CloneSingleCinderDisk

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor call back of CloneSingleCinderDisk ...................................................................... core: Refactor call back of CloneSingleCinderDisk since CloneCinderDisksCallBack command aggragates all its child commands statuses there is no need to remove those commands from the hierarchy, only the parent command should remove those commands from the hierarchy. Change-Id: I5a65c594b0454f2ec7cfaff75c69d0208f5f1217 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommandCallback.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a65c594b0454f2ec7cfaff75c69d0208f5f1217 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Aggregate all commands in call back on failure.

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Aggregate all commands in call back on failure. ...................................................................... core: Aggregate all commands in call back on failure. Set the command as failed only when all the disks has finished to get created so the revert operation will not collapse with the creation operation of Cinder. Change-Id: I382f4b6ce4fe22c3dd565e2211d350f1a1649ba4 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneCinderDisksCommandCallback.java 1 file changed, 14 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I382f4b6ce4fe22c3dd565e2211d350f1a1649ba4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Change error to warn on query execution

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Change error to warn on query execution ...................................................................... core: Change error to warn on query execution When we delete a snapshot the GUI might not get refreshed instantly and the GetVmConfigurationBySnapshotQuery might get executed and find out the snapshot no longer exists. This message should not be an error, since this is only a synchronization issue. Change-Id: I2ea8c965cfeeacfd4711c909529c975d6deecdb8 Bug-Url: https://bugzilla.redhat.com/1288852 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/51329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ea8c965cfeeacfd4711c909529c975d6deecdb8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: missing cast of memory dump disk size to bigint

by ahadas＠redhat.com

Arik Hadas has submitted this change and it was merged. Change subject: core: missing cast of memory dump disk size to bigint ...................................................................... core: missing cast of memory dump disk size to bigint Recently added upgrade scripts that convert hibernation/memory dump volumes to disks, were missing the cast mentioned above which causes an error (that would happen for VMs with more than 1g of memory) of type: integer out of range Change-Id: I50a917b10dc15d2b8aa1b6619dc67386f6ba62cb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0040_convert_hibernation_volumes_to_disks.sql M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Alexander Wels: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50a917b10dc15d2b8aa1b6619dc67386f6ba62cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

8 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits January 2016