Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Change Unassigned host status to Activating
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Change Unassigned host status to Activating
......................................................................
webadmin: Change Unassigned host status to Activating
The Unassigned status is set when the host is being activated.
However, Unassigned is less meaningful when shown in the webadmin
for the host. Changing to 'Activating' will better describe
the initial status of the activation process.
Change-Id: Idf3139f958e880dbb11846c86a32b370ee1028d3
Bug-Url: https://bugzilla.redhat.com/1295197
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51356
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf3139f958e880dbb11846c86a32b370ee1028d3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Show correct error message when can't connect to VM
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Show correct error message when can't connect to VM
......................................................................
webadmin: Show correct error message when can't connect to VM
When it's not possible to connect to a VM cause of no available protocol
show a correct error message that does not contain the protocol name (leads
to NPE)
Change-Id: I8725429705e49cf506a80495fc510c169a515d60
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1295728
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/VmConsolesImpl.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51372
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8725429705e49cf506a80495fc510c169a515d60
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-reports[master]: build: after build reports for 3.6.2.2
by sradco@redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: after build reports for 3.6.2.2
......................................................................
build: after build reports for 3.6.2.2
Change-Id: Iaaf80bb4dacd17fdcae4c71088852bba5a61c45b
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51376
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaaf80bb4dacd17fdcae4c71088852bba5a61c45b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-reports[master]: build: build reports for 3.6.2.2
by sradco@redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: build reports for 3.6.2.2
......................................................................
build: build reports for 3.6.2.2
Change-Id: Ia298ae3d4f8dcbf01470ce3ced2ff16559086e2f
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M version.mak
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51375
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia298ae3d4f8dcbf01470ce3ced2ff16559086e2f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: Protect the hard drive (exclusive access) when converting VM...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Protect the hard drive (exclusive access) when converting VM cfg from OVF
......................................................................
Protect the hard drive (exclusive access) when converting VM cfg from OVF
Change-Id: Ibff658fa7a5f679b6ef072a5a1d9ee796a93c02a
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit ca71b8b7effcb29c6fe505ab78cf069406d4311b)
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibff658fa7a5f679b6ef072a5a1d9ee796a93c02a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-hosted-engine-ha[master]: Protect the hard drive (exclusive access) when converting VM...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Protect the hard drive (exclusive access) when converting VM cfg from OVF
......................................................................
Protect the hard drive (exclusive access) when converting VM cfg from OVF
Change-Id: Ibff658fa7a5f679b6ef072a5a1d9ee796a93c02a
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Simone Tiraboschi: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51371
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibff658fa7a5f679b6ef072a5a1d9ee796a93c02a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: Print lock acquire message during command execution
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Print lock acquire message during command execution
......................................................................
core: Print lock acquire message during command execution
Having the message logged in INFO level will ease the tracking
of locks which were acquired using the lock-wait interface.
This will allow to identify the lock acquire and release when
reading the logs.
Change-Id: I45544f52031010a64e785483f6aaeb825aafcb52
Bug-Url: https://bugzilla.redhat.com/1293944
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45544f52031010a64e785483f6aaeb825aafcb52
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: engine: Removed orphan comment
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Removed orphan comment
......................................................................
engine: Removed orphan comment
The comment should have been removed when this class was
refactored.
Change-Id: I1a458956cda3e3158314cf8f911b19fa0c9e0536
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51351
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a458956cda3e3158314cf8f911b19fa0c9e0536
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: webadmin: Change Unassigned host status to Activating
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Change Unassigned host status to Activating
......................................................................
webadmin: Change Unassigned host status to Activating
The Unassigned status is set when the host is being activated.
However, Unassigned is less meaningful when shown in the webadmin
for the host. Changing to 'Activating' will better describe
the initial status of the activation process.
Change-Id: Idf3139f958e880dbb11846c86a32b370ee1028d3
Bug-Url: https://bugzilla.redhat.com/1295197
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf3139f958e880dbb11846c86a32b370ee1028d3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: engine: Delete unused code
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Delete unused code
......................................................................
engine: Delete unused code
The ForemanOperatingSystem is not used and can be removed.
Change-Id: Iacbcce96d923fac342323e977d1ebedf09077792
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanOperatingSystem.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanOperatingSystemWrapper.java
3 files changed, 0 insertions(+), 99 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacbcce96d923fac342323e977d1ebedf09077792
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months