Change in ovirt-engine[master]: core: cleanup in the addition of unmanaged vms
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in the addition of unmanaged vms
......................................................................
core: cleanup in the addition of unmanaged vms
Minor cleanup in the recently added command that adds
unmanaged VMs.
Change-Id: I279ca24350e15d1194ac561e298916f14ef3f3b7
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
1 file changed, 16 insertions(+), 18 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I279ca24350e15d1194ac561e298916f14ef3f3b7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: extract external vms handling from vms monitoring
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: extract external vms handling from vms monitoring
......................................................................
core: extract external vms handling from vms monitoring
The handling of external VMs became more complicated with the
introduction of the hosted engine and PPC. This patch extracts
that handling to separate command in order to simplify the
VMs-monitoring.
Change-Id: I6ff8a034a01223f4063524931881cb06682a8604
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddUnmanagedVmsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
8 files changed, 268 insertions(+), 108 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51056
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ff8a034a01223f4063524931881cb06682a8604
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-guest-agent[ovirt-3.5]: packaging: Add windows spec and jenkins automation
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: packaging: Add windows spec and jenkins automation
......................................................................
packaging: Add windows spec and jenkins automation
Copied from master with slight modifications.
Change-Id: I19bcd8e7e8b09c1d3bea3ea80891b080bef2f252
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
A automation/README.md
A automation/build-artifacts.packages
A automation/build-artifacts.repos
A automation/build-artifacts.sh
A automation/check-patch.packages
A automation/check-patch.sh
A ovirt-guest-agent-windows.spec
7 files changed, 155 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Vinzenz Feenstra: Looks good to me, approved; Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/47971
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19bcd8e7e8b09c1d3bea3ea80891b080bef2f252
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: engine: Blank template doesn't appear in user portal's new v...
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Blank template doesn't appear in user portal's new vm dialog
......................................................................
engine: Blank template doesn't appear in user portal's new vm dialog
Regression caused by commit- Ibdb5e05a18c7c08be8aa68226289c3d524d82a9d
Change-Id: I48d3c2879b4261bdead61fddc7ceff2cfc479e8b
Bug-Url: https://bugzilla.redhat.com/1293152
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Alona Kaplan: Verified; Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48d3c2879b4261bdead61fddc7ceff2cfc479e8b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: webadmin: Adding back 'Prestarted VMs' label
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Adding back 'Prestarted VMs' label
......................................................................
webadmin: Adding back 'Prestarted VMs' label
Adding back 'Prestarted VMs' label, that was accidentally lost when all
labels were moved from Java code to ui.xml file (see
https://gerrit.ovirt.org/#/c/49112/).
Change-Id: I8236ab826d14317a06983359dad6d794d8e03dad
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8236ab826d14317a06983359dad6d794d8e03dad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: restapi: Fix the command params for SRIOV related commands
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: restapi: Fix the command params for SRIOV related commands
......................................................................
restapi: Fix the command params for SRIOV related commands
* Send proper parameters from REST API code to AddVfsConfigLabel
and AddVfsConfigLabel commands.
* AddVfsConfigLabelCommand returns the label it has created,
so it could be loaded by REST code back.
Change-Id: Icad91b6b1d6e8ec3c7834776fd677fd4785c77a3
Bug-Url: https://bugzilla.redhat.com/1295198
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddVfsConfigLabelCommand.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedLabelsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVirtualFunctionAllowedNetworkResource.java
3 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/51239
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icad91b6b1d6e8ec3c7834776fd677fd4785c77a3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: rm VmPoolDao#getVmDataFromPoolByPoolName
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm VmPoolDao#getVmDataFromPoolByPoolName
......................................................................
core: rm VmPoolDao#getVmDataFromPoolByPoolName
Removed the unused
VmPoolDao#getVmDataFromPoolByPoolName(String, Guid, boolean) method,
its implementation and the underlying stored procedure
Change-Id: Id7560318a3bb8aa9a225e7e6e9f72d7da0120366
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDaoImpl.java
M packaging/dbscripts/vm_pools_sp.sql
3 files changed, 0 insertions(+), 45 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50616
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7560318a3bb8aa9a225e7e6e9f72d7da0120366
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: VdcEventNotificationUtils#getNotificationEventsByType
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VdcEventNotificationUtils#getNotificationEventsByType
......................................................................
core: VdcEventNotificationUtils#getNotificationEventsByType
Remove unused method.
Change-Id: Iee4a90191330b62d5d47d88bc7a9e21d65ca1453
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
1 file changed, 0 insertions(+), 16 deletions(-)
Approvals:
Allon Mureinik: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee4a90191330b62d5d47d88bc7a9e21d65ca1453
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: Remove CommandCoordinatorUtil unused method
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove CommandCoordinatorUtil unused method
......................................................................
core: Remove CommandCoordinatorUtil unused method
Change-Id: Ie7260fd574996e6dc1b7cb0461813c8b71a3f935
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50607
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7260fd574996e6dc1b7cb0461813c8b71a3f935
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: ShellLikeConfd comparator
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ShellLikeConfd comparator
......................................................................
core: ShellLikeConfd comparator
Clean up the code by using Comparator's function references instead of
re-implementing this logic inline.
Change-Id: Id2621d4713933599444f3f6b955cf24ba65ad18b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/config/ShellLikeConfd.java
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2621d4713933599444f3f6b955cf24ba65ad18b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months