January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: NegotiateAuthUtils comparator
by amureini＠redhat.com 03 Jan '16

03 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: NegotiateAuthUtils comparator ...................................................................... core: NegotiateAuthUtils comparator Clean up the code by using Comparator's function references instead of re-implementing this logic inline. Change-Id: I64eec644c6b7367885d3bf1e748a3f6c99c7ae88 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/NegotiateAuthUtils.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64eec644c6b7367885d3bf1e748a3f6c99c7ae88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: reports:fix bugs in br2a br2b and br2c
by sradco＠redhat.com 03 Jan '16

03 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: reports:fix bugs in br2a br2b and br2c ...................................................................... reports:fix bugs in br2a br2b and br2c Fixed bug in br2a - number of active vms br2b br2c - network interface usage Change-Id: Id2ed10d5415e150992f3ae1b466d8c5cd2468990 Bug-Url: https://bugzilla.redhat.com/1289811 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_hour_of_day_br2c_files/single_host_resource_usage_hour_of_day_br2c_jrxml.data 3 files changed, 80 insertions(+), 54 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2ed10d5415e150992f3ae1b466d8c5cd2468990 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: show snapshot name properly after live merge of snapsh...
by tnisan＠redhat.com 03 Jan '16

03 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: show snapshot name properly after live merge of snapshot disk ...................................................................... core: show snapshot name properly after live merge of snapshot disk After Live Merge of a snapshot disk (Storage > Disk Snapshots > Remove), the audit log shows the snapshot name of '<UNKNOWN>'. The problem is that the image record is used to look up the name, and this is not available after the merge operation is done. Instead, cache the snapshot name in the parameters and refer to this after the merge operation is complete. Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Bug-Url: https://bugzilla.redhat.com/1204609 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveDiskSnapshotsParameters.java 2 files changed, 19 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48526 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I253806b89f31cb31e0a145dfe22a6f3ba30579f8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine: remove out of sync indication for unmanaged network
by tnisan＠redhat.com 03 Jan '16

03 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: remove out of sync indication for unmanaged network ...................................................................... engine: remove out of sync indication for unmanaged network Remove out of sync icon indication for unmanaged network in SubTabHostInterfaceView table. Change-Id: I5058c38b6158c8438c7cc362b15578d9c0ca72e4 Bug-Url: https://bugzilla.redhat.com/1258735 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5058c38b6158c8438c7cc362b15578d9c0ca72e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Integrate NetworkAttachmentIpConfigurationValidator
by alkaplan＠redhat.com 03 Jan '16

03 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Integrate NetworkAttachmentIpConfigurationValidator ...................................................................... engine: Integrate NetworkAttachmentIpConfigurationValidator Add ip configuration validation to HostSetupNetworksValidator. After consulting where the vailidation should happened, it was decided that the validation will occur only in the backend. Please note, The web application has a default ip configuration set for boot protocol none and additional validaition to other boot protocols. Regarding the REST API cilent, the decision was different from the web application as no validaiton nor default ip configuration will be set. It reasonable to ask a script writer to be responisable enought to meet the demand for valid ip configuration. It was also decided not to enforce a valid ip configuration via api.xsd in order to keep it as general as possible. Also, please note that only new network attachment should pass the ip configuration validation as already exist attached network has different logic. For example, a network with dhcp already configured will have ip details. Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java 5 files changed, 115 insertions(+), 109 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19b5f0f15f3fc494301928cfcb957bd09863c6c2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Introudce NetworkAttachmentIpConfigurationValidator
by alkaplan＠redhat.com 03 Jan '16

03 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introudce NetworkAttachmentIpConfigurationValidator ...................................................................... engine: Introudce NetworkAttachmentIpConfigurationValidator The validator will validate the network attachment's ip configuration. A valid ip configuration must has a primary address with valid boot protocol and ip details. In case the boot protocol is static, ip details must contains ip addres and netmask. Please note that gateway is not mandatory as the kernal can complete it with a default one. For dhcp or none boot protocols, no ip details should be mentioned. In case of dhcp, the dhcp itself should determine it. Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/NetworkAttachmentIpConfigurationValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 280 insertions(+), 1 deletion(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I589013ef2b6783c77a424a8d21fad5da8a7f3250 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix HostSetupNetworkModel ipConfiguration param
by alkaplan＠redhat.com 03 Jan '16

03 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: fix HostSetupNetworkModel ipConfiguration param ...................................................................... webadmin: fix HostSetupNetworkModel ipConfiguration param When network boot protocol is none or dhcp no ip details (address, netmask , gateway) should be mentioned. The patch will fill those if exist only in case network boot protocl is static. Change-Id: I555e9c5b52c1aa3f774572734ef09461fa16fa98 Bug-Url: https://bugzilla.redhat.com/1270807 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/50582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I555e9c5b52c1aa3f774572734ef09461fa16fa98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: restapi: unable to remove QoS from network during update
by tnisan＠redhat.com 03 Jan '16

03 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: unable to remove QoS from network during update ...................................................................... restapi: unable to remove QoS from network during update Change-Id: Iba78dc33ea3fb4daa2a5d4ab15e09f8d43c46642 Bug-Url: https://bugzilla.redhat.com/1278297 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Alona Kaplan: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba78dc33ea3fb4daa2a5d4ab15e09f8d43c46642 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.2]: engine: make gateway as sync property
by tnisan＠redhat.com 03 Jan '16

03 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: make gateway as sync property ...................................................................... engine: make gateway as sync property The gateway will be reported as out of sync in case of a difference between reported and defined gateway. please note that the gateway's syncness is being checked only in case both defined and reported boot protocol are static. The reason is that in case that boot protocol is DHCP then the gateway is being determined locally, contrary when it is static which is being defined by the user. Change-Id: I2a8b206692e459992630d7b8558801e9d6e0b426 Bug-Url: https://bugzilla.redhat.com/1270688 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java 2 files changed, 35 insertions(+), 6 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a8b206692e459992630d7b8558801e9d6e0b426 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.2 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: unable to remove QoS from network during update
by tnisan＠redhat.com 03 Jan '16

03 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: unable to remove QoS from network during update ...................................................................... restapi: unable to remove QoS from network during update Change-Id: Iba78dc33ea3fb4daa2a5d4ab15e09f8d43c46642 Bug-Url: https://bugzilla.redhat.com/1278297 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Alona Kaplan: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba78dc33ea3fb4daa2a5d4ab15e09f8d43c46642 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0