October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: spec: added dependency on pyliblzma
by sbonazzo＠redhat.com 20 Oct '16

20 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: added dependency on pyliblzma ...................................................................... packaging: spec: added dependency on pyliblzma Added missing dependency on pyliblzma. Change-Id: I1a94cae684aab37cfd607b2a4193a565bf5507b0 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a94cae684aab37cfd607b2a4193a565bf5507b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix default data base name in README
by amureini＠redhat.com 20 Oct '16

20 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix default data base name in README ...................................................................... core: fix default data base name in README Make the name of the test database in README consistent to backend/manager/modules/dal/src/test/filters/pgsql.properties. Change-Id: Icf486a62834b28d236fe94e2e66c4b4f3158ad3c Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/dal/README 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dominik Holler: Verified Allon Mureinik: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf486a62834b28d236fe94e2e66c4b4f3158ad3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI

1 0

Change in ovirt-engine[master]: restapi: Make Ip.version optional
by juan.hernandez＠redhat.com 20 Oct '16

20 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Make Ip.version optional ...................................................................... restapi: Make Ip.version optional The value of the "Ip.version" attribute can be inferred from the value "Ip.address" attribute. This patch implements that behaviour. Change-Id: Ibdeb00ffa8ca63dfe62540e07d9bdb852153a25b Bug-Url: Related-To: https://bugzilla.redhat.com/1381240 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/IpHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/IpHelperTest.java 4 files changed, 142 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdeb00ffa8ca63dfe62540e07d9bdb852153a25b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddQuotaCommandTest @Spy annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddQuotaCommandTest @Spy annotation ...................................................................... core: AddQuotaCommandTest @Spy annotation Use the @Spy annotation to facilitate injecting mocks to the command under test in the following patches in the series. Change-Id: I1d1011492f148c3d5d02dbcc091fccc8d62e083f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddQuotaCommandTest.java 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d1011492f148c3d5d02dbcc091fccc8d62e083f Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveQuotaCommandTest single command instance
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveQuotaCommandTest single command instance ...................................................................... core: RemoveQuotaCommandTest single command instance Rework the test to use a single command instance, annotated with @Spy and @InjectMocks in order to reduce code duplication and allow easier injections. Instead of using different Quota objects, the test setup initializes a single Quota data member which specific tests can continue and specialize (e.g., by setting it to be the default quota). Change-Id: I97a048f6d4749c915a735cb904a08c15f78347b3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java 1 file changed, 18 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97a048f6d4749c915a735cb904a08c15f78347b3 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateQuotaCommandTest @Spy annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateQuotaCommandTest @Spy annotation ...................................................................... core: UpdateQuotaCommandTest @Spy annotation Use the @Spy annotation to facilitate injecting mocks to the command under test in the following patches in the series. Change-Id: I2d66c77408639f036c00130e1621e039d8e51897 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateQuotaCommandTest.java 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d66c77408639f036c00130e1621e039d8e51897 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Convert 'all_content' parameter to 'All-Content' header
by omachace＠redhat.com 20 Oct '16

20 Oct '16

Ondra Machacek has submitted this change and it was merged. Change subject: Convert 'all_content' parameter to 'All-Content' header ...................................................................... Convert 'all_content' parameter to 'All-Content' header Older versions of the engine (before 4.1) only accepted the 'all_content' parameter as an HTTP header. To better support those versions of the engine this patch changes the SDK so that when the 'all_content' parameter is specified its value is copied to the 'All-Content' request header. So a request like this: GET /ovirt-engine/api/vms/123?all_content=true Will be translated into this: GET /ovirt-engine/api/vms/123?all_content=true All-Content: true Change-Id: I5f4be9028d50a1571a938956d960d7c299400515 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f4be9028d50a1571a938956d960d7c299400515 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Update to model 4.0.37 and metamodel 1.0.21
by omachace＠redhat.com 20 Oct '16

20 Oct '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.37 and metamodel 1.0.21 ...................................................................... Update to model 4.0.37 and metamodel 1.0.21 The more relevant changes in the new version of the model are the following: * Add missing `template` and `storage_domain` parameters to the operation that imports an image. * Add the `next_run` parameter to the operation that updates a virtual machine. * Add the `all_content` parameters to the operations that list and retrieve virtual machines. Change-Id: Ib8628580b0e6cadf8efff315b72e319bdb3cb9c2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8628580b0e6cadf8efff315b72e319bdb3cb9c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Rebase on snmp4j-2.4.1
by mperina＠redhat.com 20 Oct '16

20 Oct '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Rebase on snmp4j-2.4.1 ...................................................................... engine : Rebase on snmp4j-2.4.1 Upgrade snmp4j to 2.4.1 Change-Id: I332ce3270339d7115c65f6539dc3b4eaacfbf1b0 Bug-Url: https://bugzilla.redhat.com/1381279 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I332ce3270339d7115c65f6539dc3b4eaacfbf1b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: oVirt Live 4.0.5 RC3
by sbonazzo＠redhat.com 20 Oct '16

20 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: oVirt Live 4.0.5 RC3 ...................................................................... oVirt Live 4.0.5 RC3 Change-Id: I1f2fe0753e491ba2eaabaae4ce16c442679b253c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f2fe0753e491ba2eaabaae4ce16c442679b253c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0