October 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: mock_runner.sh: fix typos
by sbonazzo＠redhat.com 20 Oct '16

20 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: mock_runner.sh: fix typos ...................................................................... mock_runner.sh: fix typos Change-Id: I32a029456593b533b520f2c632f8ef7a7842de88 Signed-off-by: Pierre-Louis Bonicoli <pierre-louis(a)libregerbil.fr> --- M mock_configs/mock_runner.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Pilou: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32a029456593b533b520f2c632f8ef7a7842de88 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Pilou <pierre-louis(a)libregerbil.fr> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pilou <pierre-louis(a)libregerbil.fr> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateStoragePoolCommandTest mock supported versions
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateStoragePoolCommandTest mock supported versions ...................................................................... core: UpdateStoragePoolCommandTest mock supported versions Use the ConfigValue that defines the supported versions instead of reinventing the wheel. Change-Id: Ic7d4f59e84c6a967b34ede84a36e03910e833501 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 1 file changed, 4 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7d4f59e84c6a967b34ede84a36e03910e833501 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportRepoImageCommandTest @Spy annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ImportRepoImageCommandTest @Spy annotation ...................................................................... core: ImportRepoImageCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: Id1cb334ba6a1bd63bc35fcaa1a8b95cf09d63d40 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommandTest.java 1 file changed, 10 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1cb334ba6a1bd63bc35fcaa1a8b95cf09d63d40 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ExportRepoImageCommandTest @Spy annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ExportRepoImageCommandTest @Spy annotation ...................................................................... core: ExportRepoImageCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I661d4461912598004172d9c6d664a2a15b7cdad2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommandTest.java 2 files changed, 13 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I661d4461912598004172d9c6d664a2a15b7cdad2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportExportRepoImageCommandTest local vars
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ImportExportRepoImageCommandTest local vars ...................................................................... core: ImportExportRepoImageCommandTest local vars Remove unused local variables. Change-Id: I571bad9f2252370b7f11fd1c1f8c9d49844cbec2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I571bad9f2252370b7f11fd1c1f8c9d49844cbec2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ScanStorageForUnregisteredDisksCommandTest @Spy annota...
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ScanStorageForUnregisteredDisksCommandTest @Spy annotation ...................................................................... core: ScanStorageForUnregisteredDisksCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I28186bb56ee56456278e1b92b22f1106c3ea6107 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommandTest.java 1 file changed, 9 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28186bb56ee56456278e1b92b22f1106c3ea6107 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ForceSelectSPMCommandTest @Spy annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ForceSelectSPMCommandTest @Spy annotation ...................................................................... core: ForceSelectSPMCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I4f11b8f2df669a31335c3d816ecb19c157efe4a3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommandTest.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f11b8f2df669a31335c3d816ecb19c157efe4a3 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest @Spy annotation
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest @Spy annotation ...................................................................... core: ProcessOvfUpdateForStoragePoolCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Note that the command initializes its vmDeviceUtils directly as a data members with an Injector, so it must be mocked before the command is created - i.e., in a @BeforeClass method in a static context. Change-Id: I6942c896568322f95e2283bbf41f71c2ee67b044 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6942c896568322f95e2283bbf41f71c2ee67b044 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest redundant mo...
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest redundant mocking ...................................................................... core: ProcessOvfUpdateForStoragePoolCommandTest redundant mocking Remove redundant mocking of doCallRealMethod() which is the behavior of a spied object anyway. Change-Id: Ifa896cd5949f548340632c2e2e858b2cdfb0e819 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa896cd5949f548340632c2e2e858b2cdfb0e819 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmTemplateCommandTest stubbing
by tnisan＠redhat.com 20 Oct '16

20 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddVmTemplateCommandTest stubbing ...................................................................... core: AddVmTemplateCommandTest stubbing Replace hard to understand stubbing with standard mocking of the spied command. Change-Id: I36296abe8d52355c48d2b337a1ba4cb5d30437da Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java 1 file changed, 6 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36296abe8d52355c48d2b337a1ba4cb5d30437da Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0