October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Clean up Event's javadoc
by tnisan＠redhat.com 18 Oct '16

18 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Clean up Event's javadoc ...................................................................... webadmin: Clean up Event's javadoc Change-Id: I50da45a593810394930e6b9457c1e0917fb41895 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50da45a593810394930e6b9457c1e0917fb41895 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: UIConstants naming conventions
by tnisan＠redhat.com 18 Oct '16

18 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: UIConstants naming conventions ...................................................................... webadmin: UIConstants naming conventions Fixed the class' naming conventions as per the project's checkstyle definitions. Change-Id: Id1e8127c64346e0f6f2c092c6674b1f91bd20ab1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ManageBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/I18NExtraNameOrNoneValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_de_DE.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_es_ES.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_fr_FR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_ja_JP.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_ko_KR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_pt_BR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants_zh_CN.properties 17 files changed, 77 insertions(+), 77 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1e8127c64346e0f6f2c092c6674b1f91bd20ab1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Configure checkstyle for the backend
by tnisan＠redhat.com 18 Oct '16

18 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: build: Configure checkstyle for the backend ...................................................................... build: Configure checkstyle for the backend This patch configures maven-checkstyle-plugin in backend/pom.xml. Doing so has several advantages: 1. The plugin is configured once, and when authoring a new module under backend the author doesn't need to think whether or not to configure this plugin, and if so how. 2. A lot of repetitive boiler-plate configuration is saved. 3. Mistakes where checkstyle is not run (as happened, e.g., in the bll and utils modules) are avoided. Change-Id: I4dcee5050c90c30fc4ddeec1a0e9110536e18ddb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/extensions-tool/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml 5 files changed, 8 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dcee5050c90c30fc4ddeec1a0e9110536e18ddb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix RegexOptions javadoc
by tnisan＠redhat.com 18 Oct '16

18 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix RegexOptions javadoc ...................................................................... webadmin: Fix RegexOptions javadoc Fix references copied blindly from the .Net documentation to point to valid documentation, or remove them completely if they don't make sense in this context. Change-Id: Iaa5c83994f2e67e3bf16ac92b764692c2d626030 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RegexOptions.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa5c83994f2e67e3bf16ac92b764692c2d626030 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: JsonCustomTypeResolverBuilder javadoc
by tnisan＠redhat.com 18 Oct '16

18 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: JsonCustomTypeResolverBuilder javadoc ...................................................................... core: JsonCustomTypeResolverBuilder javadoc Removed useless empty @return tag. Change-Id: I48f3df631b501fda164c734370c2c94f4a728ed6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonCustomTypeResolverBuilder.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48f3df631b501fda164c734370c2c94f4a728ed6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove EnumCompat UI override
by tnisan＠redhat.com 18 Oct '16

18 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove EnumCompat UI override ...................................................................... webadmin: Remove EnumCompat UI override Most usages of EnumCompat were removed a long time ago. The last remaining usage in DateTime's override could be replaced with a straight forward for-loop that will allow us to remove this useless class. Change-Id: I7b870989e8f0f806eceaeadb2b268b63de097f72 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/EnumCompat.java 2 files changed, 6 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b870989e8f0f806eceaeadb2b268b63de097f72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove unused FrontendQueryAsyncResult
by tnisan＠redhat.com 18 Oct '16

18 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove unused FrontendQueryAsyncResult ...................................................................... webadmin: Remove unused FrontendQueryAsyncResult Change-Id: Ib83d0fe0bd05be9ff93f79a1e049ac2577e951ea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java 1 file changed, 0 insertions(+), 43 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/65482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib83d0fe0bd05be9ff93f79a1e049ac2577e951ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Run builds of API model in Fedora 24
by sbonazzo＠redhat.com 18 Oct '16

18 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Run builds of API model in Fedora 24 ...................................................................... Run builds of API model in Fedora 24 This pach changes the jobs that build the API model so that they run in Fedora 24 instead of CentOS 7. The reason for that is that the build needs now the 'publican' tool, and the version in CentOS (3.2.0) doesn't work correct with DockBook 5. Change-Id: I09f6f4b4496f6d4c5e5ecbe05daaf8b665b8b6ce Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-api-model/ovirt-engine-api-model_build.yaml M jobs/confs/projects/ovirt-engine-api-model/ovirt-engine-api-model_checks.yaml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09f6f4b4496f6d4c5e5ecbe05daaf8b665b8b6ce Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in mom[master]: Add bulk interfaces to the makefile.
by msivak＠redhat.com 18 Oct '16

18 Oct '16

Martin Sivák has submitted this change and it was merged. Change subject: Add bulk interfaces to the makefile. ...................................................................... Add bulk interfaces to the makefile. Change-Id: I4e74b0031470b06cd7a2282f931107d4cbc31fdb Bug-Url: https://bugzilla.redhat.com/1366556 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/65169 Continuous-Integration: Jenkins CI Reviewed-by: Phillip Bailey <phbailey(a)redhat.com> Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom/HypervisorInterfaces/Makefile.am 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/65169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e74b0031470b06cd7a2282f931107d4cbc31fdb Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.6
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.6 ...................................................................... [maven-release-plugin] prepare release 4.0.6 Change-Id: I667727490f4b65f7c761bdbc12068e7428ba6aaf --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I667727490f4b65f7c761bdbc12068e7428ba6aaf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0